Skip to content

Commit 224a808

Browse files
authored
Merge pull request #754 from oracle/owls-70853-remove-configured-cluster
OWLS-70853 remove configured cluster and default domain-home-in-image sample to use WLST
2 parents 1b9e40b + 76a86d9 commit 224a808

File tree

13 files changed

+16
-59
lines changed

13 files changed

+16
-59
lines changed

integration-tests/src/test/resources/domain5.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
adminServerName: admin-server
55
domainUID: domain5
66
clusterName: cluster-1
7-
clusterType: CONFIGURED
87
configuredManagedServerCount: 4
98
initialManagedServerReplicas: 2
109
managedServerNameBase: managed-server

integration-tests/src/test/resources/domain6.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
adminServerName: admin-server
55
domainUID: domain6
66
clusterName: cluster-1
7-
clusterType: DYNAMIC
87
configuredManagedServerCount: 4
98
initialManagedServerReplicas: 2
109
managedServerNameBase: managed-server

integration-tests/src/test/resources/domain7.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
adminServerName: admin-server
55
domainUID: domain7
66
clusterName: cluster-1
7-
clusterType: DYNAMIC
87
configuredManagedServerCount: 4
98
initialManagedServerReplicas: 2
109
managedServerNameBase: managed-server

integration-tests/src/test/resources/domain9.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
adminServerName: admin-server
55
domainUID: domain9
66
clusterName: cluster-1
7-
clusterType: DYNAMIC
87
configuredManagedServerCount: 4
98
initialManagedServerReplicas: 2
109
managedServerNameBase: managed-server

kubernetes/samples/scripts/common/validate.sh

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -231,24 +231,6 @@ function validateServerStartPolicy {
231231
fi
232232
}
233233

234-
#
235-
# Function to validate the cluster type value
236-
#
237-
function validateClusterType {
238-
validateInputParamsSpecified clusterType
239-
if [ ! -z "${clusterType}" ]; then
240-
case ${clusterType} in
241-
"CONFIGURED")
242-
;;
243-
"DYNAMIC")
244-
;;
245-
*)
246-
validationError "Invalid value for clusterType: ${clusterType}. Valid values are 'CONFIGURED' and 'DYNAMIC'."
247-
;;
248-
esac
249-
fi
250-
}
251-
252234
#
253235
# Function to validate the weblogic domain storage reclaim policy
254236
#
@@ -388,7 +370,6 @@ function validateCommonInputs {
388370
validateClusterName
389371
validateWeblogicCredentialsSecretName
390372
validateServerStartPolicy
391-
validateClusterType
392373
validateWeblogicImagePullPolicy
393374
validateWeblogicImagePullSecretName
394375

kubernetes/samples/scripts/create-weblogic-domain/domain-home-in-image/README.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ The script will perform the following steps:
4242
* Create a properties file, `domain.properties`, in the directory that is created above. This properties file will be used to create a sample WebLogic Server domain.
4343
* Clone the WebLogic docker-images project into the current directory using `git clone https://github.com/oracle/docker-images.git`.
4444
* Replace the built-in user name and password in the `properties/docker-build/domain_security.properties` file with the `username` and `password` that are supplied on the command line using the `-u` and `-p` options. These credentials need to match the WebLogic domain admin credentials in the secret that is specified via the `weblogicCredentialsSecretName` property in the `create-domain-inputs.yaml` file.
45-
* Build a Docker image based on the Docker sample, [Example Image with a WebLogic Server Domain using the Oracle WebLogic Deploy Tooling (WDT)](https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain-home-in-image-wdt) and [Example Image with a WebLogic Server Domain using WLST](https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain-home-in-image). It will create a sample WebLogic Server domain in the Docker image. Also, you can run the Docker sample, [Example Image with a WebLogic Server Domain](https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain-home-in-image), manually with the generated `domain.properties` to create a domain home image. **Note**: Oracle recommends keeping the domain home image private in the local repository.
45+
* Build a Docker image based on the Docker sample, [Example Image with a WebLogic Server Domain using the Oracle WebLogic Scripting Tooling (WLST)](https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain-home-in-image) or [Example Image with a WebLogic Server Domain using the Oracle WebLogic Deploy Tooling (WDT)](https://github.com/oracle/docker-images/tree/master/OracleWebLogic/samples/12213-domain-home-in-image-wdt). It will create a sample WebLogic Server domain in the Docker image. **Note**: Oracle recommends keeping the domain home image private in the local repository.
4646
* Create a tag that refers to the generated Docker image.
4747
* Create a Kubernetes domain YAML file, `domain.yaml`, in the directory that is created above. This YAML file can be used to create the Kubernetes resource using the `kubectl create -f` or `kubectl apply -f` command.
4848
```
@@ -101,10 +101,9 @@ The following parameters can be provided in the inputs file.
101101
| `adminNodePort` | Port number of the Administration Server outside the Kubernetes cluster. | `30701` |
102102
| `adminServerName` | Name of the Administration Server. | `admin-server` |
103103
| `clusterName` | Name of the WebLogic cluster instance to generate for the domain. | `cluster-1` |
104-
| `clusterType` | Type of the WebLogic Cluster. Legal values are `CONFIGURED` or `DYNAMIC`. | `DYNAMIC` |
105104
| `configuredManagedServerCount` | Number of Managed Server instances to generate for the domain. | `5` |
106-
| `domainHomeImageBase` | Base WebLogic binary image used to build the WebLogic domain image. The operator requires WebLogic Server 12.2.1.3.0 with patch 28076014 applied. Refer to [Weblogic Docker images](../../../../../site/weblogic-docker-images.md) for details on how to create one. | |
107-
| `domainHomeImageBuildPath` | Location of the WebLogic "domain home in image" Docker image in `https://github.com/oracle/docker-images.git` project. If not specified, use `./docker-images/OracleWebLogic/samples/12213-domain-home-in-image-wdt`. Another possible value is `./docker-images/OracleWebLogic/samples/12213-domain-home-in-image` which uses WLST scripts, instead of WDT, to generate the domain configuration. | `./docker-images/OracleWebLogic/samples/12213-domain-home-in-image-wdt` |
105+
| `domainHomeImageBase` | Base WebLogic binary image used to build the WebLogic domain image. The operator requires WebLogic Server 12.2.1.3.0 with patch 28076014 applied. Refer to [Weblogic Docker images](../../../../../site/weblogic-docker-images.md) for details on how to create one. If a different `domainHomeImageBase` is specified, the specified image needs to be built locally or pulled from a repository before the `create-domain.sh` script is executed. | |
106+
| `domainHomeImageBuildPath` | Location of the WebLogic "domain home in image" Docker image in `https://github.com/oracle/docker-images.git` project. If not specified, use "./docker-images/OracleWebLogic/samples/12213-domain-home-in-image". Another possible value is "./docker-images/OracleWebLogic/samples/12213-domain-home-in-image-wdt" which uses WDT, instead of WLST, to generate the domain configuration. | `./docker-images/OracleWebLogic/samples/12213-domain-home-in-image` |
108107
| `domainPVMountPath` | Mount path of the domain persistent volume. | `/shared` |
109108
| `domainUID` | Unique ID that will be used to identify this particular domain. Used as the name of the generated WebLogic domain as well as the name of the Kubernetes domain resource. This ID must be unique across all domains in a Kubernetes cluster. This ID cannot contain any character that is not valid in a Kubernetes service name. | `domain1` |
110109
| `exposeAdminNodePort` | Boolean indicating if the Administration Server is exposed outside of the Kubernetes cluster. | `false` |
@@ -161,7 +160,7 @@ spec:
161160
# If the domain home is in the image
162161
domainHomeInImage: true
163162
# The Operator currently does not support other images
164-
image: "12213-domain-home-in-image:latest"
163+
image: "domain-home-in-image:latest"
165164
# imagePullPolicy defaults to "Never"
166165
imagePullPolicy: "Never"
167166
# Identify which Secret contains the WebLogic Admin credentials (note that there is an example of
@@ -278,7 +277,7 @@ Spec:
278277
Server Start State: RUNNING
279278
Domain Home: /u01/oracle/user_projects/domains/domain1
280279
Domain Home In Image: true
281-
Image: 12213-domain-home-in-image:latest
280+
Image: domain-home-in-image:latest
282281
Image Pull Policy: Never
283282
Include Server Out In Pod Log: true
284283
Managed Servers:

kubernetes/samples/scripts/create-weblogic-domain/domain-home-in-image/create-domain-inputs.yaml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,6 @@ adminServerName: admin-server
1515
# in a Kubernetes cluster.
1616
domainUID: domain1
1717

18-
# Type of WebLogic Cluster
19-
# Legal values are "CONFIGURED" or "DYNAMIC"
20-
clusterType: DYNAMIC
21-
2218
# Determines which WebLogic Servers the Operator will start up
2319
# Legal values are "NEVER", "IF_NEEDED", or "ADMIN_ONLY"
2420
serverStartPolicy: IF_NEEDED
@@ -119,8 +115,7 @@ domainPVMountPath: /shared
119115

120116
# Location of the WebLogic "domain home in image" Docker image sample in the
121117
# `https://github.com/oracle/docker-images.git` project.
122-
# If not specified, use "./docker-images/OracleWebLogic/samples/12213-domain-home-in-image-wdt".
123-
# Another possible value is "./docker-images/OracleWebLogic/samples/12213-domain-home-in-image",
124-
# which uses a WLST script, instead of WDT, to generate the domain configuration.
125-
domainHomeImageBuildPath: ./docker-images/OracleWebLogic/samples/12213-domain-home-in-image-wdt
126-
118+
# If not specified, use "./docker-images/OracleWebLogic/samples/12213-domain-home-in-image".
119+
# Another possible value is "./docker-images/OracleWebLogic/samples/12213-domain-home-in-image-wdt",
120+
# which uses WDT, instead of WLST, to generate the domain configuration.
121+
domainHomeImageBuildPath: ./docker-images/OracleWebLogic/samples/12213-domain-home-in-image

kubernetes/samples/scripts/create-weblogic-domain/domain-home-in-image/properties-template.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ DB_PORT=1527
1111
DEBUG_FLAG=true
1212
DERBY_FLAG=true
1313
PRODUCTION_MODE_ENABLED=%PRODUCTION_MODE_ENABLED%
14-
CLUSTER_TYPE=%CLUSTER_TYPE%
14+
CLUSTER_TYPE=DYNAMIC
1515
JAVA_OPTIONS=%JAVA_OPTIONS%
1616
T3_CHANNEL_PORT=%T3_CHANNEL_PORT%
1717
T3_PUBLIC_ADDRESS=%T3_PUBLIC_ADDRESS%

kubernetes/samples/scripts/create-weblogic-domain/domain-home-on-pv/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,6 @@ The following parameters can be provided in the inputs file.
7373
| `adminNodePort` | Port number of the Administration Server outside the Kubernetes cluster. | `30701` |
7474
| `adminServerName` | Name of the Administration Server. | `admin-server` |
7575
| `clusterName` | Name of the WebLogic cluster instance to generate for the domain. | `cluster-1` |
76-
| `clusterType` | Type of the WebLogic Cluster. Legal values are `CONFIGURED` or `DYNAMIC`. | `DYNAMIC` |
7776
| `configuredManagedServerCount` | Number of Managed Server instances to generate for the domain. | `5` |
7877
| `createDomainFilesDir` | Directory to get all the create domain scripts and supporting files, including the script that is specified by the `createDomainScriptName` property. By default, this directory is set to the relative path `wlst`, and the create script will use the built-in WLST offline scripts in the `wlst` directory to create the WebLogic domain. It can also be set to the relative path `wdt`, and then the built-in WDT scripts will be used instead. An absolute path is also supported to point to an arbitrary directory in the file system. | `wlst` |
7978
| `createDomainScriptsMountPath` | Mount path of the directory where the create domain scripts are located inside the pod. | `/u01/weblogic` |

kubernetes/samples/scripts/create-weblogic-domain/domain-home-on-pv/create-domain-inputs.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ domainUID: domain1
1818
# If not specified, the value is derived from the domainUID as /shared/domains/<domainUID>
1919
domainHome: /shared/domains/domain1
2020

21-
# Type of WebLogic Cluster
22-
# Legal values are "CONFIGURED" or "DYNAMIC"
23-
clusterType: DYNAMIC
24-
2521
# Determines which WebLogic Servers the Operator will start up
2622
# Legal values are "NEVER", "IF_NEEDED", or "ADMIN_ONLY"
2723
serverStartPolicy: IF_NEEDED

0 commit comments

Comments
 (0)