Remove unnecessary diffs

Author: rjeberhard

operator/src/main/java/oracle/kubernetes/operator/DomainStatusUpdater.java

@@ -522,6 +522,7 @@ private Step getCallStep(DomainResource oldDomain, DomainStatus status) {
           .withMetadata(oldDomain.getMetadata())
           .withSpec(null)
           .withStatus(status);
+
       return RequestBuilder.DOMAIN.updateStatus(newDomain, DomainResource::getStatus,
           domainStatusUpdaterStep.createResponseStep(this));
     }

operator/src/main/java/oracle/kubernetes/operator/helpers/DomainPresenceInfo.java

@@ -37,8 +37,6 @@
 import oracle.kubernetes.operator.MakeRightDomainOperation;
 import oracle.kubernetes.operator.ProcessingConstants;
 import oracle.kubernetes.operator.WebLogicConstants;
-import oracle.kubernetes.operator.logging.LoggingFacade;
-import oracle.kubernetes.operator.logging.LoggingFactory;
 import oracle.kubernetes.operator.logging.ThreadLoggingContext;
 import oracle.kubernetes.operator.processing.EffectiveClusterSpec;
 import oracle.kubernetes.operator.processing.EffectiveServerSpec;
@@ -68,8 +66,6 @@
  * including the scan and the Pods and Services for servers.
  */
 public class DomainPresenceInfo extends ResourcePresenceInfo {
-  public static final LoggingFacade LOGGER = LoggingFactory.getLogger("Operator", "Operator");
-
   private final String domainUid;
   private final AtomicReference<DomainResource> domain;
   private final AtomicBoolean isDeleting = new AtomicBoolean(false);

operator/src/main/java/oracle/kubernetes/operator/helpers/JobHelper.java

@@ -208,37 +208,6 @@ private static class IntrospectionStartStep extends Step {
 
   }
 
-  private static String printJob(V1Job job) {
-    StringBuilder sb = new StringBuilder();
-    if (job != null) {
-      V1ObjectMeta metadata = job.getMetadata();
-      if (metadata != null) {
-        sb.append("name: ");
-        sb.append(metadata.getName());
-        sb.append(", creation: ");
-        sb.append(metadata.getCreationTimestamp());
-        sb.append(", generation: ");
-        sb.append(metadata.getGeneration());
-        sb.append(", resourceVersion: ");
-        sb.append(metadata.getResourceVersion());
-      } else {
-        sb.append("no metadata");
-      }
-      V1JobSpec spec = job.getSpec();
-      if (spec != null) {
-        spec.getTemplate().getSpec().getContainers().forEach(c -> {
-          sb.append(", image: ");
-          sb.append(c.getImage());
-        });
-      } else {
-        sb.append("no spec");
-      }
-    } else {
-      sb.append("null");
-    }
-    return sb.toString();
-  }
-
   private static class IntrospectorJobStepContext extends JobStepContext {
 
     IntrospectorJobStepContext(Packet packet) {
@@ -310,7 +279,7 @@ private boolean hasAuxiliaryImageChanged(@Nonnull V1Job job) {
 
     private boolean hasIntrospectVersionChanged(@Nonnull V1Job job) {
       return !Objects.equals(getIntrospectVersionLabelFromJob(job),
-              getIntrospectVersionLabelFromJob(getJobModel()));
+            getIntrospectVersionLabelFromJob(getJobModel()));
     }
 
     String getImageFromJob(V1Job job) {
@@ -327,21 +296,21 @@ Stream<String> getAuxiliaryImagesFromJob(V1Job job) {
 
     Optional<V1PodSpec> getPodSpecFromJob(V1Job job) {
       return Optional.ofNullable(job)
-              .map(V1Job::getSpec)
-              .map(V1JobSpec::getTemplate)
-              .map(V1PodTemplateSpec::getSpec);
+            .map(V1Job::getSpec)
+            .map(V1JobSpec::getTemplate)
+            .map(V1PodTemplateSpec::getSpec);
     }
 
     @Nullable
     String getImageFromPodSpec(@Nonnull V1PodSpec pod) {
       return getContainer(pod)
-              .map(V1Container::getImage)
-              .orElse(null);
+            .map(V1Container::getImage)
+            .orElse(null);
     }
 
     Stream<String> getAuxiliaryImagesFromPodSpec(@Nonnull V1PodSpec pod) {
       return getAuxiliaryContainers(pod)
-              .map(V1Container::getImage);
+            .map(V1Container::getImage);
     }
 
     @Nullable
@@ -355,17 +324,17 @@ List<String> getSortedJobModelPodSpecAuxiliaryImages() {
 
     Stream<String> getJobModelPodSpecAuxiliaryImages() {
       return Optional.ofNullable(getJobModelPodSpec())
-              .map(this::getAuxiliaryImagesFromPodSpec)
-              .orElse(Stream.empty());
+            .map(this::getAuxiliaryImagesFromPodSpec)
+            .orElse(Stream.empty());
     }
 
     @Nullable
     String getIntrospectVersionLabelFromJob(V1Job job) {
       return Optional.ofNullable(job)
-              .map(V1Job::getMetadata)
-              .map(V1ObjectMeta::getLabels)
-              .map(m -> m.get(INTROSPECTION_STATE_LABEL))
-              .orElse(null);
+            .map(V1Job::getMetadata)
+            .map(V1ObjectMeta::getLabels)
+            .map(m -> m.get(INTROSPECTION_STATE_LABEL))
+            .orElse(null);
     }
 
     private boolean isIntrospectionNeeded(Packet packet) {