Skip to content

Commit 3bdaf76

Browse files
committed
replace with latest from develop
1 parent 066c6c8 commit 3bdaf76

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

operator/src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,9 @@ protected V1ServiceSpec createServiceSpec() {
9797
if (isPublishNotReadyAddressesSupported()) {
9898
serviceSpec.setPublishNotReadyAddresses(Boolean.TRUE);
9999
}
100+
if (nodePort == null) {
101+
serviceSpec.clusterIP("None");
102+
}
100103
return serviceSpec;
101104
}
102105

operator/src/test/java/oracle/kubernetes/operator/helpers/ServiceHelperTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,7 @@ public void whenNodePortSpecified_createServerServiceWithNodePort() {
438438
}
439439

440440
private V1Service withNodePort(V1Service service, int nodePort) {
441-
service.getSpec().setType("NodePort");
441+
service.getSpec().type("NodePort").clusterIP(null);
442442
service
443443
.getSpec()
444444
.getPorts()
@@ -526,7 +526,7 @@ private ServerKubernetesObjects getServerKubernetesObjects() {
526526
}
527527

528528
private V1ServiceSpec createServerServiceSpec() {
529-
return createUntypedServerServiceSpec().type("ClusterIP");
529+
return createUntypedServerServiceSpec().type("ClusterIP").clusterIP("None");
530530
}
531531

532532
private V1ServiceSpec createUntypedServerServiceSpec() {

wercker.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ integration-test:
111111
cp /etc/hosts $WERCKER_PIPELINE_DIR/hosts
112112
sed -i "$ a ${OCI_K8S_WORKER0_IP} ${OCI_K8S_WORKER0_HOSTNAME}" $WERCKER_PIPELINE_DIR/hosts
113113
cp $WERCKER_PIPELINE_DIR/hosts /etc/hosts
114-
echo "DOCKER_PASSWORD $DOCKER_PASSWORD"
114+
115115
# Update KUBECONFIG for K8S cluster
116116
export K8S_NODEPORT_HOST="${OCI_K8S_WORKER0_HOSTNAME}"
117117
sed -i -e "s,%ADDRESS%,https://$OCI_K8S_MASTER_IP:443,g" $WERCKER_SOURCE_DIR/build/kube.config
@@ -210,7 +210,7 @@ integration-test-java:
210210
cp /etc/hosts $WERCKER_PIPELINE_DIR/hosts
211211
sed -i "$ a ${OCI_K8S_WORKER0_IP} ${OCI_K8S_WORKER0_HOSTNAME}" $WERCKER_PIPELINE_DIR/hosts
212212
cp $WERCKER_PIPELINE_DIR/hosts /etc/hosts
213-
213+
214214
# Update KUBECONFIG for K8S cluster
215215
export K8S_NODEPORT_HOST="${OCI_K8S_WORKER0_HOSTNAME}"
216216
sed -i -e "s,%ADDRESS%,https://$OCI_K8S_MASTER_IP:443,g" $WERCKER_SOURCE_DIR/build/kube.config
@@ -325,4 +325,4 @@ quality:
325325

326326
dev:
327327
steps:
328-
- internal/shell
328+
- internal/shell

0 commit comments

Comments
 (0)