Warning message to operator log when replicas exceeds dynamic server count

Author: CarolynRountree

operator/src/main/java/oracle/kubernetes/operator/steps/ManagedServersUpStep.java

@@ -60,9 +60,22 @@ void addServerIfNeeded(@Nonnull WlsServerConfig serverConfig, WlsClusterConfig c
         servers.add(serverName);
         addStartupInfo(new ServerStartupInfo(serverConfig, clusterName, server));
         addToCluster(clusterName);
+      } else {
+        logIfReplicaExceeds(clusterConfig);
       }
     }
 
+    boolean exceedsMaxConfiguredClusterSize(WlsClusterConfig clusterConfig) {
+      if (clusterConfig != null) {
+        String clusterName = clusterConfig.getClusterName();
+        int configClusterSize = clusterConfig.getMaxDynamicClusterSize();
+        return clusterConfig.hasDynamicServers()
+            && getReplicaCount(clusterName) == configClusterSize
+            && domain.getReplicaCount(clusterName) > configClusterSize;
+      }
+      return false;
+    }
+
     private Step createNextStep(Step next) {
       if (servers.isEmpty()) return next;
       else return new ManagedServerUpIteratorStep(getStartupInfos(), next);
@@ -84,6 +97,17 @@ private void addToCluster(String clusterName) {
     private Integer getReplicaCount(String clusterName) {
       return Optional.ofNullable(replicas.get(clusterName)).orElse(0);
     }
+
+    private void logIfReplicaExceeds(WlsClusterConfig clusterConfig) {
+      if (exceedsMaxConfiguredClusterSize(clusterConfig)) {
+        String clusterName = clusterConfig.getClusterName();
+        LOGGER.warning(
+            "******* The replica count {1} exceeds the configured maximum dynamic cluster size {2} for cluster {0}",
+            clusterName,
+            domain.getReplicaCount(clusterName),
+            clusterConfig.getMaxDynamicClusterSize());
+      }
+    }
   }
 
   public ManagedServersUpStep(Step next) {