Skip to content

Commit 44260a2

Browse files
authored
Merge pull request #515 from oracle/refine_monitoring
Clean map in test, show returned map on failure
2 parents c5d0f9d + 73834cc commit 44260a2

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

operator/src/main/java/oracle/kubernetes/operator/helpers/ServerKubernetesObjectsManager.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@ public class ServerKubernetesObjectsManager {
1414

1515
private ServerKubernetesObjectsManager() {}
1616

17+
static void clear() {
18+
serverMap.clear();
19+
}
20+
1721
static ServerKubernetesObjects getOrCreate(DomainPresenceInfo info, String serverName) {
1822
return getOrCreate(info, info.getDomain().getSpec().getDomainUID(), serverName);
1923
}

operator/src/test/java/oracle/kubernetes/operator/helpers/ServerKubernetesObjectsLookupTest.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,9 @@ protected void failed(Throwable e, Description description) {
4343
Memento serverMap =
4444
StaticStubSupport.preserve(ServerKubernetesObjectsManager.class, "serverMap");
4545
Map<String, ServerKubernetesObjects> map = serverMap.getOriginalValue();
46-
System.out.println(" " + map);
46+
System.out.println(" internal: " + map);
47+
System.out.println(
48+
" returned: " + ServerKubernetesObjectsManager.getServerKubernetesObjects());
4749
} catch (NoSuchFieldException ignored) {
4850
}
4951
}
@@ -58,11 +60,12 @@ public void setUp() throws Exception {
5860
mementos.add(
5961
StaticStubSupport.install(
6062
ServerKubernetesObjectsManager.class, "serverMap", new ConcurrentHashMap<>()));
63+
ServerKubernetesObjectsManager.clear();
6164
DomainPresenceMonitor.clear();
6265
}
6366

6467
@After
65-
public void tearDown() throws Exception {
68+
public void tearDown() {
6669
for (Memento memento : mementos) memento.revert();
6770
}
6871

0 commit comments

Comments
 (0)