And more

Author: rjeberhard

kubernetes/src/test/java/oracle/kubernetes/operator/utils/ParsedTraefikSecurityYaml.java

@@ -11,7 +11,7 @@
 
 /**
  * Parses a generated
- * weblogic-domain-traefik-security-inputs.LegalNames.toDNS1123LegalName(getClusterName()).yaml file
+ * weblogic-domain-traefik-security-inputs.LegalNames.toDns1123LegalName(getClusterName()).yaml file
  * into a set of typed k8s java objects
  */
 public class ParsedTraefikSecurityYaml extends ParsedKubernetesYaml {
@@ -45,6 +45,6 @@ private String getTraefikScope() {
   }
 
   private String getClusterScope() {
-    return inputs.getDomainUID() + "-" + LegalNames.toDNS1123LegalName(inputs.getClusterName());
+    return inputs.getDomainUID() + "-" + LegalNames.toDns1123LegalName(inputs.getClusterName());
   }
 }

kubernetes/src/test/java/oracle/kubernetes/operator/utils/ParsedTraefikYaml.java

@@ -13,7 +13,7 @@
 
 /**
  * Parses a generated
- * weblogic-domain-traefik-inputs.LegalNames.toDNS1123LegalName(getClusterName()).yaml file into a
+ * weblogic-domain-traefik-inputs.LegalNames.toDns1123LegalName(getClusterName()).yaml file into a
  * set of typed k8s java objects
  */
 public class ParsedTraefikYaml extends ParsedKubernetesYaml {
@@ -59,6 +59,6 @@ private String getTraefikScope() {
   }
 
   private String getClusterScope() {
-    return inputs.getDomainUID() + "-" + LegalNames.toDNS1123LegalName(inputs.getClusterName());
+    return inputs.getDomainUID() + "-" + LegalNames.toDns1123LegalName(inputs.getClusterName());
   }
 }

operator/src/main/java/oracle/kubernetes/operator/DomainProcessorDelegate.java

@@ -37,7 +37,7 @@ public interface DomainProcessorDelegate {
   boolean isNamespaceRunning(String namespace);
 
   /**
-   * Returns the version of the Kubernetes environment in which the operator is running
+   * Returns the version of the Kubernetes environment in which the operator is running.
    *
    * @return an object that represents the Kubernetes version
    */
@@ -51,7 +51,7 @@ public interface DomainProcessorDelegate {
   FiberGate createFiberGate();
 
   /**
-   * Runs a chain of steps
+   * Runs a chain of steps.
    *
    * @param firstStep the first step to run
    */

operator/src/main/java/oracle/kubernetes/operator/DomainProcessorImpl.java

@@ -180,7 +180,7 @@ private V1ObjectMeta getMetadata(V1Pod pod) {
 
   public void dispatchServiceWatch(Watch.Response<V1Service> item) {
     V1Service service = item.object;
-    String domainUid = ServiceHelper.getServiceDomainUID(service);
+    String domainUid = ServiceHelper.getServiceDomainUid(service);
     if (domainUid == null) return;
 
     DomainPresenceInfo info =

operator/src/main/java/oracle/kubernetes/operator/Main.java

@@ -598,7 +598,7 @@ public NextAction onSuccess(Packet packet, CallResponse<V1ServiceList> callRespo
 
       if (result != null) {
         for (V1Service service : result.getItems()) {
-          String domainUid = ServiceHelper.getServiceDomainUID(service);
+          String domainUid = ServiceHelper.getServiceDomainUid(service);
           if (domainUid != null) {
             DomainPresenceInfo info =
                 dpis.computeIfAbsent(domainUid, k -> new DomainPresenceInfo(ns, domainUid));
@@ -671,7 +671,7 @@ public NextAction onSuccess(Packet packet, CallResponse<V1PodList> callResponse)
 
       if (result != null) {
         for (V1Pod pod : result.getItems()) {
-          String domainUid = PodHelper.getPodDomainUID(pod);
+          String domainUid = PodHelper.getPodDomainUid(pod);
           String serverName = PodHelper.getPodServerName(pod);
           if (domainUid != null && serverName != null) {
             DomainPresenceInfo info =

operator/src/main/java/oracle/kubernetes/operator/OperatorReady.java

@@ -7,7 +7,9 @@
 import java.io.File;
 import java.io.IOException;
 
-/** This task creates the "readiness" indicator so that Kubernetes knows the Operator is ready */
+/**
+ * This task creates the "readiness" indicator so that Kubernetes knows the Operator is ready.
+ */
 public class OperatorReady {
 
   private static final File readinessFile = new File("/operator/.ready");

operator/src/main/java/oracle/kubernetes/operator/ServerStatusReader.java

@@ -48,7 +48,8 @@ public class ServerStatusReader {
   private static KubernetesExecFactory EXEC_FACTORY = new KubernetesExecFactoryImpl();
   private static Function<Step, Step> STEP_FACTORY = ReadHealthStep::createReadHealthStep;
 
-  private ServerStatusReader() {}
+  private ServerStatusReader() {
+  }
 
   static Step createDomainStatusReaderStep(
       DomainPresenceInfo info, long timeoutSeconds, Step next) {

operator/src/main/java/oracle/kubernetes/operator/Watcher.java

@@ -201,7 +201,7 @@ private void handleErrorResponse(Watch.Response<T> item) {
       // The kubernetes client parsing logic can mistakenly parse a status as a type
       // with similar fields, such as V1ConfigMap. In this case, the actual status is
       // not available to our layer, so respond defensively by resetting resource version.
-      resourceVersion = 0l;
+      resourceVersion = 0L;
     } else if (status.getCode() == HTTP_GONE) {
       resourceVersion = computeNextResourceVersionFromMessage(status);
     }
@@ -221,7 +221,7 @@ private long computeNextResourceVersionFromMessage(V1Status status) {
         }
       }
     }
-    return 0l;
+    return 0L;
   }
 
   /**

operator/src/main/java/oracle/kubernetes/operator/builders/WatchBuilder.java

@@ -47,7 +47,8 @@ <T> WatchI<T> createWatch(
         throws ApiException;
   }
 
-  public WatchBuilder() {}
+  public WatchBuilder() {
+  }
 
   private static Type getType(Class<?> responseBodyType) {
     return new ParameterizedType() {

operator/src/main/java/oracle/kubernetes/operator/helpers/ConflictRetry.java

@@ -16,7 +16,7 @@ public interface ConflictRetry<T> {
 
   /**
    * @return The latest version of the kubernetes object for passing to the kubernetes API, or null
-   *     if the API should not be retried
+   *     if the API should not be retried.
    */
   T getUpdatedObject();
 }