Skip to content

Commit 5659a6c

Browse files
committed
no longer reset NodeManagerMBean listenAddress in server shutdown script
1 parent 1c3a149 commit 5659a6c

File tree

2 files changed

+4
-40
lines changed

2 files changed

+4
-40
lines changed

src/main/java/oracle/kubernetes/operator/helpers/ConfigMapHelper.java

Lines changed: 4 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ public class ConfigMapHelper {
215215
" print 'Updating listen address of machine %s' % machineName\n" +
216216
" try:\n" +
217217
" edit()\n" +
218-
" startEdit(60000, 120000, 'true')\n" +
218+
" startEdit(120000, 120000, 'true')\n" +
219219
" cd('/')\n" +
220220
" machine=cmo.lookupMachine(machineName)\n" +
221221
" print 'Machine is %s' % machine\n" +
@@ -227,6 +227,7 @@ public class ConfigMapHelper {
227227
" print 'Updated listen address of machine %s to %s' % (machineName, service_name)\n" +
228228
" except:\n" +
229229
" cancelEdit('y')\n" +
230+
" disconnect()\n" +
230231
"\n" +
231232
"# Connect to nodemanager and start server\n" +
232233
"try:\n" +
@@ -244,12 +245,7 @@ public class ConfigMapHelper {
244245
"\n" +
245246
"echo \"Stop the server\"\n" +
246247
"\n" +
247-
"admin_server_t3_url=\n" +
248-
"if [ -n \"$4\" ]; then\n" +
249-
" admin_server_t3_url=t3://$1-$4:$5\n" +
250-
"fi\n" +
251-
"\n" +
252-
"wlst.sh -skipWLSModuleScanning /weblogic-operator/scripts/stop-server.py $1 $2 $3 $admin_server_t3_url\n" +
248+
"wlst.sh -skipWLSModuleScanning /weblogic-operator/scripts/stop-server.py $1 $2 $3\n" +
253249
"\n" +
254250
"# Return status of 2 means failed to stop a server through the NodeManager.\n" +
255251
"# Look to see if there is a server process that can be killed.\n" +
@@ -280,36 +276,6 @@ public class ConfigMapHelper {
280276
"domain_uid = sys.argv[1]\n" +
281277
"server_name = sys.argv[2]\n" +
282278
"domain_name = sys.argv[3]\n" +
283-
"if (len(sys.argv) == 5):\n" +
284-
" admin_server_url = sys.argv[4]\n" +
285-
"else:\n" +
286-
" admin_server_url = None\n" +
287-
"\n" +
288-
"print 'admin_server_url is %s' % admin_server_url\n" +
289-
"\n" +
290-
"# Update node manager listen address to None\n" +
291-
"if admin_server_url is not None:\n" +
292-
" connect(admin_username, admin_password, admin_server_url)\n" +
293-
" serverConfig()\n" +
294-
" server=cmo.lookupServer(server_name)\n" +
295-
" machineName=server.getMachine().getName()\n" +
296-
" print 'Name of machine assigned to server %s is %s' % (server_name, machineName)\n" +
297-
"\n" +
298-
" if machineName is not None:\n" +
299-
" print 'Updating listen address of machine %s' % machineName\n" +
300-
" try:\n" +
301-
" edit()\n" +
302-
" startEdit(60000, 120000, 'true')\n" +
303-
" cd('/')\n" +
304-
" machine=cmo.lookupMachine(machineName)\n" +
305-
" print 'Machine is %s' % machine\n" +
306-
" nm=machine.getNodeManager()\n" +
307-
" nm.setListenAddress(None)\n" +
308-
" save()\n" +
309-
" activate()\n" +
310-
" print 'Updated listen address of machine %s to None' % machineName\n" +
311-
" except:\n" +
312-
" cancelEdit('y')\n" +
313279
"\n" +
314280
"service_name = domain_uid + \"-\" + server_name\n" +
315281
"domain_path='/shared/domain/%s' % domain_name\n" +
@@ -323,7 +289,7 @@ public class ConfigMapHelper {
323289
"\n" +
324290
"# Kill the server\n" +
325291
"try:\n" +
326-
" nmKill('$2')\n" +
292+
" nmKill(server_name)\n" +
327293
"except:\n" +
328294
" print('Connected to the NodeManager, but failed to stop the server')\n" +
329295
" exit(exitcode=2)\n" +

src/main/java/oracle/kubernetes/operator/helpers/PodHelper.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -544,8 +544,6 @@ public NextAction apply(Packet packet) {
544544
exec.addCommandItem(weblogicDomainUID);
545545
exec.addCommandItem(weblogicServerName);
546546
exec.addCommandItem(weblogicDomainName);
547-
exec.addCommandItem(spec.getAsName());
548-
exec.addCommandItem(String.valueOf(spec.getAsPort()));
549547
preStop.setExec(exec);
550548
lifecycle.setPreStop(preStop);
551549
container.setLifecycle(lifecycle);

0 commit comments

Comments
 (0)