Skip to content

Commit 5e3f232

Browse files
committed
Revert "Suppress socket read timeout for watches"
This reverts commit 2e2c9f8.
1 parent ac44cf6 commit 5e3f232

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

operator/src/main/java/oracle/kubernetes/operator/builders/WatchBuilder.java

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ private class ListNamespacedServiceCall implements BiFunction<ApiClient, CallPar
9191

9292
@Override
9393
public Call apply(ApiClient client, CallParams callParams) {
94-
setReadTimeout(client);
94+
// Ensure that client doesn't time out before call or watch
95+
client.getHttpClient().setReadTimeout(callParams.getTimeoutSeconds(), TimeUnit.SECONDS);
9596

9697
try {
9798
return new CoreV1Api(client)
@@ -135,7 +136,8 @@ private class ListPodCall implements BiFunction<ApiClient, CallParams, Call> {
135136

136137
@Override
137138
public Call apply(ApiClient client, CallParams callParams) {
138-
setReadTimeout(client);
139+
// Ensure that client doesn't time out before call or watch
140+
client.getHttpClient().setReadTimeout(callParams.getTimeoutSeconds(), TimeUnit.SECONDS);
139141

140142
try {
141143
return new CoreV1Api(client)
@@ -179,7 +181,8 @@ private class ListJobCall implements BiFunction<ApiClient, CallParams, Call> {
179181

180182
@Override
181183
public Call apply(ApiClient client, CallParams callParams) {
182-
setReadTimeout(client);
184+
// Ensure that client doesn't time out before call or watch
185+
client.getHttpClient().setReadTimeout(callParams.getTimeoutSeconds(), TimeUnit.SECONDS);
183186

184187
try {
185188
return new BatchV1Api(client)
@@ -223,7 +226,8 @@ private class ListEventCall implements BiFunction<ApiClient, CallParams, Call> {
223226

224227
@Override
225228
public Call apply(ApiClient client, CallParams callParams) {
226-
setReadTimeout(client);
229+
// Ensure that client doesn't time out before call or watch
230+
client.getHttpClient().setReadTimeout(callParams.getTimeoutSeconds(), TimeUnit.SECONDS);
227231

228232
try {
229233
return new CoreV1Api(client)
@@ -258,11 +262,6 @@ public WatchI<Domain> createDomainWatch(String namespace) throws ApiException {
258262
ClientPool.getInstance(), callParams, Domain.class, new ListDomainsCall(namespace));
259263
}
260264

261-
private static void setReadTimeout(ApiClient client) {
262-
// Ensure that client doesn't time out before call or watch
263-
client.getHttpClient().setReadTimeout(0, TimeUnit.SECONDS);
264-
}
265-
266265
private class ListDomainsCall implements BiFunction<ApiClient, CallParams, Call> {
267266
private String namespace;
268267

@@ -272,7 +271,8 @@ private class ListDomainsCall implements BiFunction<ApiClient, CallParams, Call>
272271

273272
@Override
274273
public Call apply(ApiClient client, CallParams callParams) {
275-
setReadTimeout(client);
274+
// Ensure that client doesn't time out before call or watch
275+
client.getHttpClient().setReadTimeout(callParams.getTimeoutSeconds(), TimeUnit.SECONDS);
276276

277277
try {
278278
return new WeblogicApi(client)
@@ -319,7 +319,8 @@ private class ListNamespacedConfigMapCall implements BiFunction<ApiClient, CallP
319319

320320
@Override
321321
public Call apply(ApiClient client, CallParams callParams) {
322-
setReadTimeout(client);
322+
// Ensure that client doesn't time out before call or watch
323+
client.getHttpClient().setReadTimeout(callParams.getTimeoutSeconds(), TimeUnit.SECONDS);
323324

324325
try {
325326
return new CoreV1Api(client)

operator/src/main/java/oracle/kubernetes/operator/calls/AsyncRequestStep.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ public NextAction apply(Packet packet) {
110110

111111
AtomicBoolean didResume = new AtomicBoolean(false);
112112
ApiClient client = helper.take();
113-
client.getHttpClient().setReadTimeout(timeoutSeconds, TimeUnit.SECONDS);
114113
return doSuspend(
115114
(fiber) -> {
116115
ApiCallback<T> callback =

0 commit comments

Comments
 (0)