Improve test readability

Author: russgold

operator/src/test/java/oracle/kubernetes/operator/helpers/AsyncCallTestSupport.java

@@ -106,7 +106,7 @@ private String toString(RequestParams requestParams, CallParams callParams) {
   /**
    * Throws an exception if any of the canned responses were not used.
    */
-  public void verify() {
+  public void verifyAllDefinedResponsesInvoked() {
     List<CannedResponse> unusedResponses = new ArrayList<>();
     for (CannedResponse cannedResponse : cannedResponses.keySet())
       if (!cannedResponses.get(cannedResponse)) unusedResponses.add(cannedResponse);

operator/src/test/java/oracle/kubernetes/operator/steps/DeleteIngressListStepTest.java

@@ -2,6 +2,7 @@
 
 import java.net.HttpURLConnection;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collection;
 import java.util.List;
 
@@ -41,23 +42,23 @@ public void tearDown() throws Exception {
 
   @Test
   public void whenCollectionEmpty_makeNoCalls() throws Exception {
-    runStep();
+    runDeleteStep();
   }
 
-  private void runStep() {
-    testSupport.runStep(new DeleteIngressListStep(ingresses, terminalStep));
+  private void runDeleteStep(V1beta1Ingress... ingresses) {
+    this.ingresses.addAll(Arrays.asList(ingresses));
+    testSupport.runStep(new DeleteIngressListStep(this.ingresses, terminalStep));
   }
 
   @Test
   public void whenCollectionContainsItems_invokeDeleteCalls() throws Exception {
     defineResponse("namespace1", "name1").returning(new V1Status());
     defineResponse("namespace2", "name2").returning(new V1Status());
-    ingresses.add(new V1beta1Ingress().metadata(new V1ObjectMeta().namespace("namespace1").name("name1")));
-    ingresses.add(new V1beta1Ingress().metadata(new V1ObjectMeta().namespace("namespace2").name("name2")));
 
-    runStep();
+    runDeleteStep(new V1beta1Ingress().metadata(new V1ObjectMeta().namespace("namespace1").name("name1")),
+                  new V1beta1Ingress().metadata(new V1ObjectMeta().namespace("namespace2").name("name2")));
 
-    testSupport.verify();
+    testSupport.verifyAllDefinedResponsesInvoked();
   }
 
   @SuppressWarnings("unchecked")
@@ -68,18 +69,16 @@ private <T> AsyncCallTestSupport.CannedResponse<T> defineResponse(String namespa
   @Test
   public void onFailureResponse_reportError() throws Exception {
     defineResponse("namespace1", "name1").failingWithStatus(HttpURLConnection.HTTP_FORBIDDEN);
-    ingresses.add(new V1beta1Ingress().metadata(new V1ObjectMeta().namespace("namespace1").name("name1")));
 
-    runStep();
+    runDeleteStep(new V1beta1Ingress().metadata(new V1ObjectMeta().namespace("namespace1").name("name1")));
 
     testSupport.verifyCompletionThrowable(ApiException.class);
   }
 
   @Test
   public void onNotFoundResponse_dontReportError() throws Exception {
     defineResponse("namespace1", "name1").failingWithStatus(HttpURLConnection.HTTP_NOT_FOUND);
-    ingresses.add(new V1beta1Ingress().metadata(new V1ObjectMeta().namespace("namespace1").name("name1")));
 
-    runStep();
+    runDeleteStep(new V1beta1Ingress().metadata(new V1ObjectMeta().namespace("namespace1").name("name1")));
   }
 }