Removed or replaced System.out.println debug statements with LOGGER

Author: lennyphan

operator/src/main/java/oracle/kubernetes/operator/DomainProcessorImpl.java

@@ -920,9 +920,6 @@ private static class ReadSituConfigMapStep extends ResponseStep<V1ConfigMap> {
 
     @Override
     public NextAction onFailure(Packet packet, CallResponse<V1ConfigMap> callResponse) {
-      System.out.println(
-          "ReadSituConfigMapStep.onFailure callResponse.getStatusCode: "
-              + callResponse.getStatusCode());
       return callResponse.getStatusCode() == CallBuilder.NOT_FOUND
           ? onSuccess(packet, callResponse)
           : super.onFailure(packet, callResponse);
@@ -931,12 +928,10 @@ public NextAction onFailure(Packet packet, CallResponse<V1ConfigMap> callRespons
     @Override
     public NextAction onSuccess(Packet packet, CallResponse<V1ConfigMap> callResponse) {
       V1ConfigMap result = callResponse.getResult();
-      System.out.println("ReadSituConfigMapStep.onSuccess result: " + result);
       if (result != null) {
         Map<String, String> data = result.getData();
         String topologyYaml = data.get("topology.yaml");
         if (topologyYaml != null) {
-          System.out.println("topology.yaml: " + topologyYaml);
           ConfigMapHelper.DomainTopology domainTopology =
               ConfigMapHelper.parseDomainTopologyYaml(topologyYaml);
           WlsDomainConfig wlsDomainConfig = domainTopology.getDomain();

operator/src/main/java/oracle/kubernetes/operator/helpers/ConfigMapHelper.java

@@ -266,12 +266,12 @@ public NextAction apply(Packet packet) {
       String result = (String) packet.remove(ProcessingConstants.DOMAIN_INTROSPECTOR_LOG_RESULT);
       // Parse results into separate data files
       Map<String, String> data = parseIntrospectorResult(result, domain.getDomainUID());
-      System.out.println("================");
-      System.out.println(data.toString());
-      System.out.println("================");
+      LOGGER.fine("================");
+      LOGGER.fine(data.toString());
+      LOGGER.fine("================");
       String topologyYaml = data.get("topology.yaml");
       if (topologyYaml != null) {
-        System.out.println("topology.yaml: " + topologyYaml);
+        LOGGER.fine("topology.yaml: " + topologyYaml);
         DomainTopology domainTopology = parseDomainTopologyYaml(topologyYaml);
         WlsDomainConfig wlsDomainConfig = domainTopology.getDomain();
         ScanCache.INSTANCE.registerScan(
@@ -519,7 +519,7 @@ public static DomainTopology parseDomainTopologyYaml(String topologyYaml) {
     try {
       DomainTopology domainTopology = mapper.readValue(topologyYaml, DomainTopology.class);
 
-      System.out.println(
+      LOGGER.fine(
           ReflectionToStringBuilder.toString(domainTopology, ToStringStyle.MULTI_LINE_STYLE));
 
       return domainTopology;

operator/src/main/java/oracle/kubernetes/operator/helpers/JobHelper.java

@@ -127,11 +127,9 @@ public NextAction apply(Packet packet) {
   private static boolean runIntrospector(DomainPresenceInfo info) {
     Domain dom = info.getDomain();
     Scan scan = ScanCache.INSTANCE.lookupScan(dom.getMetadata().getNamespace(), dom.getDomainUID());
-    System.out.println("++++++ JobHelper.runIntrospector scan: " + scan);
-    System.out.println(
-        "++++++ JobHelper.runIntrospector runningServersCount: " + runningServersCount(info));
-    System.out.println(
-        "++++++ JobHelper.runIntrospector creatingServers: " + creatingServers(info));
+    LOGGER.fine("runIntrospector scan: " + scan);
+    LOGGER.fine("runningServersCount: " + runningServersCount(info));
+    LOGGER.fine("creatingServers: " + creatingServers(info));
     if (scan == null || (runningServersCount(info) == 0 && creatingServers(info))) {
       return true;
     }
@@ -142,6 +140,12 @@ private static int runningServersCount(DomainPresenceInfo info) {
     return ManagedServersUpStep.getRunningServers(info).size();
   }
 
+  /**
+   * TODO: Enhance determination of when we believe we're creating WLS managed server pods
+   *
+   * @param info
+   * @return
+   */
   private static boolean creatingServers(DomainPresenceInfo info) {
     Domain dom = info.getDomain();
     DomainSpec spec = dom.getSpec();
@@ -151,11 +155,7 @@ private static boolean creatingServers(DomainPresenceInfo info) {
     // Are we starting a cluster?
     for (Cluster cluster : clusters.values()) {
       int replicaCount = cluster.getReplicas();
-      System.out.println(
-          "+++++++ JobHelper.creatingServers replicaCount: "
-              + replicaCount
-              + " for cluster: "
-              + cluster);
+      LOGGER.fine("creatingServers replicaCount: " + replicaCount + " for cluster: " + cluster);
       if (replicaCount > 0) {
         return true;
       }