Skip to content

Commit 6dfd67c

Browse files
committed
Rename externalRestOption property values
1 parent c6db7ac commit 6dfd67c

File tree

5 files changed

+21
-21
lines changed

5 files changed

+21
-21
lines changed

kubernetes/create-weblogic-operator-inputs.yaml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -29,45 +29,45 @@ weblogicOperatorImagePullPolicy: IfNotPresent
2929
# Options for externally exposing the operator REST https interface
3030
# (i.e. outside of the Kubernetes cluster). Valid values are:
3131
#
32-
# "none"
32+
# "NONE"
3333
# The REST interface is not exposed outside the Kubernetes cluster.
3434
#
35-
# "self-signed-cert"
35+
# "SELF_SIGNED_CERT"
3636
# The REST interface is exposed outside of the Kubernetes cluster on the
3737
# port specified by the 'externalRestHttpsPort' property.
3838
# A self-signed certificate and private key are generated for the REST interface.
3939
# The certificate's subject alternative names are specified by the 'externalSans'
4040
# property.
4141
#
42-
# "custom-cert"
42+
# "CUSTOM_CERT"
4343
# The REST interface is exposed outside of the Kubernetes cluster on the
4444
# port specified by the 'externalRestHttpsPort' property.
4545
# The customer supplied certificate and private key are used for the REST
4646
# interface. They are specified by the 'externalOperatorCert' and
4747
# 'eternalOperatorKey' properties.
48-
externalRestOption: none
48+
externalRestOption: NONE
4949

5050
# The node port that should be allocated for the external operator REST https interface.
51-
# This parameter is required if 'externalRestOption' is not 'none'.
51+
# This parameter is required if 'externalRestOption' is not 'NONE'.
5252
# Otherwise, it is ignored.
5353
externalRestHttpsPort: 31001
5454

5555
# The subject alternative names to put into the generated self-signed certificate
5656
# for the external WebLogic Operator REST https interface, for example:
5757
# DNS:myhost,DNS:localhost,IP:127.0.0.1
58-
# This parameter is required if 'externalRestOption' is 'self-signed-cert'.
58+
# This parameter is required if 'externalRestOption' is 'SELF_SIGNED_CERT'.
5959
# Otherwise, it is ignored.
6060
externalSans:
6161

6262
# The customer supplied certificate to use for the external operator REST
6363
# https interface. The value must be a string containing a base64 encoded PEM certificate.
64-
# This parameter is required if 'externalRestOption' is 'custom-cert'.
64+
# This parameter is required if 'externalRestOption' is 'CUSTOM_CERT'.
6565
# Otherwise, it is ignored.
6666
externalOperatorCert:
6767

6868
# The customer supplied private key to use for the external operator REST
6969
# https interface. The value must be a string containing a base64 encoded PEM key.
70-
# This parameter is required if 'externalRestOption' is 'custom-cert'.
70+
# This parameter is required if 'externalRestOption' is 'CUSTOM_CERT'.
7171
# Otherwise, it is ignored.
7272
externalOperatorKey:
7373

kubernetes/internal/create-weblogic-operator.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -270,9 +270,9 @@ function validateExternalRest {
270270

271271
if [ ! -z ${externalRestOption} ]; then
272272
# Validate the specified externalRestOption value and any sub options that it requires
273-
EXT_REST_OPT_NONE="none"
274-
EXT_REST_OPT_SELF_SIGNED="self-signed-cert"
275-
EXT_REST_OPT_CUSTOM="custom-cert"
273+
EXT_REST_OPT_NONE="NONE"
274+
EXT_REST_OPT_SELF_SIGNED="SELF_SIGNED_CERT"
275+
EXT_REST_OPT_CUSTOM="CUSTOM_CERT"
276276
case ${externalRestOption} in
277277
${EXT_REST_OPT_NONE})
278278
echo The WebLogic Operator REST interface will not be externally exposed

site/installation.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,9 +70,9 @@ The following parameters must be provided in the input file:
7070

7171
| Parameter | Definition | Default |
7272
| --- | --- | --- |
73-
| externalOperatorCert | A base64 encoded string containing the X.509 certificate that the operator will present to clients accessing its REST endpoints. This value is only used when `externalRestOption` is set to `custom-cert`. | |
74-
| externalOperatorKey | A base64 encoded string containing the private key **ask tom** This value is only used when externalRestOption is set to `custom-cert`. | |
75-
| externalRestOption | Which of the available REST options is desired. Allowed values: <br/>- `none` Disable the REST interface. <br/>- `self-signed-cert` The operator will use a self-signed certificate for its REST server. If this value is specified, then the `externalSans` parameter must also be set. <br/>- `custom-cert` Provide custom certificates, for example from an external certification authority. If this value is specified, then the `externalOperatorCert` and `externalOperatorKey` must also be provided. | none |
73+
| externalOperatorCert | A base64 encoded string containing the X.509 certificate that the operator will present to clients accessing its REST endpoints. This value is only used when `externalRestOption` is set to `CUSTOM_CERT`. | |
74+
| externalOperatorKey | A base64 encoded string containing the private key **ask tom** This value is only used when externalRestOption is set to `CUSTOM_CERT`. | |
75+
| externalRestOption | Which of the available REST options is desired. Allowed values: <br/>- `NONE` Disable the REST interface. <br/>- `SELF_SIGNED_CERT` The operator will use a self-signed certificate for its REST server. If this value is specified, then the `externalSans` parameter must also be set. <br/>- `CUSTOM_CERT` Provide custom certificates, for example from an external certification authority. If this value is specified, then the `externalOperatorCert` and `externalOperatorKey` must also be provided. | none |
7676
| externalSans | A comma-separated list of Subject Alternative Names that should be included in the X.509 Certificate. This list should include ... <br/>Example: `DNS:myhost,DNS:localhost,IP:127.0.0.1` | |
7777
| namespace | The Kubernetes namespace that the operator will be deployed in. It is recommended that a namespace be created for the operator rather than using the `default` namespace. | weblogic-operator |
7878
| targetNamespaces | A list of the Kubernetes namespaces that may contain WebLogic domains that the operator will manage. The operator will not take any action against a domain that is in a namespace not listed here. | default |
@@ -88,9 +88,9 @@ The following parameters must be provided in the input file:
8888

8989
The operator provides three REST certificate options:
9090

91-
* `none` will disable the REST server.
92-
* `self-signed-cert` will generate self-signed certificates.
93-
* `custom-cert` provides a mechanism to provide certificates that were created and signed by some other means.
91+
* `NONE` will disable the REST server.
92+
* `SELF_SIGNED_CERT` will generate self-signed certificates.
93+
* `CUSTOM_CERT` provides a mechanism to provide certificates that were created and signed by some other means.
9494

9595
## Decide which options to enable
9696

src/integration-tests/bash/run.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -563,7 +563,7 @@ function deploy_operator {
563563
sed -i -e "s|#weblogicOperatorImagePullSecretName:.*|weblogicOperatorImagePullSecretName: ${IMAGE_PULL_SECRET_OPERATOR}|g" $inputs
564564
fi
565565
trace 'customize the inputs yaml file to generate a self-signed cert for the external Operator REST https port'
566-
sed -i -e "s|\(externalRestOption:\).*|\1self-signed-cert|g" $inputs
566+
sed -i -e "s|\(externalRestOption:\).*|\1SELF_SIGNED_CERT|g" $inputs
567567
sed -i -e "s|\(externalSans:\).*|\1DNS:${NODEPORT_HOST}|g" $inputs
568568
trace 'customize the inputs yaml file to set the java logging level to FINER'
569569
sed -i -e "s|\(javaLoggingLevel:\).*|\1FINER|g" $inputs

src/test/java/oracle/kubernetes/operator/create/CreateOperatorInputs.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ public class CreateOperatorInputs {
2929

3030
private static final String DEFAULT_INPUTS = "kubernetes/create-weblogic-operator-inputs.yaml";
3131

32-
public static final String EXTERNAL_REST_OPTION_NONE = "none";
33-
public static final String EXTERNAL_REST_OPTION_CUSTOM_CERT = "custom-cert";
34-
public static final String EXTERNAL_REST_OPTION_SELF_SIGNED_CERT = "self-signed-cert";
32+
public static final String EXTERNAL_REST_OPTION_NONE = "NONE";
33+
public static final String EXTERNAL_REST_OPTION_CUSTOM_CERT = "CUSTOM_CERT";
34+
public static final String EXTERNAL_REST_OPTION_SELF_SIGNED_CERT = "SELF_SIGNED_CERT";
3535

3636
public static final String JAVA_LOGGING_LEVEL_SEVERE = "SEVERE";
3737
public static final String JAVA_LOGGING_LEVEL_WARNING = "WARNING";

0 commit comments

Comments
 (0)