Skip to content

Commit 6fd8ec1

Browse files
authored
Merge pull request #354 from oracle/kubernetes-client-2.0
Use kubernetes client 2.0.0
2 parents cf86c6f + d45b966 commit 6fd8ec1

File tree

3 files changed

+43
-14
lines changed

3 files changed

+43
-14
lines changed

operator/pom.xml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
44
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
6-
6+
77
<parent>
88
<groupId>oracle.kubernetes</groupId>
99
<artifactId>operator-parent</artifactId>
@@ -269,7 +269,7 @@
269269
<dependency>
270270
<groupId>io.kubernetes</groupId>
271271
<artifactId>client-java</artifactId>
272-
<version>1.0.0</version>
272+
<version>2.0.0</version>
273273
</dependency>
274274
<dependency>
275275
<groupId>com.appscode.voyager</groupId>
@@ -292,22 +292,22 @@
292292
<groupId>org.slf4j</groupId>
293293
<artifactId>slf4j-api</artifactId>
294294
<version>1.7.25</version>
295-
</dependency>
296-
295+
</dependency>
296+
297297
<!-- not included with jdk 9 -->
298298
<dependency>
299299
<groupId>javax.xml.bind</groupId>
300300
<artifactId>jaxb-api</artifactId>
301301
<version>2.3.0</version>
302302
</dependency>
303-
303+
304304
<!-- for mvn exec:java -->
305305
<dependency>
306306
<groupId>org.yaml</groupId>
307307
<artifactId>snakeyaml</artifactId>
308308
<version>1.19</version>
309309
</dependency>
310-
310+
311311
<!-- test dependencies -->
312312
<dependency>
313313
<!-- note: need to include this before junit since junit includes an obsolete version of hamcrest -->

operator/src/main/java/oracle/kubernetes/operator/helpers/CallBuilder.java

Lines changed: 34 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -802,27 +802,56 @@ public Step createServiceAsync(
802802
*
803803
* @param name Name
804804
* @param namespace Namespace
805+
* @param deleteOptions Delete options
805806
* @return Status of deletion
806807
* @throws ApiException API Exception
807808
*/
808-
public V1Status deleteService(String name, String namespace) throws ApiException {
809+
public V1Status deleteService(String name, String namespace, V1DeleteOptions deleteOptions)
810+
throws ApiException {
809811
ApiClient client = helper.take();
810812
try {
811-
return new CoreV1Api(client).deleteNamespacedService(name, namespace, pretty);
813+
return new CoreV1Api(client)
814+
.deleteNamespacedService(
815+
name,
816+
namespace,
817+
deleteOptions,
818+
pretty,
819+
gracePeriodSeconds,
820+
orphanDependents,
821+
propagationPolicy);
812822
} finally {
813823
helper.recycle(client);
814824
}
815825
}
816826

817827
private com.squareup.okhttp.Call deleteServiceAsync(
818-
ApiClient client, String name, String namespace, ApiCallback<V1Status> callback)
828+
ApiClient client,
829+
String name,
830+
String namespace,
831+
V1DeleteOptions deleteOptions,
832+
ApiCallback<V1Status> callback)
819833
throws ApiException {
820-
return new CoreV1Api(client).deleteNamespacedServiceAsync(name, namespace, pretty, callback);
834+
return new CoreV1Api(client)
835+
.deleteNamespacedServiceAsync(
836+
name,
837+
namespace,
838+
deleteOptions,
839+
pretty,
840+
gracePeriodSeconds,
841+
orphanDependents,
842+
propagationPolicy,
843+
callback);
821844
}
822845

823846
private final CallFactory<V1Status> DELETE_SERVICE =
824847
(requestParams, usage, cont, callback) ->
825-
wrap(deleteServiceAsync(usage, requestParams.name, requestParams.namespace, callback));
848+
wrap(
849+
deleteServiceAsync(
850+
usage,
851+
requestParams.name,
852+
requestParams.namespace,
853+
(V1DeleteOptions) requestParams.body,
854+
callback));
826855

827856
/**
828857
* Asynchronous step for deleting service

operator/src/test/java/oracle/kubernetes/operator/utils/KubernetesArtifactUtils.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import com.appscode.voyager.client.models.V1beta1IngressSpec;
1313
import io.kubernetes.client.custom.IntOrString;
1414
import io.kubernetes.client.custom.Quantity;
15+
import io.kubernetes.client.models.ApiregistrationV1beta1ServiceReference;
1516
import io.kubernetes.client.models.ExtensionsV1beta1Deployment;
1617
import io.kubernetes.client.models.ExtensionsV1beta1DeploymentSpec;
1718
import io.kubernetes.client.models.V1ConfigMap;
@@ -63,7 +64,6 @@
6364
import io.kubernetes.client.models.V1beta1PolicyRule;
6465
import io.kubernetes.client.models.V1beta1RoleBinding;
6566
import io.kubernetes.client.models.V1beta1RoleRef;
66-
import io.kubernetes.client.models.V1beta1ServiceReference;
6767
import io.kubernetes.client.models.V1beta1Subject;
6868
import java.util.ArrayList;
6969
import java.util.List;
@@ -174,8 +174,8 @@ public static V1beta1APIServiceSpec newAPIServiceSpec() {
174174
return new V1beta1APIServiceSpec();
175175
}
176176

177-
public static V1beta1ServiceReference newServiceReference() {
178-
return new V1beta1ServiceReference();
177+
public static ApiregistrationV1beta1ServiceReference newServiceReference() {
178+
return new ApiregistrationV1beta1ServiceReference();
179179
}
180180

181181
public static V1beta1Ingress newIngress() {

0 commit comments

Comments
 (0)