Correct data type for domainHomeInImage webhook conversion (#3890)

Author: rjeberhard

common/src/main/java/oracle/kubernetes/common/utils/SchemaConversionUtils.java

@@ -1,4 +1,4 @@
-// Copyright (c) 2022, Oracle and/or its affiliates.
+// Copyright (c) 2022, 2023, Oracle and/or its affiliates.
 // Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
 
 package oracle.kubernetes.common.utils;
@@ -430,7 +430,7 @@ private void convertDomainHomeInImageToDomainHomeSourceType(Map<String, Object>
       Object existing = domainSpec.remove("domainHomeInImage");
       if (existing != null && !domainSpec.containsKey("domainHomeSourceType")) {
         domainSpec.put("domainHomeSourceType",
-                Boolean.parseBoolean((String) existing) ? "Image" : "PersistentVolume");
+                Boolean.TRUE.equals(existing) ? "Image" : "PersistentVolume");
       }
     }
   }

common/src/test/java/oracle/kubernetes/common/utils/SchemaConversionUtilsTest.java

@@ -1,4 +1,4 @@
-// Copyright (c) 2022, Oracle and/or its affiliates.
+// Copyright (c) 2022, 2023, Oracle and/or its affiliates.
 // Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
 
 package oracle.kubernetes.common.utils;
@@ -297,7 +297,7 @@ private Map<String, Object> getDomainSpec(Map<String, Object> domainMap) {
   }
 
   private void setDomainHomeInImage(Map<String, Object> v8Domain, boolean domainHomeInImage) {
-    getDomainSpec(v8Domain).put("domainHomeInImage", String.valueOf(domainHomeInImage));
+    getDomainSpec(v8Domain).put("domainHomeInImage", domainHomeInImage);
   }
 
   private void setDomainHomeSourceType(Map<String, Object> v8Domain, String domainHomeSourceType) {