Skip to content

Commit 7bb2beb

Browse files
ddsharpeddsharpe
committed
checkstyle javadoc
1 parent b3647cb commit 7bb2beb

File tree

3 files changed

+56
-41
lines changed

3 files changed

+56
-41
lines changed

‎json-schema/pom.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333

3434
</plugins>
3535
</build>
36+
3637
<dependencies>
3738
<dependency>
3839
<groupId>io.kubernetes</groupId>
@@ -44,10 +45,12 @@
4445
<artifactId>hamcrest-junit</artifactId>
4546
<scope>test</scope>
4647
</dependency>
48+
4749
<dependency>
4850
<groupId>junit</groupId>
4951
<artifactId>junit</artifactId>
5052
<scope>test</scope>
5153
</dependency>
5254
</dependencies>
55+
5356
</project>

‎operator/src/main/java/oracle/kubernetes/operator/wlsconfig/WlsMachineConfig.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -50,31 +50,32 @@ static WlsMachineConfig create(Map<String, Object> machineConfigMap) {
5050
}
5151

5252
/**
53+
* Name of the machine that this WlsMachineConfig is created for.
5354
* @return Name of the machine that this WlsMachineConfig is created for
5455
*/
5556
public String getName() {
5657
return name;
5758
}
5859

5960
/**
60-
* @return Listen port of the node manager for the machine that this WlsMachineConfig is created
61-
* for
61+
* Listen port of the node manager for the machine that this WlsMachineConfig is created for.
62+
* @return Listen port of the node manager for the machine that this WlsMachineConfig is created for
6263
*/
6364
public Integer getNodeManagerListenPort() {
6465
return nodeManagerListenPort;
6566
}
6667

6768
/**
68-
* @return Listen address of the node manager for the machine that this WlsMachineConfig is
69-
* created for
69+
* Listen address of the node manager for the machine that this WlsMachineConfig is created for.
70+
* @return Listen address of the node manager for the machine that this WlsMachineConfig is created for
7071
*/
7172
public String getNodeManagerListenAddress() {
7273
return nodeManagerListenAddress;
7374
}
7475

7576
/**
76-
* @return Type of node manager (Plain, SSL, etc) for the machine that this WlsMachineConfig is
77-
* created for
77+
* Type of node manager (Plain, SSL, etc) for the machine that this WlsMachineConfig is created for.
78+
* @return Type of node manager (Plain, SSL, etc) for the machine that this WlsMachineConfig is created for
7879
*/
7980
public String getNodeManagerType() {
8081
return nodeManagerType;

‎pom.xml

Lines changed: 46 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,54 @@
5454
</repositories>
5555

5656
<build>
57+
<pluginManagement>
58+
<plugins>
59+
<plugin>
60+
<groupId>org.apache.maven.plugins</groupId>
61+
<artifactId>maven-checkstyle-plugin</artifactId>
62+
<version>${maven-checkstyle-plugin-version}</version>
63+
<executions>
64+
<execution>
65+
<id>checkstyle</id>
66+
<phase>test</phase>
67+
<goals>
68+
<goal>check</goal>
69+
</goals>
70+
<configuration>
71+
<consoleOutput>true</consoleOutput>
72+
<configLocation>${checkstyle.config.location}</configLocation>
73+
<suppressionsLocation>weblogic-kubernetes-operator/checkstyle/suppressions.xml</suppressionsLocation>
74+
<encoding>UTF-8</encoding>
75+
<failOnViolation>true</failOnViolation>
76+
<violationSeverity>warning</violationSeverity>
77+
</configuration>
78+
</execution>
79+
</executions>
80+
<dependencies>
81+
<dependency>
82+
<groupId>oracle.kubernetes</groupId>
83+
<artifactId>build-tools</artifactId>
84+
<version>1.0</version>
85+
</dependency>
86+
<dependency>
87+
<groupId>com.puppycrawl.tools</groupId>
88+
<artifactId>checkstyle</artifactId>
89+
<version>8.21</version>
90+
</dependency>
91+
</dependencies>
92+
</plugin>
93+
<plugin>
94+
<groupId>org.apache.maven.plugins</groupId>
95+
<artifactId>maven-enforcer-plugin</artifactId>
96+
<version>${maven-enforcer-plugin-version}</version>
97+
</plugin>
98+
</plugins>
99+
</pluginManagement>
100+
57101
<plugins>
58102
<plugin>
59103
<groupId>org.apache.maven.plugins</groupId>
60104
<artifactId>maven-enforcer-plugin</artifactId>
61-
<version>${maven-enforcer-plugin-version}</version>
62105
<executions>
63106
<execution>
64107
<id>enforce-maven</id>
@@ -127,40 +170,7 @@
127170
</execution>
128171
</executions>
129172
</plugin>
130-
<plugin>
131-
<groupId>org.apache.maven.plugins</groupId>
132-
<artifactId>maven-checkstyle-plugin</artifactId>
133-
<version>${maven-checkstyle-plugin-version}</version>
134-
<executions>
135-
<execution>
136-
<id>checkstyle</id>
137-
<phase>test</phase>
138-
<goals>
139-
<goal>check</goal>
140-
</goals>
141-
<configuration>
142-
<consoleOutput>true</consoleOutput>
143-
<configLocation>weblogic-kubernetes-operator/checkstyle/customized_google_checks.xml</configLocation>
144-
<suppressionsLocation>weblogic-kubernetes-operator/checkstyle/suppressions.xml</suppressionsLocation>
145-
<encoding>UTF-8</encoding>
146-
<failOnViolation>true</failOnViolation>
147-
<violationSeverity>warning</violationSeverity>
148-
</configuration>
149-
</execution>
150-
</executions>
151-
<dependencies>
152-
<dependency>
153-
<groupId>oracle.kubernetes</groupId>
154-
<artifactId>build-tools</artifactId>
155-
<version>1.0</version>
156-
</dependency>
157-
<dependency>
158-
<groupId>com.puppycrawl.tools</groupId>
159-
<artifactId>checkstyle</artifactId>
160-
<version>8.21</version>
161-
</dependency>
162-
</dependencies>
163-
</plugin>
173+
164174
<plugin>
165175
<groupId>org.apache.maven.plugins</groupId>
166176
<artifactId>maven-pmd-plugin</artifactId>
@@ -615,6 +625,7 @@
615625
<jacoco.itOutputDir>${project.basedir}/../target/jacoco-it</jacoco.itOutputDir>
616626
<jacoco.destFile>${project.basedir}/../target/jacoco.exec</jacoco.destFile>
617627
<jacoco.skip>false</jacoco.skip>
628+
<checkstyle.config.location>weblogic-kubernetes-operator/checkstyle/customized_google_checks.xml</checkstyle.config.location>
618629
</properties>
619630

620631
</project>

0 commit comments

Comments
 (0)