Skip to content

Commit 824913b

Browse files
committed
managed server should use admin port to reach admin server if admin port is enabled
1 parent 1c403f3 commit 824913b

File tree

4 files changed

+12
-2
lines changed

4 files changed

+12
-2
lines changed

operator/src/main/java/oracle/kubernetes/operator/helpers/PodStepContext.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,9 @@ String getAsName() {
158158
}
159159

160160
Integer getAsPort() {
161-
return domainTopology.getServerConfig(domainTopology.getAdminServerName()).getListenPort();
161+
return domainTopology
162+
.getServerConfig(domainTopology.getAdminServerName())
163+
.getLocalAdminProtocolChannelPort();
162164
}
163165

164166
boolean isLocalAdminProtocolChannelSecure() {
@@ -769,6 +771,7 @@ void overrideContainerWeblogicEnvVars(List<V1EnvVar> vars) {
769771
addEnvVar(vars, "DOMAIN_HOME", getDomainHome());
770772
addEnvVar(vars, "ADMIN_NAME", getAsName());
771773
addEnvVar(vars, "ADMIN_PORT", getAsPort().toString());
774+
addEnvVar(vars, "ADMIN_PORT_SECURE", Boolean.toString(isLocalAdminProtocolChannelSecure()));
772775
addEnvVar(vars, "SERVER_NAME", getServerName());
773776
addEnvVar(vars, "DOMAIN_UID", getDomainUID());
774777
addEnvVar(vars, "NODEMGR_HOME", NODEMGR_HOME);

operator/src/main/resources/scripts/startNodeManager.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,11 @@ EOF
244244
[ ! $? -eq 0 ] && trace "Failed to create '${wl_props_file}'." && exit 1
245245

246246
if [ ! "${ADMIN_NAME}" = "${SERVER_NAME}" ]; then
247-
echo "AdminURL=http\\://${AS_SERVICE_NAME}\\:${ADMIN_PORT}" >> ${wl_props_file}
247+
admin_protocol="http"
248+
if [ "${ADMIN_PORT_SECURE}" = "true" ]; then
249+
admin_protocol="https"
250+
fi
251+
echo "AdminURL=$admin_protocol\\://${AS_SERVICE_NAME}\\:${ADMIN_PORT}" >> ${wl_props_file}
248252
fi
249253
fi
250254

operator/src/main/resources/scripts/startServer.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ checkEnv \
174174
SERVICE_NAME \
175175
ADMIN_NAME \
176176
ADMIN_PORT \
177+
ADMIN_PORT_SECURE \
177178
SERVER_OUT_IN_POD_LOG \
178179
AS_SERVICE_NAME || exitOrLoop
179180

operator/src/test/java/oracle/kubernetes/operator/helpers/PodHelperTestBase.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -431,6 +431,7 @@ public void whenPodCreated_hasPredefinedEnvVariables() {
431431
hasEnvVar("DOMAIN_HOME", "/u01/oracle/user_projects/domains"),
432432
hasEnvVar("ADMIN_NAME", ADMIN_SERVER),
433433
hasEnvVar("ADMIN_PORT", Integer.toString(ADMIN_PORT)),
434+
hasEnvVar("ADMIN_PORT_SECURE", "false"),
434435
hasEnvVar("SERVER_NAME", getServerName()),
435436
hasEnvVar("ADMIN_USERNAME", null),
436437
hasEnvVar("ADMIN_PASSWORD", null),
@@ -920,6 +921,7 @@ V1Container createPodSpecContainer() {
920921
.addEnvItem(envItem("DOMAIN_HOME", "/u01/oracle/user_projects/domains"))
921922
.addEnvItem(envItem("ADMIN_NAME", ADMIN_SERVER))
922923
.addEnvItem(envItem("ADMIN_PORT", Integer.toString(ADMIN_PORT)))
924+
.addEnvItem(envItem("ADMIN_PORT_SECURE", "false"))
923925
.addEnvItem(envItem("SERVER_NAME", getServerName()))
924926
.addEnvItem(envItem("ADMIN_USERNAME", null))
925927
.addEnvItem(envItem("ADMIN_PASSWORD", null))

0 commit comments

Comments
 (0)