Skip to content

Commit 857034a

Browse files
committed
fix javadoc reviews
1 parent 2eb63af commit 857034a

File tree

2 files changed

+117
-90
lines changed

2 files changed

+117
-90
lines changed

integration-tests/src/test/java/oracle/kubernetes/operator/ITSitConfig.java

Lines changed: 26 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,8 @@ public class ITSitConfig extends BaseTest {
4848
* initialization of the integration test properties defined in OperatorIT.properties and setting
4949
* the resultRoot, pvRoot and projectRoot attributes.
5050
*
51-
* @throws Exception
51+
* @throws Exception when the initialization, creating directories , copying files and domain
52+
* creation fails.
5253
*/
5354
@BeforeClass
5455
public static void staticPrepare() throws Exception {
@@ -97,9 +98,9 @@ public static void staticPrepare() throws Exception {
9798
}
9899

99100
/**
100-
* Destroy domain, delete the MySql DB container and teardown
101+
* Destroy domain, delete the MySQL DB container and teardown.
101102
*
102-
* @throws Exception
103+
* @throws Exception when domain destruction or MySQL container destruction fails
103104
*/
104105
@AfterClass
105106
public static void staticUnPrepare() throws Exception {
@@ -116,9 +117,9 @@ public static void staticUnPrepare() throws Exception {
116117
* <p>The test checks the overridden config.xml attributes connect-timeout, max-message-size,
117118
* restart-max, JMXCore and ServerLifeCycle debug flags, the T3Channel public address. The
118119
* overridden are verified against the ServerConfig MBean tree. It does not verifies whether the
119-
* overridden values are applied to the runtime
120+
* overridden values are applied to the runtime.
120121
*
121-
* @throws Exception
122+
* @throws Exception when the assertion fails due to unmatched values
122123
*/
123124
@Test
124125
public void testCustomSitConfigOverridesForDomain() throws Exception {
@@ -153,7 +154,7 @@ public void testCustomSitConfigOverridesForDomain() throws Exception {
153154
* whether the overridden values are applied to the runtime except the JDBC URL which is verified
154155
* at runtime by making a connection to the MySql database and executing a DDL statement.
155156
*
156-
* @throws Exception
157+
* @throws Exception when the assertion fails due to unmatched values
157158
*/
158159
@Test
159160
public void testCustomSitConfigOverridesForJdbc() throws Exception {
@@ -179,14 +180,14 @@ public void testCustomSitConfigOverridesForJdbc() throws Exception {
179180
}
180181

181182
/**
182-
* This test covers custom resource use cases for JMS resource The JMS resource override file sets
183-
* the following Delivery Failure Parameters. Redelivery limit and Expiration policy for a
184-
* uniform-distributed-topic JMS resource
183+
* This test covers custom resource use cases for JMS resource. The JMS resource override file
184+
* sets the following Delivery Failure Parameters re delivery limit and expiration policy for a
185+
* uniform-distributed-topic JMS resource.
185186
*
186187
* <p>The overridden values are verified against the ServerConfig MBean tree. It does not verifies
187-
* whether the overridden values are applied to the runtime
188+
* whether the overridden values are applied to the runtime.
188189
*
189-
* @throws Exception
190+
* @throws Exception when the assertion fails due to unmatched values
190191
*/
191192
@Test
192193
public void testCustomSitConfigOverridesForJms() throws Exception {
@@ -211,15 +212,15 @@ public void testCustomSitConfigOverridesForJms() throws Exception {
211212

212213
/**
213214
* This test covers custom resource override use cases for diagnostics resource. It adds the
214-
* following instrumentation monitors Connector_After_Inbound Connector_Around_Outbound
215-
* Connector_Around_Tx Connector_Around_Work Connector_Before_Inbound and harvesters for
216-
* weblogic.management.runtime.JDBCServiceRuntimeMBean
217-
* weblogic.management.runtime.ServerRuntimeMBean
215+
* following instrumentation monitors. Connector_After_Inbound, Connector_Around_Outbound,
216+
* Connector_Around_Tx, Connector_Around_Work, Connector_Before_Inbound, and harvesters for
217+
* weblogic.management.runtime.JDBCServiceRuntimeMBean,
218+
* weblogic.management.runtime.ServerRuntimeMBean.
218219
*
219220
* <p>The overridden values are verified against the ServerConfig MBean tree. It does not verifies
220-
* whether the overridden values are applied to the runtime
221+
* whether the overridden values are applied to the runtime.
221222
*
222-
* @throws Exception
223+
* @throws Exception when the assertion fails due to unmatched values
223224
*/
224225
@Test
225226
public void testCustomSitConfigOverridesForWldf() throws Exception {
@@ -271,9 +272,9 @@ private static Domain createSitConfigDomain() throws Exception {
271272
}
272273

273274
/**
274-
* Destroys the domain
275+
* Destroys the domain.
275276
*
276-
* @throws Exception
277+
* @throws Exception when domain destruction fails
277278
*/
278279
private static void destroySitConfigDomain() throws Exception {
279280
if (domain != null) {
@@ -282,10 +283,10 @@ private static void destroySitConfigDomain() throws Exception {
282283
}
283284

284285
/**
285-
* copy the configuration override files to a staging area after replacing the JDBC_URL token in
286-
* jdbc-JdbcTestDataSource-0.xml
286+
* Copy the configuration override files to a staging area after replacing the JDBC_URL token in
287+
* jdbc-JdbcTestDataSource-0.xml.
287288
*
288-
* @throws IOException
289+
* @throws IOException when copying files from source location to staging area fails
289290
*/
290291
private static void copySitConfigFiles() throws IOException {
291292
String src_dir = TEST_RES_DIR + "/sitconfig/configoverrides";
@@ -310,9 +311,9 @@ private static void copySitConfigFiles() throws IOException {
310311
}
311312

312313
/**
313-
* a util method to copy MySql yaml template file replacing the NAMESPACE and DOMAINUID
314+
* A utility method to copy MySQL yaml template file replacing the NAMESPACE and DOMAINUID.
314315
*
315-
* @throws IOException
316+
* @throws IOException when copying files from source location to staging area fails
316317
*/
317318
private static void copyMySqlFile() throws IOException {
318319
Path src = Paths.get(TEST_RES_DIR + "/mysql/mysql-dbservices.ymlt");
@@ -327,7 +328,7 @@ private static void copyMySqlFile() throws IOException {
327328
}
328329

329330
/**
330-
* Verifies the test run result doesn't contain any errors and exit status is 0
331+
* Verifies the test run result doesn't contain any errors and exit status is 0.
331332
*
332333
* @param result - ExecResult object containing result of the test run
333334
*/

0 commit comments

Comments
 (0)