Skip to content

Commit 88c9734

Browse files
committed
fixed previous merge of create-weblogic-domain.sh. fixed unit test in CreateDomainGeneratedFilesBaseTest to reflect changes for moving files to configMap
1 parent f6524db commit 88c9734

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

kubernetes/internal/create-weblogic-domain.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -414,6 +414,7 @@ function createYamlFiles {
414414
sed -i -e "s:%T3_CHANNEL_PORT%:${t3ChannelPort}:g" ${jobOutput}
415415
sed -i -e "s:%T3_PUBLIC_ADDRESS%:${t3PublicAddress}:g" ${jobOutput}
416416
sed -i -e "s:%CLUSTER_NAME%:${clusterName}:g" ${jobOutput}
417+
sed -i -e "s:%CLUSTER_TYPE%:${clusterType}:g" ${jobOutput}
417418

418419
# Generate the yaml to create the domain custom resource
419420
echo Generating ${dcrOutput}
@@ -440,6 +441,7 @@ function createYamlFiles {
440441
sed -i -e "s:%INITIAL_MANAGED_SERVER_REPLICAS%:${initialManagedServerReplicas}:g" ${dcrOutput}
441442
sed -i -e "s:%EXPOSE_T3_CHANNEL_PREFIX%:${exposeAdminT3ChannelPrefix}:g" ${dcrOutput}
442443
sed -i -e "s:%CLUSTER_NAME%:${clusterName}:g" ${dcrOutput}
444+
sed -i -e "s:%CLUSTER_TYPE%:${clusterType}:g" ${dcrOutput}
443445
sed -i -e "s:%EXPOSE_ADMIN_PORT_PREFIX%:${exposeAdminNodePortPrefix}:g" ${dcrOutput}
444446
sed -i -e "s:%ADMIN_NODE_PORT%:${adminNodePort}:g" ${dcrOutput}
445447
sed -i -e "s:%JAVA_OPTIONS%:${javaOptions}:g" ${dcrOutput}

src/test/java/oracle/kubernetes/operator/create/CreateDomainGeneratedFilesBaseTest.java

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ protected V1Job getExpectedCreateWeblogicDomainJob() {
189189
.secretName(getInputs().getWeblogicCredentialsSecretName()))))));
190190
}
191191

192-
//@Test TODO- INVESTIGATE!
192+
@Test
193193
public void generatesCorrect_createWeblogicDomainConfigMap() throws Exception {
194194
// The config map contains several properties that contain shell and wlst scripts
195195
// that we don't want to duplicate in the test. However, part of their text
@@ -261,27 +261,24 @@ protected void assertThatActualReadDomainSecretPyIsCorrect(String actualReadDoma
261261
protected void assertThatActualCreateDomainScriptShIsCorrect(String actualCreateDomainScriptSh) {
262262
/*
263263
create-domain-script.sh: |-
264+
#!/bin/bash
265+
#
266+
267+
# Include common utility functions
268+
source /u01/weblogic/utility.sh
269+
264270
export DOMAIN_HOME=${SHARED_PATH}/domain/%DOMAIN_NAME%
265-
echo "AdminURL=http\://$3\:%ADMIN_PORT%" >> ${startProp}
266-
nmConnect(admin_username, admin_password, '$1-$2', '5556', '%DOMAIN_NAME%', '${DOMAIN_HOME}', 'plain')
267-
nmConnect(admin_username, admin_password, '$1-$2', '5556', '%DOMAIN_NAME%', '${DOMAIN_HOME}', 'plain')
268-
createNodeMgrHome %DOMAIN_UID% %ADMIN_SERVER_NAME%
269-
createStartScript %DOMAIN_UID% %ADMIN_SERVER_NAME%
270-
createStopScript %DOMAIN_UID% %ADMIN_SERVER_NAME%
271-
while [ $index -lt %NUMBER_OF_MS% ]
272-
createNodeMgrHome %DOMAIN_UID% %MANAGED_SERVER_NAME_BASE%${index} %DOMAIN_UID%-%ADMIN_SERVER_NAME%
273-
createStartScript %DOMAIN_UID% %MANAGED_SERVER_NAME_BASE%${index}
274-
createStopScript %DOMAIN_UID% %MANAGED_SERVER_NAME_BASE%${index}
271+
272+
# Create the domain
273+
wlst.sh -skipWLSModuleScanning /u01/weblogic/create-domain.py
274+
275+
echo "Successfully Completed"
275276
*/
276277
assertThat(
277278
actualCreateDomainScriptSh,
278279
containsRegexps(
279-
getInputs().getDomainUID(),
280280
getInputs().getDomainName(),
281-
getInputs().getAdminServerName(),
282-
getInputs().getManagedServerNameBase(),
283-
getInputs().getDomainUID() + "-" + getInputs().getAdminServerName(),
284-
"index -lt " + getInputs().getConfiguredManagedServerCount()));
281+
"wlst.sh -skipWLSModuleScanning /u01/weblogic/create-domain.py"));
285282
}
286283

287284
protected void assertThatActualCreateDomainPyIsCorrect(String actualCreateDomainPy) {
@@ -324,6 +321,7 @@ protected void assertThatActualCreateDomainPyIsCorrect(String actualCreateDomain
324321
containsRegexps(
325322
getInputs().getDomainName(),
326323
getInputs().getClusterName(),
324+
getInputs().getClusterType(),
327325
getInputs().getAdminServerName(),
328326
getInputs().getManagedServerNameBase(),
329327
getInputs().getDomainUID() + "-" + getInputs().getAdminServerName(),

0 commit comments

Comments
 (0)