No need to expose nm port for admin server. update PodHelper unit tests

Author: alai8

src/main/java/oracle/kubernetes/operator/helpers/PodHelper.java

@@ -223,15 +223,8 @@ protected V1Pod computeAdminPodConfig(Packet packet) {
       V1ContainerPort containerPort = new V1ContainerPort();
       containerPort.setContainerPort(spec.getAsPort());
       containerPort.setProtocol("TCP");
-      containerPort.setName("weblogic");
       container.addPortsItem(containerPort);
 
-      V1ContainerPort nmPort = new V1ContainerPort();
-      nmPort.setContainerPort(5556);
-      nmPort.setProtocol("TCP");
-      nmPort.setName("node-manager");
-      container.addPortsItem(nmPort);
-
       V1Lifecycle lifecycle = new V1Lifecycle();
       V1Handler preStopHandler = new V1Handler();
       V1ExecAction lifecycleExecAction = new V1ExecAction();

src/test/java/oracle/kubernetes/operator/create/PodHelperConfigTest.java

@@ -5,6 +5,7 @@
 
 import java.util.List;
 
+import io.kubernetes.client.models.V1ContainerPort;
 import io.kubernetes.client.models.V1PersistentVolumeClaimList;
 import io.kubernetes.client.models.V1Pod;
 import static oracle.kubernetes.operator.KubernetesConstants.*;
@@ -263,7 +264,7 @@ public V1Pod computeManagedPodConfig(Domain domain, V1PersistentVolumeClaimList
       packet.put(
         ProcessingConstants.SERVER_SCAN,
         // no listen address, no network access points since PodHelper doesn't use them:
-        new WlsServerConfig(MANAGED_SERVER_NAME, MANAGED_SERVER_PORT, null, null));
+        new WlsServerConfig(MANAGED_SERVER_NAME, MANAGED_SERVER_PORT, null, null, false, null, null));
       packet.put(
         ProcessingConstants.CLUSTER_SCAN,
         // don't attach WlsServerConfigs for the managed server to the WlsClusterConfig
@@ -366,6 +367,9 @@ private V1Pod getDesiredManagedServerPodConfigForDefaults(String image, String i
         .value(MANAGED_OPTION2_VALUE));
     pod.getMetadata()
       .putLabelsItem("weblogic.clusterName", CLUSTER_NAME);
+    pod.getSpec().getContainers().get(0).addCommandItem(ADMIN_SERVER_NAME).addCommandItem(String.valueOf(ADMIN_SERVER_PORT));
+    pod.getSpec().getContainers().get(0).getPorts().get(0).setName("weblogic");
+    pod.getSpec().getContainers().get(0).addPortsItem(new V1ContainerPort().protocol("TCP").containerPort(5556).name("node-manager"));
     return pod;
   }
 
@@ -397,11 +401,18 @@ private V1Pod getDesiredBaseServerPodConfigForDefaults(String image, String imag
             .name("weblogic-server")
             .image(image)
             .imagePullPolicy(imagePullPolicy)
-            .addCommandItem("/shared/domain/" + DOMAIN_NAME + "/servers/" + serverName + "/nodemgr_home/startServer.sh")
+            .addCommandItem("/weblogic-operator/scripts/startServer.sh")
+            .addCommandItem(DOMAIN_UID)
+            .addCommandItem(serverName)
+            .addCommandItem(DOMAIN_NAME)
             .lifecycle(newLifecycle()
               .preStop(newHandler()
                 .exec(newExecAction()
-                  .addCommandItem("/shared/domain/" + DOMAIN_NAME + "/servers/" + serverName + "/nodemgr_home/stopServer.sh"))))
+                  .addCommandItem("/weblogic-operator/scripts/stopServer.sh")
+                  .addCommandItem(DOMAIN_UID)
+                  .addCommandItem(serverName)
+                  .addCommandItem(DOMAIN_NAME)
+                )))
             .livenessProbe(newProbe()
               .initialDelaySeconds(10)
               .periodSeconds(10)