Skip to content

Commit 8c35886

Browse files
committed
Resolve failure in introspection following a console edit
1 parent eb12fb5 commit 8c35886

File tree

1 file changed

+30
-12
lines changed

1 file changed

+30
-12
lines changed

operator/src/main/resources/scripts/introspectDomain.py

Lines changed: 30 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2018, Oracle Corporation and/or its affiliates. All rights reserved.
1+
# Copyright 2018, 2019, Oracle Corporation and/or its affiliates. All rights reserved.
22
# Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
33
#
44
# ------------
@@ -311,6 +311,13 @@ def getDynamicServersWA(self,cluster):
311311
ret = None
312312
return ret
313313

314+
def getSSLWA(self,server):
315+
try:
316+
ret = server.getSSL()
317+
except:
318+
trace("Ignoring getSSL() exception, this is expected.")
319+
ret = None
320+
return ret
314321

315322
def validateAdminServer(self):
316323
adminServerName = self.env.getDomain().getAdminServerName()
@@ -325,7 +332,7 @@ def validateAdminServer(self):
325332
addError("The admin server '" + adminServerName + "' does not exist.")
326333
return
327334
cluster = adminServer.getCluster()
328-
if cluster != None:
335+
if cluster is not None:
329336
self.addError("The admin server " + self.name(adminServer) + " belongs to the cluster " + self.name(cluster) + ".")
330337

331338
def validateClusters(self):
@@ -362,13 +369,14 @@ def validateNonDynamicClusterNotReferencedByAnyServerTemplates(self, cluster):
362369
ADMIN_LISTEN_PORT = 'admin listen port'
363370
ADMIN_LISTEN_PORT_ENABLED = 'admin listen port enabled'
364371

365-
def getServerClusterPortPropertyValue(server, clusterListenPortProperty):
372+
def getServerClusterPortPropertyValue(self, server, clusterListenPortProperty):
366373
sslListenPort = None
367-
if server.getSSL() != None:
368-
sslListenPort = server.getSSL().getListenPort()
374+
ssl = self.getSSLWA(server)
375+
if ssl is not None:
376+
sslListenPort = ssl.getListenPort()
369377
sslListenPortEnabled = None
370-
if server.getSSL()!= None:
371-
sslListenPortEnabled = server.getSSL().isListenPortEnabled()
378+
if ssl is not None:
379+
sslListenPortEnabled = ssl.isListenPortEnabled()
372380
return {
373381
LISTEN_PORT: server.getListenPort(),
374382
LISTEN_PORT_ENABLED: server.isListenPortEnabled(),
@@ -390,7 +398,7 @@ def validateNonDynamicClusterServersHaveSameListenPort(self, cluster):
390398
if cluster is server.getCluster():
391399
listenPort = server.getListenPort()
392400
listenPortEnabled = server.isListenPortEnabled()
393-
ssl = server.getSSL()
401+
ssl = self.getSSLWA(server)
394402
sslListenPort = None
395403
sslListenPortEnabled = None
396404
if ssl is not None:
@@ -427,7 +435,7 @@ def validateClusterServersListenPortProperty(self, cluster, errorMsg, clusterLis
427435
firstListenPortProperty = None
428436
for server in self.env.getDomain().getServers():
429437
if cluster is server.getCluster():
430-
listenPortProperty = getServerClusterPortPropertyValue(server, clusterListenPortProperty)
438+
listenPortProperty = getServerClusterPortPropertyValue(self, server, clusterListenPortProperty)
431439
if firstServer is None:
432440
firstServer = server
433441
firstListenPortProperty = listenPortProperty
@@ -590,7 +598,7 @@ def addServer(self, server):
590598
self.addNetworkAccessPoints(server)
591599

592600
def addSSL(self, server):
593-
ssl = server.getSSL()
601+
ssl = self.getSSLWA(server)
594602
if ssl is not None and ssl.isEnabled():
595603
self.indent()
596604
self.writeln("sslListenPort: " + str(ssl.getListenPort()))
@@ -845,20 +853,29 @@ def customizeNetworkAccessPoint(self, nap, listen_address):
845853
self.undent()
846854
self.writeln("</d:network-access-point>")
847855

856+
def getLogWA(self,server):
857+
try:
858+
ret = server.getLog()
859+
except:
860+
trace("Ignoring getLog() exception, this is expected.")
861+
ret = None
862+
return ret
863+
848864
def customizeLog(self, name, bean, isDomainBean):
849865
logs_dir = self.env.getDomainLogHome()
850866
if logs_dir is None or len(logs_dir) == 0:
851867
return
852868

853869
logaction=''
854870
fileaction=''
855-
if bean.getLog() is None:
871+
log = self.getLogWA(bean)
872+
if log is None:
856873
if not isDomainBean:
857874
# don't know why, but don't need to "add" a missing domain log bean, and adding it causes trouble
858875
logaction=' f:combine-mode="add"'
859876
fileaction=' f:combine-mode="add"'
860877
else:
861-
if bean.getLog().getFileName() is None:
878+
if log.getFileName() is None:
862879
fileaction=' f:combine-mode="add"'
863880
else:
864881
fileaction=' f:combine-mode="replace"'
@@ -1129,6 +1146,7 @@ def main(env):
11291146
traceback.print_exc()
11301147
exit(exitcode=1)
11311148
except UndeclaredThrowableException, f:
1149+
dumpStack()
11321150
print f
11331151
trace("Domain introspection failed with undeclared exception:")
11341152
traceback.print_exc()

0 commit comments

Comments
 (0)