Skip to content

Commit 927cb75

Browse files
committed
Address more review comments
Signed-off-by: doxiao <[email protected]>
1 parent 060a0c6 commit 927cb75

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

kubernetes/samples/scripts/common/domain-template.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ spec:
3232
includeServerOutInPodLog: %INCLUDE_SERVER_OUT_IN_POD_LOG%
3333
# Whether to enable log home
3434
%LOG_HOME_ON_PV_PREFIX%logHomeEnabled: %LOG_HOME_ENABLED%
35-
# The in-pod location for domain log, server logs, server out, and node manager log files
35+
# The in-pod location for domain log, server logs, server out, and Node Manager log files
3636
%LOG_HOME_ON_PV_PREFIX%logHome: %LOG_HOME%
3737
# serverStartPolicy legal values are "NEVER", "IF_NEEDED", or "ADMIN_ONLY"
3838
# This determines which WebLogic Servers the Operator will start up when it discovers this Domain

kubernetes/samples/scripts/create-weblogic-domain/domain-home-in-image/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ The following parameters can be provided in the inputs file.
108108
| `domainUID` | Unique ID that will be used to identify this particular domain. Used as the name of the generated WebLogic domain as well as the name of the Kubernetes domain resource. This ID must be unique across all domains in a Kubernetes cluster. This ID cannot contain any character that is not valid in a Kubernetes service name. | `domain1` |
109109
| `exposeAdminNodePort` | Boolean indicating if the Administration Server is exposed outside of the Kubernetes cluster. | `false` |
110110
| `exposeAdminT3Channel` | Boolean indicating if the T3 administrative channel is exposed outside the Kubernetes cluster. | `false` |
111-
| `image` | WebLogic Server Docker image that the Operator uses to start the domain. The create domain scripts generate a WebLogic Server Docker image with a domain home in it. By default, the scripts tag the generated WebLogic server Docker image as either `domain-home-in-image` or `domain-home-in-image-wdt` based on the `domainHomeImageBuildPath` property, and use it to set the `image` in the generated domain YAML file. If this property is set, the create domain scripts will use the value specified, instead of the default value, to tag the generated image and set the `image` in the domain YAML file. If you are running the sample scripts from a machine that is remote to the Kubernetes cluster where the domain is going to be running, you need to set this property to the image name that is intended to be used in a registry local to that Kubernetes cluster. You also need to push the `image` to that registry before starting the domain using the `kubectl create -f` or `kubectl apply -f` command. | |
111+
| `image` | WebLogic Server Docker image that the operator uses to start the domain. The create domain scripts generate a WebLogic Server Docker image with a domain home in it. By default, the scripts tag the generated WebLogic server Docker image as either `domain-home-in-image` or `domain-home-in-image-wdt` based on the `domainHomeImageBuildPath` property, and use it to set the `image` element in the generated domain YAML file. If this property is set, the create domain scripts will use the value specified, instead of the default value, to tag the generated image and set the `image` in the domain YAML file. If you are running the sample scripts from a machine that is remote to the Kubernetes cluster where the domain is going to be running, you need to set this property to the image name that is intended to be used in a registry local to that Kubernetes cluster. You also need to push the `image` to that registry before starting the domain using the `kubectl create -f` or `kubectl apply -f` command. | |
112112
| `imagePullPolicy` | WebLogic Docker image pull policy. Legal values are `IfNotPresent`, `Always`, or `Never`. | `IfNotPresent` |
113113
| `imagePullSecretName` | Name of the Kubernetes secret to access the Docker Store to pull the WebLogic Server Docker image. The presence of the secret will be validated when this parameter is specified. | |
114114
| `includeServerOutInPodLog` | Boolean indicating whether to include `server.out` to the pod's stdout. | `true` |
@@ -160,7 +160,7 @@ spec:
160160
domainHome: /u01/oracle/user_projects/domains/domain1
161161
# If the domain home is in the image
162162
domainHomeInImage: true
163-
# The WebLogic Server Docker image that the Operator uses to start the domain
163+
# The WebLogic Server Docker image that the operator uses to start the domain
164164
image: "domain-home-in-image"
165165
# imagePullPolicy defaults to "Always" if image version is :latest
166166
imagePullPolicy: "IfNotPresent"
@@ -178,7 +178,7 @@ spec:
178178
# The in-pod location for domain log, server logs, server out, and Node Manager log files
179179
# logHome: /shared/logs/domain1
180180
# serverStartPolicy legal values are "NEVER", "IF_NEEDED", or "ADMIN_ONLY"
181-
# This determines which WebLogic Servers the Operator will start up when it discovers this Domain
181+
# This determines which WebLogic Servers the operator will start up when it discovers this Domain
182182
# - "NEVER" will not start any server in the domain
183183
# - "ADMIN_ONLY" will start up only the administration server (no managed servers will be started)
184184
# - "IF_NEEDED" will start all non-clustered servers, including the administration server and clustered servers up to the replica count

kubernetes/samples/scripts/create-weblogic-domain/domain-home-in-image/create-domain-inputs.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ adminServerName: admin-server
1515
# in a Kubernetes cluster.
1616
domainUID: domain1
1717

18-
# Determines which WebLogic Servers the Operator will start up
18+
# Determines which WebLogic Servers the operator will start up
1919
# Legal values are "NEVER", "IF_NEEDED", or "ADMIN_ONLY"
2020
serverStartPolicy: IF_NEEDED
2121

@@ -37,12 +37,12 @@ managedServerPort: 8001
3737
# Boolean indicating if production mode is enabled for the domain
3838
productionModeEnabled: true
3939

40-
# WebLogic Server Docker image that the Operator uses to start the domain.
40+
# WebLogic Server Docker image that the operator uses to start the domain.
4141
#
4242
# The create domain scripts generate a WebLogic Server Docker image with a domain home in it.
4343
# By default, the scripts tag the generated WebLogic server Docker image as either
4444
# `domain-home-in-image` or `domain-home-in-image-wdt` based on the `domainHomeImageBuildPath`
45-
# property, and use it to set the `image` in the generated domain YAML file.
45+
# property, and use it to set the `image` element in the generated domain YAML file.
4646
#
4747
# If this property is set, the create domain scripts will use the value specified, instead of the
4848
# default value, to tag the generated image and set the `image` in the domain YAML file.

kubernetes/samples/scripts/create-weblogic-domain/domain-home-on-pv/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ spec:
133133
domainHome: /shared/domains/domain1
134134
# If the domain home is in the image
135135
domainHomeInImage: false
136-
# The WebLogic Server Docker image that the Operator uses to start the domain
136+
# The WebLogic Server Docker image that the operator uses to start the domain
137137
image: "oracle/weblogic:12213-patch-wls-for-k8s"
138138
# imagePullPolicy defaults to "Always" if image version is :latest
139139
imagePullPolicy: "IfNotPresent"
@@ -151,7 +151,7 @@ spec:
151151
# The in-pod name location for domain log, server logs, server out, and Node Manager log files
152152
logHome: /shared/logs/domain1
153153
# serverStartPolicy legal values are "NEVER", "IF_NEEDED", or "ADMIN_ONLY"
154-
# This determines which WebLogic Servers the Operator will start up when it discovers this Domain
154+
# This determines which WebLogic Servers the operator will start up when it discovers this Domain
155155
# - "NEVER" will not start any server in the domain
156156
# - "ADMIN_ONLY" will start up only the administration server (no managed servers will be started)
157157
# - "IF_NEEDED" will start all non-clustered servers, including the administration server and clustered servers up to the replica count

kubernetes/samples/scripts/create-weblogic-domain/domain-home-on-pv/create-domain-inputs.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ domainUID: domain1
1818
# If not specified, the value is derived from the domainUID as /shared/domains/<domainUID>
1919
domainHome: /shared/domains/domain1
2020

21-
# Determines which WebLogic Servers the Operator will start up
21+
# Determines which WebLogic Servers the operator will start up
2222
# Legal values are "NEVER", "IF_NEEDED", or "ADMIN_ONLY"
2323
serverStartPolicy: IF_NEEDED
2424

0 commit comments

Comments
 (0)