Skip to content

Commit 97f686c

Browse files
authored
port 3713 to main (#3727)
1 parent c60218e commit 97f686c

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItWlsSamples.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@
5454
import static oracle.weblogic.kubernetes.TestConstants.TEST_IMAGES_REPO_SECRET_NAME;
5555
import static oracle.weblogic.kubernetes.TestConstants.TEST_NGINX_IMAGE_NAME;
5656
import static oracle.weblogic.kubernetes.TestConstants.WEBLOGIC_IMAGE_TAG;
57+
import static oracle.weblogic.kubernetes.TestConstants.WEBLOGIC_IMAGE_TAG_DEFAULT;
5758
import static oracle.weblogic.kubernetes.TestConstants.WEBLOGIC_IMAGE_TO_USE_IN_SPEC;
5859
import static oracle.weblogic.kubernetes.actions.ActionConstants.ITTESTS_DIR;
5960
import static oracle.weblogic.kubernetes.actions.ActionConstants.MODEL_DIR;
@@ -228,7 +229,7 @@ void testSampleDomainInImage(String model) {
228229
// update domainHomeImageBase with right values in create-domain-inputs.yaml
229230
assertDoesNotThrow(() -> {
230231
replaceStringInFile(get(sampleBase.toString(), "create-domain-inputs.yaml").toString(),
231-
"domainHomeImageBase: container-registry.oracle.com/middleware/weblogic:" + WEBLOGIC_IMAGE_TAG,
232+
"domainHomeImageBase: container-registry.oracle.com/middleware/weblogic:" + WEBLOGIC_IMAGE_TAG_DEFAULT,
232233
"domainHomeImageBase: " + WEBLOGIC_IMAGE_TO_USE_IN_SPEC);
233234
replaceStringInFile(get(sampleBase.toString(), "create-domain-inputs.yaml").toString(),
234235
"#image:",
@@ -303,7 +304,7 @@ void testSampleDomainInPv(String model) {
303304
"createDomainFilesDir: wlst", "createDomainFilesDir: "
304305
+ script);
305306
replaceStringInFile(get(sampleBase.toString(), "create-domain-inputs.yaml").toString(),
306-
"image: container-registry.oracle.com/middleware/weblogic:" + WEBLOGIC_IMAGE_TAG,
307+
"image: container-registry.oracle.com/middleware/weblogic:" + WEBLOGIC_IMAGE_TAG_DEFAULT,
307308
"image: " + WEBLOGIC_IMAGE_TO_USE_IN_SPEC);
308309
});
309310

integration-tests/src/test/java/oracle/weblogic/kubernetes/utils/FileUtils.java

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
import java.io.FileNotFoundException;
88
import java.io.FileOutputStream;
99
import java.io.IOException;
10-
import java.nio.charset.Charset;
1110
import java.nio.charset.StandardCharsets;
1211
import java.nio.file.FileVisitResult;
1312
import java.nio.file.Files;
@@ -500,15 +499,16 @@ public static void replaceStringInFile(String filePath, String regex, String rep
500499
throws IOException {
501500
LoggingFacade logger = getLogger();
502501
Path src = Paths.get(filePath);
503-
logger.info("Replacing {0} in {1}", regex, src.toString());
504-
Charset charset = StandardCharsets.UTF_8;
505-
String content = new String(Files.readAllBytes(src), charset);
506-
String newcontent = content.replaceAll(regex, replacement);
507-
logger.info("with {0}", replacement);
508-
if (content.equals(newcontent)) {
502+
logger.info("Replacing {0} in {1} with {2}", regex, src.toString(), replacement);
503+
String content = new String(Files.readAllBytes(src), StandardCharsets.UTF_8);
504+
if (!content.contains(regex)) {
509505
logger.info("search string {0} not found to replace with {1}", regex, replacement);
510506
}
511-
Files.write(src, newcontent.getBytes(charset));
507+
long oldModified = src.toFile().lastModified();
508+
Files.write(src, content.replaceAll(regex, replacement).getBytes(StandardCharsets.UTF_8));
509+
if (oldModified == src.toFile().lastModified()) {
510+
logger.info("No modification was done to the file");
511+
}
512512
}
513513

514514
/**

0 commit comments

Comments
 (0)