Skip to content

Commit 9c380eb

Browse files
committed
Javadoc and cleanup
1 parent 149c271 commit 9c380eb

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

src/main/java/oracle/kubernetes/operator/helpers/HealthCheckHelper.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,10 @@ public void performSecurityChecks(String svcAccountName) throws ApiException {
220220
}
221221
}
222222

223+
/**
224+
* Major and minor version of Kubernetes API Server
225+
*
226+
*/
223227
public static class KubernetesVersion {
224228
public final int major;
225229
public final int minor;

src/main/java/oracle/kubernetes/operator/helpers/ServiceHelper.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,10 +49,9 @@ public NextAction apply(Packet packet) {
4949
String serverName = (String) packet.get(ProcessingConstants.SERVER_NAME);
5050
Integer port = (Integer) packet.get(ProcessingConstants.PORT);
5151
Integer nodePort = (Integer) packet.get(ProcessingConstants.NODE_PORT);
52-
52+
5353
Domain dom = info.getDomain();
5454
V1ObjectMeta meta = dom.getMetadata();
55-
5655
DomainSpec spec = dom.getSpec();
5756
String namespace = meta.getNamespace();
5857

@@ -74,19 +73,19 @@ public NextAction apply(Packet packet) {
7473

7574
AnnotationHelper.annotateWithDomain(metadata, dom);
7675
metadata.putAnnotationsItem("service.alpha.kubernetes.io/tolerate-unready-endpoints", "true");
77-
76+
7877
V1ServiceSpec serviceSpec = new V1ServiceSpec();
7978
serviceSpec.setType(nodePort == null ? "ClusterIP" : "NodePort");
80-
79+
8180
Map<String, String> selector = new HashMap<>();
8281
selector.put(LabelConstants.DOMAINUID_LABEL, weblogicDomainUID);
8382
selector.put(LabelConstants.SERVERNAME_LABEL, serverName);
8483
serviceSpec.setSelector(selector);
85-
84+
8685
if (version != null && (version.major > 1 || (version.major == 1 && version.minor >= 8))) {
8786
serviceSpec.setPublishNotReadyAddresses(Boolean.TRUE);
8887
}
89-
88+
9089
List<V1ServicePort> ports = new ArrayList<>();
9190
V1ServicePort servicePort = new V1ServicePort();
9291
servicePort.setPort(port);

0 commit comments

Comments
 (0)