Backport ServerStartup Policy tests, fixed domain events retrieval to 3.4 release (#2896)

* Backport ServerStartup Policy tests, fixed domain events retrieval to 3.4 release

Author: marinakog

integration-tests/pom.xml

@@ -297,6 +297,8 @@
                 <includes-failsafe>
                   **/ItMultiDomainModels,
                   **/ItServerStartPolicy,
+                  **/ItServerStartPolicyDynamicCluster,
+                  **/ItServerStartPolicyConfigCluster,
                   **/ItMiiUpdateDomainConfig,
                   **/ItIntrospectVersion,
                   **/ItFmwDomainInPV,

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItInitContainers.java

@@ -52,7 +52,7 @@
 import static oracle.weblogic.kubernetes.utils.ImageUtils.dockerLoginAndPushImageToRegistry;
 import static oracle.weblogic.kubernetes.utils.OperatorUtils.installAndVerifyOperator;
 import static oracle.weblogic.kubernetes.utils.OperatorUtils.upgradeAndVerifyOperator;
-import static oracle.weblogic.kubernetes.utils.PodUtils.checkPodInitializing;
+import static oracle.weblogic.kubernetes.utils.PodUtils.checkPodInitialized;
 import static oracle.weblogic.kubernetes.utils.PodUtils.checkPodReady;
 import static oracle.weblogic.kubernetes.utils.PodUtils.getPodCreationTime;
 import static oracle.weblogic.kubernetes.utils.PodUtils.setPodAntiAffinity;
@@ -415,7 +415,7 @@ private void createAndVerifyMiiDomain(String domainNamespace, String domainUid,
     createDomainAndVerify(domain, domainNamespace);
     String adminServerPodName = domainUid + adminServerPrefix;
     //check if pod in init state
-    checkPodInitializing(adminServerPodName,domainUid, domainNamespace);
+    checkPodInitialized(adminServerPodName,domainUid, domainNamespace);
 
     // check that admin service exists and pod is ready in the domain namespace
     logger.info("Checking that admin service {0} exists in namespace {1}",
@@ -426,7 +426,7 @@ private void createAndVerifyMiiDomain(String domainNamespace, String domainUid,
     for (int i = 1; i <= replicaCount; i++) {
       String managedServerPodName = domainUid + managedServerPrefix + i;
       //check if pod in init state
-      checkPodInitializing(managedServerPodName,domainUid, domainNamespace);
+      checkPodInitialized(managedServerPodName,domainUid, domainNamespace);
       // check that the managed server service exists and pod is ready in the domain namespace
       logger.info("Checking that managed server service {0} exists in namespace {1}",
           managedServerPodName, domainNamespace);

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItKubernetesEvents.java

@@ -148,6 +148,7 @@ class ItKubernetesEvents {
   final String cluster1Name = "mycluster";
   final String cluster2Name = "cl2";
   final String adminServerName = "admin-server";
+  final String domainUid = "k8seventsdomain";
   final String adminServerPodName = domainUid + "-" + adminServerName;
   final String managedServerNameBase = "ms-";
   String managedServerPodNamePrefix = domainUid + "-" + managedServerNameBase;
@@ -156,7 +157,6 @@ class ItKubernetesEvents {
 
   final String pvName = getUniquePvOrPvcName(domainUid + "-pv-");
   final String pvcName = getUniquePvOrPvcName(domainUid + "-pvc-");
-  private static final String domainUid = "k8seventsdomain";
   private final String wlSecretName = "weblogic-credentials";
 
   // create standard, reusable retry/backoff policy

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItServerStartPolicy.java

@@ -286,15 +286,15 @@ public static Callable<Boolean> podReady(String podName, String domainUid, Strin
   }
 
   /**
-   * Check if a Kubernetes pod is in initializing state.
+   * Check if a Kubernetes pod is in initialized state.
    *
    * @param podName   name of the pod to check for
    * @param domainUid WebLogic domain uid in which the pod belongs
-   * @param namespace in which the pod is initializing
-   * @return true if the pod is initializing otherwise false
+   * @param namespace in which the pod is initialized
+   * @return true if the pod is initialized otherwise false
    */
-  public static Callable<Boolean> podInitializing(String podName, String domainUid, String namespace) {
-    return Pod.podInitializing(namespace, domainUid, podName);
+  public static Callable<Boolean> podInitialized(String podName, String domainUid, String namespace) {
+    return Pod.podInitialized(namespace, domainUid, podName);
   }
 
   /**

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItServerStartPolicyConfigCluster.java

@@ -136,14 +136,14 @@ public static boolean isPodRunning(String namespace, String domainUid, String po
   }
 
   /**
-   * Checks if a pod exists in a given namespace and in Running state.
+   * Checks if a pod exists in a given namespace and in Initialized state.
    * @param namespace in which to check for the pod running
    * @param domainUid the label the pod is decorated with
    * @param podName name of the pod to check for
    * @return true if pod exists and running otherwise false
    * @throws ApiException when there is error in querying the cluster
    */
-  public static boolean isPodInitializing(String namespace, String domainUid, String podName) throws ApiException {
+  public static boolean isPodInitialized(String namespace, String domainUid, String podName) throws ApiException {
     final LoggingFacade logger = getLogger();
     boolean status = false;
     V1Pod pod = getPod(namespace, null, podName);

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItServerStartPolicyDynamicCluster.java

@@ -1,4 +1,4 @@
-// Copyright (c) 2020, 2021, Oracle and/or its affiliates.
+// Copyright (c) 2020, 2022, Oracle and/or its affiliates.
 // Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
 
 package oracle.weblogic.kubernetes.assertions.impl;
@@ -130,9 +130,9 @@ public static Callable<Boolean> podReady(String namespace, String domainUid, Str
    * @param podName name of the pod
    * @return true if pod is initializing otherwise false
    */
-  public static Callable<Boolean> podInitializing(String namespace, String domainUid, String podName) {
+  public static Callable<Boolean> podInitialized(String namespace, String domainUid, String podName) {
     return () -> {
-      return Kubernetes.isPodInitializing(namespace, domainUid, podName);
+      return Kubernetes.isPodInitialized(namespace, domainUid, podName);
     };
   }
 

integration-tests/src/test/java/oracle/weblogic/kubernetes/assertions/TestAssertions.java

@@ -69,14 +69,16 @@
  */
 public class CommonTestUtils {
 
-  public static ConditionFactory withStandardRetryPolicy =
-      with().pollDelay(2, SECONDS)
-          .and().with().pollInterval(10, SECONDS)
-          .atMost(5, MINUTES).await();
 
-  public static ConditionFactory withQuickRetryPolicy = with().pollDelay(0, SECONDS)
-      .and().with().pollInterval(3, SECONDS)
-      .atMost(120, SECONDS).await();
+  public static ConditionFactory withStandardRetryPolicy = createStandardRetryPolicyWithAtMost(10);
+  public static ConditionFactory withLongRetryPolicy = createStandardRetryPolicyWithAtMost(15);
+  public static ConditionFactory withQuickRetryPolicy = createStandardRetryPolicyWithAtMost(2);
+
+  private static ConditionFactory createStandardRetryPolicyWithAtMost(long minutes) {
+    return with().pollDelay(2, SECONDS)
+            .and().with().pollInterval(10, SECONDS)
+            .atMost(minutes, MINUTES).await();
+  }
 
   /**
    * Test assertion using standard retry policy over time until it passes or the timeout expires.
@@ -158,6 +160,25 @@ public static void checkPodReadyAndServiceExists(String podName, String domainUi
     checkPodReady(podName, domainUid, namespace);
   }
 
+  /**
+   * Check pod is ready and service exists in the specified namespace.
+   *
+   * @param conditionFactory Configuration for Awaitility condition factory
+   * @param podName pod name to check
+   * @param domainUid the label the pod is decorated with
+   * @param namespace the namespace in which the pod exists
+   */
+  public static void checkPodReadyAndServiceExists(ConditionFactory conditionFactory,
+                                                   String podName, String domainUid, String namespace) {
+    LoggingFacade logger = getLogger();
+
+    logger.info("Check service {0} exists in namespace {1}", podName, namespace);
+    checkServiceExists(conditionFactory, podName, namespace);
+
+    logger.info("Waiting for pod {0} to be ready in namespace {1}", podName, namespace);
+    checkPodReady(conditionFactory, podName, domainUid, namespace);
+  }
+
   /**
    * Check service exists in the specified namespace.
    *
@@ -179,6 +200,25 @@ public static void checkServiceExists(String serviceName, String namespace) {
                 serviceName, namespace)));
   }
 
+  /**
+   * Check service exists in the specified namespace.
+   *
+   * @param conditionFactory Configuration for Awaitility condition factory
+   * @param serviceName service name to check
+   * @param namespace the namespace in which to check for the service
+   */
+  public static void checkServiceExists(ConditionFactory conditionFactory,String serviceName, String namespace) {
+    LoggingFacade logger = getLogger();
+    testUntil(conditionFactory,
+            assertDoesNotThrow(() -> serviceExists(serviceName, null, namespace),
+                    String.format("serviceExists failed with ApiException for service %s in namespace %s",
+                            serviceName, namespace)),
+            logger,
+            "service {0} to exist in namespace {1}",
+            serviceName,
+            namespace);
+  }
+
   /**
    * add security context constraints to the service account of db namespace.
    * @param serviceAccount - service account to add to scc