Skip to content

Commit aa08361

Browse files
committed
Better handling optional elements in apache yaml file
Signed-off-by: doxiao <[email protected]>
1 parent a003b86 commit aa08361

File tree

2 files changed

+19
-22
lines changed

2 files changed

+19
-22
lines changed

kubernetes/internal/create-weblogic-domain.sh

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -575,24 +575,21 @@ function createYamlFiles {
575575

576576
echo Generating ${apacheOutput}
577577

578-
# This part needs to be done before substitution of %DOMAIN_UID%, %ADMIN_SERVER_NAME% and %ADMIN_PORT%
579578
if [ "${loadBalancerExposeAdminPort}" = "true" ]; then
580-
sed -i -e "s|# - name: WEBLOGIC_HOST| - name: WEBLOGIC_HOST|g" ${apacheOutput}
581-
sed -i -e "s|# value: '%DOMAIN_UID%-%ADMIN_SERVER_NAME%'| value: '%DOMAIN_UID%-%ADMIN_SERVER_NAME%'|g" ${apacheOutput}
582-
sed -i -e "s|# - name: WEBLOGIC_PORT| - name: WEBLOGIC_PORT|g" ${apacheOutput}
583-
sed -i -e "s|# value: '%ADMIN_PORT%'| value: '%ADMIN_PORT%'|g" ${apacheOutput}
579+
enableLoadBalancerExposeAdminPortPrefix="${enabledPrefix}"
580+
else
581+
enableLoadBalancerExposeAdminPortPrefix="${disabledPrefix}"
584582
fi
585583

586584
if [ ! -z "${loadBalancerVolumePath}" ]; then
585+
enableLoadBalancerVolumePathPrefix="${enabledPrefix}"
587586
sed -i -e "s:%LOAD_BALANCER_VOLUME_PATH%:${loadBalancerVolumePath}:g" ${apacheOutput}
588-
sed -i -e "s:# volumes:volumes:g" ${apacheOutput}
589-
sed -i -e "s|# - name: %DOMAIN_UID%-apache-webtier|- name: %DOMAIN_UID%-apache-webtier|g" ${apacheOutput}
590-
sed -i -e "s:# hostPath: hostPath:g" ${apacheOutput}
591-
sed -i -e "s:# path: path:g" ${apacheOutput}
592-
sed -i -e "s:# volumeMounts:volumeMounts:g" ${apacheOutput}
593-
sed -i -e "s:# mountPath: mountPath:g" ${apacheOutput}
587+
else
588+
enableLoadBalancerVolumePathPrefix="${disabledPrefix}"
594589
fi
595590

591+
sed -i -e "s:%ENABLE_LOAD_BALANCER_EXPOSE_ADMIN_PORT%:${enableLoadBalancerExposeAdminPortPrefix}:g" ${apacheOutput}
592+
sed -i -e "s:%ENABLE_LOAD_BALANCER_VOLUME_PATH%:${enableLoadBalancerVolumePathPrefix}:g" ${apacheOutput}
596593
sed -i -e "s:%NAMESPACE%:$namespace:g" ${apacheOutput}
597594
sed -i -e "s:%DOMAIN_UID%:${domainUID}:g" ${apacheOutput}
598595
sed -i -e "s:%DOMAIN_NAME%:${domainName}:g" ${apacheOutput}

kubernetes/internal/weblogic-domain-apache-template.yaml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -37,26 +37,26 @@ spec:
3737
spec:
3838
serviceAccountName: %DOMAIN_UID%-apache-webtier
3939
terminationGracePeriodSeconds: 60
40-
# volumes:
41-
# - name: %DOMAIN_UID%-apache-webtier
42-
# hostPath:
43-
# path: %LOAD_BALANCER_VOLUME_PATH%
40+
%ENABLE_LOAD_BALANCER_VOLUME_PATH%volumes:
41+
%ENABLE_LOAD_BALANCER_VOLUME_PATH%- name: %DOMAIN_UID%-apache-webtier
42+
%ENABLE_LOAD_BALANCER_VOLUME_PATH% hostPath:
43+
%ENABLE_LOAD_BALANCER_VOLUME_PATH% path: %LOAD_BALANCER_VOLUME_PATH%
4444
containers:
4545
- name: %DOMAIN_UID%-apache-webtier
4646
image: store/oracle/apache:12.2.1.3
4747
imagePullPolicy: Never
48-
# volumeMounts:
49-
# - name: %DOMAIN_UID%-apache-webtier
50-
# mountPath: "/config"
48+
%ENABLE_LOAD_BALANCER_VOLUME_PATH%volumeMounts:
49+
%ENABLE_LOAD_BALANCER_VOLUME_PATH%- name: %DOMAIN_UID%-apache-webtier
50+
%ENABLE_LOAD_BALANCER_VOLUME_PATH% mountPath: "/config"
5151
env:
5252
- name: WEBLOGIC_CLUSTER
5353
value: '%DOMAIN_UID%-cluster-%CLUSTER_NAME_LC%:%MANAGED_SERVER_PORT%'
5454
- name: LOCATION
5555
value: '%WEB_APP_PREPATH%'
56-
# - name: WEBLOGIC_HOST
57-
# value: '%DOMAIN_UID%-%ADMIN_SERVER_NAME%'
58-
# - name: WEBLOGIC_PORT
59-
# value: '%ADMIN_PORT%'
56+
%ENABLE_LOAD_BALANCER_EXPOSE_ADMIN_PORT%- name: WEBLOGIC_HOST
57+
%ENABLE_LOAD_BALANCER_EXPOSE_ADMIN_PORT% value: '%DOMAIN_UID%-%ADMIN_SERVER_NAME%'
58+
%ENABLE_LOAD_BALANCER_EXPOSE_ADMIN_PORT%- name: WEBLOGIC_PORT
59+
%ENABLE_LOAD_BALANCER_EXPOSE_ADMIN_PORT% value: '%ADMIN_PORT%'
6060
readinessProbe:
6161
tcpSocket:
6262
port: 80

0 commit comments

Comments
 (0)