Skip to content

Commit aa695a7

Browse files
committed
Harden removing Ingress
1 parent 0a11c91 commit aa695a7

File tree

2 files changed

+4
-35
lines changed

2 files changed

+4
-35
lines changed

src/main/java/oracle/kubernetes/operator/helpers/IngressHelper.java

Lines changed: 2 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,8 @@ public NextAction apply(Packet packet) {
197197
String clusterName = (String) packet.get(ProcessingConstants.CLUSTER_NAME);
198198
V1ObjectMeta meta = service.getMetadata();
199199

200-
String ingressName;
201-
ingressName = getIngressName(info, serverName);
200+
String ingressName= CallBuilder.toDNS1123LegalName(
201+
info.getDomain().getSpec().getDomainUID() + "-" + clusterName);
202202
if (ingressName != null) {
203203
return doNext(CallBuilder.create().readIngressAsync(
204204
ingressName, meta.getNamespace(), new ResponseStep<V1beta1Ingress>(next) {
@@ -344,35 +344,4 @@ private static boolean addV1beta1HTTPIngressPath(V1beta1Ingress v1beta1Ingress,
344344
return false;
345345
}
346346

347-
/**
348-
* Get the ingress name to remove.
349-
* @param info DomainPresenceInfo object
350-
* @param serverName server name to remove
351-
* @return name of ingress
352-
*/
353-
private static String getIngressName(DomainPresenceInfo info, String serverName) {
354-
Map<String, WlsClusterConfig> clusters = info.getScan().getClusterConfigs();
355-
String ingressName = null;
356-
357-
// Get the cluster ingress if we have one
358-
if (clusters != null) {
359-
for (Map.Entry<String, WlsClusterConfig> clusterConfig : clusters.entrySet()) {
360-
List<WlsServerConfig> servers = clusterConfig.getValue().getServerConfigs();
361-
if (servers != null) {
362-
for (WlsServerConfig server : servers) {
363-
if (serverName.equals(server.getName())) {
364-
ingressName = CallBuilder.toDNS1123LegalName(
365-
info.getDomain().getSpec().getDomainUID() + "-" + clusterConfig.getKey());
366-
break;
367-
}
368-
}
369-
}
370-
if (ingressName != null) {
371-
break;
372-
}
373-
}
374-
}
375-
376-
return ingressName;
377-
}
378347
}

wercker.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ build:
4343
mkdir /operator
4444
cp -R src/main/scripts/* /operator/
4545
cp target/weblogic-kubernetes-operator-0.1.0-alpha-SNAPSHOT.jar /operator/weblogic-kubernetes-operator.jar
46-
export IMAGE_TAG_OPERATOR="${WERCKER_GIT_BRANCH//[_/]/-}"
46+
export IMAGE_TAG_OPERATOR="${WERCKER_GIT_BRANCH//[_\/]/-}"
4747
if [ "$IMAGE_TAG_OPERATOR" = "master" ]; then
4848
export IMAGE_TAG_OPERATOR="latest"
4949
fi
@@ -146,7 +146,7 @@ integration-test:
146146
kubectl create secret docker-registry quay-io -n weblogic-operator-2 --docker-server=quay.io --docker-username=$QUAY_USERNAME --docker-password=$QUAY_PASSWORD --docker-email=$QUAY_EMAIL
147147
148148
export IMAGE_NAME_OPERATOR="quay.io/markxnelson/weblogic-kubernetes-operator"
149-
export IMAGE_TAG_OPERATOR="${WERCKER_GIT_BRANCH//[_/]/-}"
149+
export IMAGE_TAG_OPERATOR="${WERCKER_GIT_BRANCH//[_\/]/-}"
150150
if [ "$IMAGE_TAG_OPERATOR" = "master" ]; then
151151
export IMAGE_TAG_OPERATOR="latest"
152152
fi

0 commit comments

Comments
 (0)