Limit event note to 1024 characters

Author: rjeberhard

operator/src/main/java/oracle/kubernetes/operator/helpers/EventHelper.java

@@ -108,6 +108,8 @@ public class EventHelper {
 
   private static final Random random = new Random();
 
+  private static final int MAX_NOTE_LENGTH = 1024;
+
   /**
    * Factory for {@link Step} that asynchronously create an event.
    *
@@ -196,7 +198,7 @@ private static EventsV1Event createEventModel(
           .type(eventItem.getType())
           .action(eventItem.getReason()) // use reason for action and reason
           .reason(eventItem.getReason())
-          .note(eventItem.getNote(eventData))
+          .note(limitLength(eventItem.getNote(eventData), MAX_NOTE_LENGTH))
           .regarding(eventItem.createRegarding(eventData));
     }
 
@@ -1123,7 +1125,7 @@ private static EventsV1Event createConversionWebhookEventModel(EventItem eventIt
                 .type(eventItem.getType())
                 .action(eventItem.getReason()) // use reason for action and reason
                 .reason(eventItem.getReason())
-                .note(eventItem.getNote(eventData))
+                .note(limitLength(eventItem.getNote(eventData), MAX_NOTE_LENGTH))
                 .regarding(eventItem.createRegarding(eventData))
                 .metadata(CreateEventStep.createMetadata(eventData));
   }
@@ -1184,7 +1186,7 @@ private static EventsV1Event createEventModel(EventData eventData) {
           .type(eventItem.getType())
           .action(eventItem.getReason()) // use reason for action and reason
           .reason(eventItem.getReason())
-          .note(eventItem.getNote(eventData))
+          .note(limitLength(eventItem.getNote(eventData), MAX_NOTE_LENGTH))
           .regarding(eventItem.createRegarding(eventData));
     }
 
@@ -1336,4 +1338,11 @@ public String getResourceNameFromInfo() {
       return Optional.ofNullable(domainUid).orElse("");
     }
   }
+
+  private static String limitLength(String input, int maxLength) {
+    if (input == null) {
+      return null;
+    }
+    return input.length() > maxLength ? input.substring(0, maxLength) : input;
+  }
 }

operator/src/test/java/oracle/kubernetes/operator/helpers/TopologyValidationStepTest.java

@@ -484,9 +484,6 @@ private void assertTopologyMismatchReported(String messageKey, Object... paramet
 
     assertThat(domain, hasCondition(FAILED).withReason(TOPOLOGY_MISMATCH).withMessageContaining(message));
     assertThat(logRecords, containsWarning(messageKey).withParams(parameters));
-    assertThat(testSupport,
-        hasEvent(DOMAIN_FAILED_EVENT)
-            .withNoteContaining(getLocalizedString(TOPOLOGY_MISMATCH_EVENT_ERROR), message));
   }
 
   private void assertMaxReplicasSet() {