basing integration test enforcer rules on skipITs property value (#2918)

* basing integration test enforcer rules on skipITs property value

* adding debug output

* debugging no tests issue

* declaring the compiler plugin testCompile goal to run

* reverting to jar packaging type

* removing argLine configuration from maven-failsafe-plugin

* forcing empty argLine configuration from maven-failsafe-plugin

* removing debug flag from integration-tests

Author: robertpatrick

Jenkinsfile

@@ -612,7 +612,7 @@ EOF
                                 sudo mv -f ${result_root}/* "${WORKSPACE}/logdir/${BUILD_TAG}/wl_k8s_test_results"
                             '''
                             archiveArtifacts(artifacts: "logdir/**/*")
-                            junit(testResults: 'integration-tests/target/failsafe-reports/*.xml')
+                            junit(testResults: 'integration-tests/target/failsafe-reports/*.xml', allowEmptyResults: true)
                         }
                     }
                 }

integration-tests/pom.xml

@@ -127,7 +127,7 @@
                             <goal>enforce</goal>
                         </goals>
                         <configuration>
-                            <skip>${wko.it.skip.enforcer.rules}</skip>
+                            <skip>${skipITs}</skip>
                             <rules>
                                 <requireEnvironmentVariable>
                                     <message>Set the TWO_CLUSTERS environment variable to true or false to specify whether to run inter-cluster communication tests.</message>
@@ -163,7 +163,7 @@
                 <artifactId>maven-failsafe-plugin</artifactId>
                 <configuration>
                     <encoding>UTF-8</encoding>
-                    <argLine>@{argLine} --add-opens java.base/java.time=ALL-UNNAMED</argLine>
+                    <skipTests>${skipITs}</skipTests>
                     <argLine>${failsafeArgLine}</argLine>
                     <failIfNoTests>false</failIfNoTests>
                     <includes>
@@ -184,7 +184,6 @@
                         </goals>
                         <phase>integration-test</phase>
                         <configuration>
-                            <skipTests>${skipITs}</skipTests>
                             <systemPropertyVariables>
                                 <java.util.logging.SimpleFormatter.format>&lt;%1$tm-%1$td-%1$tY %1$tH:%1$tM:%1$tS&gt; &lt;%4$s&gt; &lt;%2$s&gt; &lt;%5$s%6$s&gt;%n
                                 </java.util.logging.SimpleFormatter.format>
@@ -341,22 +340,19 @@
                 <surefireArgLine></surefireArgLine>
                 <failsafeArgLine></failsafeArgLine>
                 <skipITs>true</skipITs>
-                <wko.it.skip.enforcer.rules>true</wko.it.skip.enforcer.rules>
             </properties>
         </profile>
         <profile>
             <id>integration-tests</id>
             <properties>
                 <skipITs>false</skipITs>
-                <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
                 <includes-failsafe>**/It*</includes-failsafe>
             </properties>
         </profile>
         <profile>
             <id>wls-image-cert</id>
             <properties>
                 <skipITs>false</skipITs>
-                <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
                 <includes-failsafe>
                    **/ItExternalLbTunneling,
                    **/ItMiiAuxiliaryImage,
@@ -394,7 +390,6 @@
             <id>fmw-pipeline</id>
             <properties>
                 <skipITs>false</skipITs>
-                <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
                 <includes-failsafe>
                     **/ItMiiAuxiliaryImage,
                     **/ItMiiAuxiliaryImageCluster,
@@ -415,7 +410,6 @@
             <id>fmw-image-cert</id>
             <properties>
                 <skipITs>false</skipITs>
-                <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
                 <includes-failsafe>
                   **/ItMiiSample,
                   **/ItFmwDomainInPV,
@@ -429,7 +423,6 @@
             <id>fmw-srg</id>
             <properties>
                 <skipITs>false</skipITs>
-                <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
                 <includes-failsafe>
                   **/ItFmwDomainInPVUsingWLST,
                   **/ItFmwDomainInPVUsingWDT,
@@ -441,7 +434,6 @@
             <id>oke-cert</id>
             <properties>
                 <skipITs>false</skipITs>
-                <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
                 <includes-failsafe>
                   **/ItMultiDomainModels,
                   **/ItServerStartPolicy,
@@ -467,7 +459,6 @@
             <id>kind-sequential</id>
             <properties>
                 <skipITs>false</skipITs>
-                <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
                 <includes-failsafe>
                   **/ItT3Channel,
                   **/ItDedicatedMode,
@@ -482,7 +473,6 @@
             <id>wls-srg</id>
             <properties>
                 <skipITs>false</skipITs>
-                <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
                 <includes-failsafe>
                     **/ItKubernetesEvents,
                     **/ItMiiAuxiliaryImage,
@@ -497,7 +487,6 @@
             <id>toolkits-srg</id>
             <properties>
                 <skipITs>false</skipITs>
-                <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
                 <includes-failsafe>
                     **/ItMultiDomainModels,
                     **/ItMiiUpdateDomainConfig,

pom.xml

@@ -353,7 +353,6 @@
       <id>integration-tests</id>
       <properties>
         <src-integration-test>${project.basedir}/src/integration-test/java</src-integration-test>
-        <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
       </properties>
       <build>
         <plugins>
@@ -630,7 +629,7 @@
     <htmlunit-version>2.59.0</htmlunit-version>
     <aggregate.report.dir>buildtime-reports/target/site/jacoco-aggregate/jacoco.xml</aggregate.report.dir>
     <checkstyle.config.location>${root.basedir}/build-tools/checkstyle/customized_google_checks.xml</checkstyle.config.location>
-    <wko.it.skip.enforcer.rules>false</wko.it.skip.enforcer.rules>
+    <no-reports>false</no-reports>
   </properties>
 
 </project>