minor code cleanup and unit tests

Author: alai8

operator/src/main/java/oracle/kubernetes/operator/helpers/JobStepContext.java

@@ -241,7 +241,6 @@ private V1Container createContainer(TuningParameters tuningParameters) {
             .imagePullPolicy(getImagePullPolicy())
             .command(getContainerCommand())
             .env(getEnvironmentVariables(tuningParameters))
-            //           .addVolumeMountsItem(volumeMount(STORAGE_VOLUME, STORAGE_MOUNT_PATH))
             .addVolumeMountsItem(readOnlyVolumeMount(SECRETS_VOLUME, SECRETS_MOUNT_PATH))
             .addVolumeMountsItem(readOnlyVolumeMount(SCRIPTS_VOLUME, SCRIPTS_MOUNTS_PATH));
 

operator/src/main/java/oracle/kubernetes/operator/helpers/PodStepContext.java

@@ -637,7 +637,6 @@ private V1Container createContainer(TuningParameters tuningParameters) {
             .env(getEnvironmentVariables(tuningParameters))
             .addPortsItem(new V1ContainerPort().containerPort(getPort()).protocol("TCP"))
             .lifecycle(createLifecycle())
-            //            .addVolumeMountsItem(volumeMount(STORAGE_VOLUME, STORAGE_MOUNT_PATH))
             .addVolumeMountsItem(readOnlyVolumeMount(SECRETS_VOLUME, SECRETS_MOUNT_PATH))
             .addVolumeMountsItem(readOnlyVolumeMount(SCRIPTS_VOLUME, SCRIPTS_MOUNTS_PATH))
             .addVolumeMountsItem(readOnlyVolumeMount(DEBUG_CM_VOLUME, DEBUG_CM_MOUNTS_PATH))

operator/src/test/java/oracle/kubernetes/operator/helpers/DomainIntrospectorJobTest.java

@@ -225,8 +225,12 @@ public void whenJobCreated_specHasOneContainer() {
     assertThat(getCreatedJob().getSpec().getTemplate().getSpec().getContainers(), hasSize(1));
   }
 
-  // @Test
+  @Test
   public void whenJobCreated_containerHasExpectedVolumeMounts() {
+    domainPresenceInfo
+        .getClaims()
+        .addItemsItem(
+            new V1PersistentVolumeClaim().metadata(new V1ObjectMeta().name("claim-name")));
     assertThat(
         getCreatedJobSpecContainer().getVolumeMounts(),
         containsInAnyOrder(
@@ -238,6 +242,19 @@ public void whenJobCreated_containerHasExpectedVolumeMounts() {
             readOnlyVolumeMount(OVERRIDE_SECRET_2 + "-volume", OVERRIDE_SECRETS_MOUNT_PATH)));
   }
 
+  @Test
+  public void whenJobCreated_withNoPVC_containerHasExpectedVolumeMounts() {
+    domainPresenceInfo.getClaims().getItems().clear();
+    assertThat(
+        getCreatedJobSpecContainer().getVolumeMounts(),
+        containsInAnyOrder(
+            readOnlyVolumeMount(SECRETS_VOLUME, SECRETS_MOUNT_PATH),
+            readOnlyVolumeMount(SCRIPTS_VOLUME, SCRIPTS_MOUNTS_PATH),
+            readOnlyVolumeMount(OVERRIDES_CM + "-volume", OVERRIDES_CM_MOUNT_PATH),
+            readOnlyVolumeMount(OVERRIDE_SECRET_1 + "-volume", OVERRIDE_SECRETS_MOUNT_PATH),
+            readOnlyVolumeMount(OVERRIDE_SECRET_2 + "-volume", OVERRIDE_SECRETS_MOUNT_PATH)));
+  }
+
   @SuppressWarnings("unchecked")
   @Test
   public void whenJobCreated_hasPredefinedEnvVariables() {

operator/src/test/java/oracle/kubernetes/operator/helpers/PodHelperTestBase.java

@@ -273,6 +273,19 @@ public void whenPodCreated_containerHasExpectedVolumeMounts() {
             readOnlyVolumeMount("weblogic-domain-cm-volume", "/weblogic-operator/scripts")));
   }
 
+  @Test
+  public void whenPodCreated_withNoPVC_containerHasExpectedVolumeMounts() {
+    domainPresenceInfo.getClaims().getItems().clear();
+    assertThat(
+        getCreatedPodSpecContainer().getVolumeMounts(),
+        containsInAnyOrder(
+            writableVolumeMount(
+                UID + SIT_CONFIG_MAP_VOLUME_SUFFIX, "/weblogic-operator/introspector"),
+            readOnlyVolumeMount("weblogic-credentials-volume", "/weblogic-operator/secrets"),
+            readOnlyVolumeMount("weblogic-domain-debug-cm-volume", "/weblogic-operator/debug"),
+            readOnlyVolumeMount("weblogic-domain-cm-volume", "/weblogic-operator/scripts")));
+  }
+
   @Test
   public void whenPodCreated_lifecyclePreStopHasStopServerCommand() {
     assertThat(