Skip to content

Commit ba65286

Browse files
markxnelsonrjeberhard
authored andcommitted
updates from review
1 parent b69ef2f commit ba65286

File tree

10 files changed

+15
-12
lines changed

10 files changed

+15
-12
lines changed

docs-source/content/userguide/cicd/_index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
title: "CI/CD"
2+
title: "CI/CD considerations"
33
date: 2019-04-11T13:01:55-04:00
44
weight: 5
55
description: "Learn about managing domain images with CI/CD."

docs-source/content/userguide/cicd/choose-an-approach.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ various approaches. We can start by asking ourselves questions like these:
1313
- *Can you make the desired change with a configuration override?*
1414
The WebLogic Kubernetes Operator allows you to inject a number of [configuration
1515
overrides]({{< relref "/userguide/managing-domains/configoverrides/_index.md" >}})
16-
into your pods at startup time. This allows you to use the same image for multiple
16+
into your pods before starting any servers in the domain. This allows you to use
17+
the same image for multiple
1718
different configurations. A good example would be changing the settings for a data
1819
source, for example. You may wish to have a larger connection pool in your production
1920
environment than you do in your development/test environments. You probably also
@@ -29,7 +30,7 @@ various approaches. We can start by asking ourselves questions like these:
2930
If your changes fit into this category, and you have used the "domain-in-image"
3031
approach and the Docker layering model, then you only need to update the top layer
3132
of your image. This is relatively easy compared to making changes in lower layers.
32-
You could create a new layer with the changes, or your could rebuild/replace the
33+
You could create a new layer with the changes, or you could rebuild/replace the
3334
existing top layer with a new one. Which approach you choose depends mainly on
3435
whether you need to maintain the same domain encryption keys or not.
3536
- *Do you need to be able to do a rolling restart?*

docs-source/content/userguide/cicd/how-to-copy-domains.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,22 +13,25 @@ the same location (Domain Home) in the (new) file system. Using this
1313
approach will maintain the same domain encryption key.
1414

1515
The best practice/recommended approach is to create a "primordial domain"
16-
(as described previously) which does not contain any applications or resources,
16+
which does not contain any applications or resources,
1717
and to create a ZIP file of this domain before starting any servers.
1818

19-
2019
> The domain ZIP must be created before starting servers.
2120
2221
When servers are started the first time, they will encrypt various other data.
2322
Make sure you create the ZIP file before starting servers for the first time.
2423
The primordial domain ZIP file should be stored in a safe place where the CI/CD
2524
can get it when needed, for example in a secured Artifactory repository (or
26-
something similar). Remember, anyone who gets access to this ZIP file can get access
25+
something similar).
26+
27+
{{% notice warning %}}
28+
Remember, anyone who gets access to this ZIP file can get access
2729
to the domain encryption key, so it needs to be protected appropriately.
30+
{{% /notice %}}
2831

2932
Every time you run your CI/CD pipeline to create a new mutation of the domain,
3033
it should retrieve and unzip the primordial domain first, and then apply changes
31-
to that domain using tools like WDT or WLST (see below).
34+
to that domain using tools like WDT or WLST (see [here]({{< relref "/userguide/cicd/tools.md" >}})).
3235

3336

3437
> Always use external state.

docs-source/content/userguide/cicd/why-layering-matters.md

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,10 @@ small, then we will just end up with another small layer, and as we have seen,
3333
the small layers are no problem.
3434

3535
But consider a more complicated scenario - let's take updating the JDK as an example
36-
to understand the impact of layers. Say we want to update from JDK 11.0.2 to 11.0.4
37-
as shown in the example above - this is just an example, WebLogic 12.2.1.3 does not
38-
support JDK 11! If we took the "your first domain" image and updated
39-
the JDK, then we would end up with a new layer on top containing JDK 11.0.4. That
40-
other layer with JDK 11.0.2 is still there; even if we "delete" the directory, we
36+
to understand the impact of layers. Say we want to update from JDK 8u201 to 8u202
37+
as shown in the example above. If we took the "your first domain" image and updated
38+
the JDK, then we would end up with a new layer on top containing JDK 8u202. That
39+
other layer with JDK 8u201 is still there; even if we "delete" the directory, we
4140
don't get that space back. So now our 1.5GB "image" has grown to 1.75GB. This is
4241
not ideal, and the more often we try to change lower layers, the worse it gets.
4342

11 KB
Loading

docs-source/static/images/layers.png

2.82 KB
Loading
-175 Bytes
Loading
-235 Bytes
Loading

docs-source/static/images/rebuild.png

-331 Bytes
Loading

docs-source/static/images/updates.png

-263 Bytes
Loading

0 commit comments

Comments
 (0)