Add tests for most of the create domain input parameter validation, change the name of the vars to pass the script names to the internal scripts so they don't collide w/ input param names, add a few missing create domain input paramter validations that the tests found

Author: moreaut

kubernetes/create-weblogic-domain.sh

@@ -23,7 +23,7 @@ internalDir="${scriptDir}/internal"
 # kubernetes.
 
 # pass the name of this script to the internal create script
-createDomainScript="${script}"
+createScript="${script}"
 
 # try to execute kubectl to see whether kubectl is available
 function validateKubectlAvailable {

kubernetes/create-weblogic-operator.sh

@@ -11,7 +11,7 @@ internalDir="${scriptDir}/internal"
 # keytool, openssl, kubectl and kubernetes.
 
 # pass the name of this script to the internal create script
-createOperatorScript="${script}"
+createScript="${script}"
 
 # pass the location of the default operator inputs yaml file to the internal create script
 defaultOperatorInputsFile="${scriptDir}/create-weblogic-operator-inputs.yaml"

kubernetes/internal/create-weblogic-domain.sh

@@ -27,7 +27,7 @@
 #  - a unit testing script that only the tests call.  it implements the abstracted behavior by mocking it out
 #
 # The caller of this script must define:
-#   createDomainScript shell variable that has the full pathname of the script calling this script
+#   createScript shell variable that has the full pathname of the script calling this script
 #   validateKubectlAvailable shell function that validates whether kubectl is available
 #   validateThatSecretExists shell function that validates whether a secret has been registered with kubernetes
 #
@@ -45,7 +45,7 @@ scriptDir="$( cd "$( dirname "${script}" )" && pwd )"
 source ${scriptDir}/utility.sh
 
 function usage {
-  echo usage: ${createDomainScript} -o dir -i file [-g] [-h]
+  echo usage: ${createScript} -o dir -i file [-g] [-h]
   echo "  -o Ouput directory for the generated yaml files, must be specified."
   echo "  -i Parameter input file, must be specified."
   echo "  -g Only generate the files to create the domain, do not execute them"
@@ -110,6 +110,13 @@ function validateDomainUid {
   validateLowerCase "domainUid" ${domainUid}
 }
 
+#
+# Function to ensure the namespace is lowercase
+#
+function validateNamespace {
+  validateLowerCase "namespace" ${namespace}
+}
+
 #
 # Create an instance of clusterName to be used in cases where lowercase is required.
 #
@@ -208,7 +215,7 @@ function validateDomainSecret {
 #
 function validateImagePullSecretName {
   if [ ! -z ${imagePullSecretName} ]; then
-    validateLowerCase "validateImagePullSecretName" ${imagePullSecretName}
+    validateLowerCase imagePullSecretName ${imagePullSecretName}
     imagePullSecretPrefix=""
     if [ "${generateOnly}" = false ]; then
       validateImagePullSecret
@@ -333,7 +340,8 @@ function initialize {
     namespace \
     loadBalancer \
     javaOptions \
-    startupControl
+    startupControl \
+    t3PublicAddress
 
   validateIntegerInputParamsSpecified \
     adminPort \
@@ -351,6 +359,7 @@ function initialize {
     exposeAdminNodePort
 
   validateDomainUid
+  validateNamespace
   validateClusterName
   validateStorageClass
   validatePersistenVolumeName

kubernetes/internal/create-weblogic-operator.sh

@@ -18,7 +18,7 @@
 #  - a unit testing script that only the tests call.  it implements the abstracted behavior by mocking it out
 #
 # The caller of this script must define:
-#   createOperatorScript shell variable that has the full pathname of the script calling this script
+#   createScript shell variable that has the full pathname of the script calling this script
 #   defaultOperatorInputsFile shell variable that has the full pathname to kubernetes/create-weblogic-operator-inputs.yaml
 #   genOprCertScript shell variable that has the full pathname of the script to use to generate certificates
 #   validateKubectlAvailable shell function that validates whether kubectl is available
@@ -38,7 +38,7 @@ scriptDir="$( cd "$( dirname "${script}" )" && pwd )"
 source ${scriptDir}/utility.sh
 
 function usage {
-  echo usage: ${createOperatorScript} -o dir [-i file] [-g] [-h]
+  echo usage: ${createScript} -o dir [-i file] [-g] [-h]
   echo "  -o Ouput directory for the generated yaml files, must be specified."
   echo "  -i Parameter input file, defaults to kubernetes/create-weblogic-operator-inputs.yaml"
   echo "  -g Only generate the files to create the operator, do not execute them"
@@ -162,7 +162,7 @@ function initAndValidateOutputDir {
 #
 function validateImagePullSecretName {
   if [ ! -z ${imagePullSecretName} ]; then
-    validateLowerCase "imagePullSecretName" ${imagePullSecretName}
+    validateLowerCase imagePullSecretName ${imagePullSecretName}
     imagePullSecretPrefix=""
     validateImagePullSecret
   else