Skip to content

Commit c190e72

Browse files
committed
Switch traefik to use the domainUID and clusterName labels instead of the app label
1 parent a77bedc commit c190e72

File tree

2 files changed

+16
-18
lines changed

2 files changed

+16
-18
lines changed

kubernetes/internal/weblogic-domain-traefik-template.yaml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -18,19 +18,18 @@ metadata:
1818
weblogic.domainUID: %DOMAIN_UID%
1919
weblogic.domainName: %DOMAIN_NAME%
2020
weblogic.clusterName: %CLUSTER_NAME%
21-
app: %DOMAIN_UID%-%CLUSTER_NAME_LC%-traefik
2221
spec:
2322
replicas: 1
2423
selector:
2524
matchLabels:
26-
app: %DOMAIN_UID%-%CLUSTER_NAME_LC%-traefik
25+
weblogic.domainUID: %DOMAIN_UID%
26+
weblogic.clusterName: %CLUSTER_NAME%
2727
template:
2828
metadata:
2929
labels:
3030
weblogic.domainUID: %DOMAIN_UID%
3131
weblogic.domainName: %DOMAIN_NAME%
3232
weblogic.clusterName: %CLUSTER_NAME%
33-
app: %DOMAIN_UID%-%CLUSTER_NAME_LC%-traefik
3433
spec:
3534
serviceAccountName: %DOMAIN_UID%-%CLUSTER_NAME_LC%-traefik
3635
terminationGracePeriodSeconds: 60
@@ -86,7 +85,6 @@ metadata:
8685
weblogic.domainUID: %DOMAIN_UID%
8786
weblogic.domainName: %DOMAIN_NAME%
8887
weblogic.clusterName: %CLUSTER_NAME%
89-
app: %DOMAIN_UID%-%CLUSTER_NAME_LC%-traefik
9088
data:
9189
traefik.toml: |
9290
# traefik.toml
@@ -112,7 +110,8 @@ metadata:
112110
weblogic.clusterName: %CLUSTER_NAME%
113111
spec:
114112
selector:
115-
app: %DOMAIN_UID%-%CLUSTER_NAME_LC%-traefik
113+
weblogic.domainUID: %DOMAIN_UID%
114+
weblogic.clusterName: %CLUSTER_NAME%
116115
ports:
117116
- port: 80
118117
name: http
@@ -129,10 +128,10 @@ metadata:
129128
weblogic.domainUID: %DOMAIN_UID%
130129
weblogic.domainName: %DOMAIN_NAME%
131130
weblogic.clusterName: %CLUSTER_NAME%
132-
app: %DOMAIN_UID%-%CLUSTER_NAME_LC%-traefik
133131
spec:
134132
selector:
135-
app: %DOMAIN_UID%-%CLUSTER_NAME_LC%-traefik
133+
weblogic.domainUID: %DOMAIN_UID%
134+
weblogic.clusterName: %CLUSTER_NAME%
136135
ports:
137136
- port: 8080
138137
name: dash

operator/src/test/java/oracle/kubernetes/operator/create/CreateDomainGeneratedFilesBaseTest.java

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -438,18 +438,17 @@ protected ExtensionsV1beta1Deployment getExpectedTraefikDeployment() {
438438
.namespace(getInputs().getNamespace())
439439
.putLabelsItem(DOMAINUID_LABEL, getInputs().getDomainUID())
440440
.putLabelsItem(DOMAINNAME_LABEL, getInputs().getDomainName())
441-
.putLabelsItem(CLUSTERNAME_LABEL, getInputs().getClusterName())
442-
.putLabelsItem(APP_LABEL, getTraefikScope()))
441+
.putLabelsItem(CLUSTERNAME_LABEL, getInputs().getClusterName()))
443442
.spec(newDeploymentSpec()
444443
.replicas(1)
445444
.selector(newLabelSelector()
446-
.putMatchLabelsItem(APP_LABEL, getTraefikScope()))
445+
.putMatchLabelsItem(DOMAINUID_LABEL, getInputs().getDomainUID())
446+
.putMatchLabelsItem(CLUSTERNAME_LABEL, getInputs().getClusterName()))
447447
.template(newPodTemplateSpec()
448448
.metadata(newObjectMeta()
449449
.putLabelsItem(DOMAINUID_LABEL, getInputs().getDomainUID())
450450
.putLabelsItem(DOMAINNAME_LABEL, getInputs().getDomainName())
451-
.putLabelsItem(CLUSTERNAME_LABEL, getInputs().getClusterName())
452-
.putLabelsItem(APP_LABEL, getTraefikScope()))
451+
.putLabelsItem(CLUSTERNAME_LABEL, getInputs().getClusterName()))
453452
.spec(newPodSpec()
454453
.serviceAccountName(getTraefikScope())
455454
.terminationGracePeriodSeconds(60L)
@@ -524,8 +523,7 @@ protected V1ConfigMap getExpectedTraefikConfigMap() {
524523
.namespace(getInputs().getNamespace())
525524
.putLabelsItem(DOMAINUID_LABEL, getInputs().getDomainUID())
526525
.putLabelsItem(DOMAINNAME_LABEL, getInputs().getDomainName())
527-
.putLabelsItem(CLUSTERNAME_LABEL, getInputs().getClusterName())
528-
.putLabelsItem(APP_LABEL, getTraefikScope()))
526+
.putLabelsItem(CLUSTERNAME_LABEL, getInputs().getClusterName()))
529527
.putDataItem(PROPERTY_TRAEFIK_TOML, "");
530528
}
531529

@@ -557,7 +555,8 @@ protected V1Service getExpectedTraefikService() {
557555
.putLabelsItem(CLUSTERNAME_LABEL, getInputs().getClusterName()))
558556
.spec(newServiceSpec()
559557
.type("NodePort")
560-
.putSelectorItem(APP_LABEL, getTraefikScope())
558+
.putSelectorItem(DOMAINUID_LABEL, getInputs().getDomainUID())
559+
.putSelectorItem(CLUSTERNAME_LABEL, getInputs().getClusterName())
561560
.addPortsItem(newServicePort()
562561
.name("http")
563562
.targetPort(newIntOrString("http"))
@@ -584,11 +583,11 @@ protected V1Service getExpectedTraefikDashboardService() {
584583
.namespace(getInputs().getNamespace())
585584
.putLabelsItem(DOMAINUID_LABEL, getInputs().getDomainUID())
586585
.putLabelsItem(DOMAINNAME_LABEL, getInputs().getDomainName())
587-
.putLabelsItem(CLUSTERNAME_LABEL, getInputs().getClusterName())
588-
.putLabelsItem(APP_LABEL, getTraefikScope()))
586+
.putLabelsItem(CLUSTERNAME_LABEL, getInputs().getClusterName()))
589587
.spec(newServiceSpec()
590588
.type("NodePort")
591-
.putSelectorItem(APP_LABEL, getTraefikScope())
589+
.putSelectorItem(DOMAINUID_LABEL, getInputs().getDomainUID())
590+
.putSelectorItem(CLUSTERNAME_LABEL, getInputs().getClusterName())
592591
.addPortsItem(newServicePort()
593592
.name("dash")
594593
.targetPort(newIntOrString("dash"))

0 commit comments

Comments
 (0)