updates from review comments

Author: markxnelson

docs-source/content/release-notes.md

@@ -8,7 +8,7 @@ draft: false
 
 | Date | Version | Introduces backward incompatibilities | Change |
 | --- | --- | --- | --- |
-| TBD | v2.2 | no  | Add support for FMW Infrastructure domains. If servers are manually shutdown, for example using the console, the operator will return them to the desired state specified in the domain custom resource.  Operator is now built and runs on JDK 11. 
+| TBD | v2.2 | no  | Added support for FMW Infrastructure domains. If servers are manually shutdown, for example using the WLS Console, the operator will return them to the desired state specified in the domain custom resource.  Operator is now built and runs on JDK 11. 
 | April 4, 2019 | v2.1 | no  | Customers can add init and sidecar containers to generated pods.  
 | March 4, 2019 | v2.0.1 | no  | OpenShift support is now certified.  Many bug fixes, including fixes for configuration overrides, cluster services, and domain status processing.  
 | January 24, 2019 | v2.0 | yes; not compatible with 1.x releases, but is compatible with 2.0-rc2. | Final version numbers and documentation updates.  

docs-source/content/samples/simple/domains/fmw-domain/_index.md

@@ -115,24 +115,24 @@ The following parameters can be provided in the inputs file.
 | `exposeAdminT3Channel` | Boolean indicating if the T3 administrative channel is exposed outside the Kubernetes cluster. | `false` |
 | `image` | WebLogic Docker image. The operator requires FMW Infrastructure 12.2.1.3.0 with patch 29135930 applied. Refer to [FMW Infrastructure domains]({{< relref "/userguide/managing-domains/fmw-infra/_index.md" >}}) for details on how to obtain or create the image. | `oracle/fmw-infrastructure:12.2.1.3` |
 | `imagePullPolicy` | WebLogic Docker image pull policy. Legal values are `IfNotPresent`, `Always`, or `Never` | `IfNotPresent` |
-| `imagePullSecretName` | Name of the Kubernetes secret to access the Docker Store to pull the WebLogic Server Docker image. The presence of the secret will be validated when this parameter is specified |  |
+| `imagePullSecretName` | Name of the Kubernetes secret to access the Docker Store to pull the WebLogic Server Docker image. The presence of the secret will be validated when this parameter is specified. |  |
 | `includeServerOutInPodLog` | Boolean indicating whether to include the server .out to the pod's stdout. | `true` |
 | `initialManagedServerReplicas` | Number of Managed Servers to initially start for the domain. | `2` |
 | `javaOptions` | Java options for starting the Administration and Managed Servers. A Java option can have references to one or more of the following pre-defined variables to obtain WebLogic domain information: `$(DOMAIN_NAME)`, `$(DOMAIN_HOME)`, `$(ADMIN_NAME)`, `$(ADMIN_PORT)`, and `$(SERVER_NAME)`. | `-Dweblogic.StdoutDebugEnabled=false` |
 | `logHome` | The in-pod location for domain log, server logs, server out, and Node Manager log files. If not specified, the value is derived from the `domainUID` as `/shared/logs/<domainUID>`. | `/shared/logs/domain1` |
 | `managedServerNameBase` | Base string used to generate Managed Server names. | `managed-server` |
 | `managedServerPort` | Port number for each Managed Server. | `8001` |
 | `namespace` | Kubernetes namespace in which to create the domain. | `default` |
-| `persistentVolumeClaimName` | Name of the persistent volume claim. If not specified, the value is derived from the `domainUID` as `<domainUID>-weblogic-sample-pvc` | `domain1-weblogic-sample-pvc` |
+| `persistentVolumeClaimName` | Name of the persistent volume claim. If not specified, the value is derived from the `domainUID` as `<domainUID>-weblogic-sample-pvc`. | `domain1-weblogic-sample-pvc` |
 | `productionModeEnabled` | Boolean indicating if production mode is enabled for the domain. | `true` |
 | `serverStartPolicy` | Determines which WebLogic Servers will be started up. Legal values are `NEVER`, `IF_NEEDED`, `ADMIN_ONLY`. | `IF_NEEDED` |
 | `t3ChannelPort` | Port for the T3 channel of the NetworkAccessPoint. | `30012` |
 | `t3PublicAddress` | Public address for the T3 channel.  This should be set to the public address of the Kubernetes cluster.  This would normally be a load balancer address. <p/>For development environments only: In a single server (all-in-one) Kubernetes deployment, this may be set to the address of the master, or at the very least, it must be set to the address of one of the worker nodes. | If not provided, the script will attempt to set it to the IP address of the Kubernetes cluster |
-| `weblogicCredentialsSecretName` | Name of the Kubernetes secret for the Administration Server's user name and password. If not specified, the value is derived from the `domainUID` as `<domainUID>-weblogic-credentials`. | `domain1-weblogic-credentials` |
+| `weblogicCredentialsSecretName` | Name of the Kubernetes secret for the Administration Server's user name and password. If not specified, then the value is derived from the `domainUID` as `<domainUID>-weblogic-credentials`. | `domain1-weblogic-credentials` |
 | `weblogicImagePullSecretName` | Name of the Kubernetes secret for the Docker Store, used to pull the WebLogic Server image. | `docker-store-secret` |
 | `rcuSchemaPrefix` | The schema prefix to use in the database, for example `SOA1`.  You may wish to make this the same as the domainUID in order to simplify matching domains to their RCU schemas. | `domain1` |
 | `rcuDatabaseURL` | The database URL. | `database:1521/service` |
-| `rcuCredentialsSecret` | The kubernetes secret containing the database credentials. | `domain1-rcu-credentials` |
+| `rcuCredentialsSecret` | The Kubernetes secret containing the database credentials. | `domain1-rcu-credentials` |
 
 Note that the names of the Kubernetes resources in the generated YAML files may be formed with the 
 value of some of the properties specified in the `create-inputs.yaml` file. Those properties include 

docs-source/content/userguide/managing-domains/fmw-infra/_index.md

@@ -64,7 +64,7 @@ to use this image with the operator.  A [sample](https://github.com/oracle/docke
 is provided that demonstrates how to create a Docker image with the necessary patch installed.
 
 After downloading the patch from My Oracle Support, you can create the patched image
-buy running the provided script:
+by running the provided script:
 
 TODO TODO TODO check with monica's sample to ensure this is correct TODO TODO TODO
 
@@ -76,7 +76,7 @@ cd docker-images/OracleFMWInfrastructure/samples/12213-patch-fmw-for-k8s
 This will produce an image named `TODO TODO TODO monica what is it called TODO TODO TODO`.
 
 These sample will allow you to create a Docker image containing the FMW Infrastructure
-binaries and the necessary patch.  You can use this image to run Repository Creation Utility
+binaries and the necessary patch.  You can use this image to run the Repository Creation Utility
 and to run your domain using the "domain on a persistent volume" model. If you want to use 
 the "domain in a Docker image" model, you will need to go one step further and add another
 layer with your domain in it.  You can use WLST or WDT to create your domain.
@@ -257,7 +257,7 @@ kubectl run rcu -ti --image oracle/fmw-infrastructure:12.2.1.3 -- sleep 100000
 
 This will create a Kubernetes deployment called `rcu` containing a pod running a container
 created from the `oracle/fmw-infrastructure:12.2.1.3` image which will just run
-`sleep 100000`, which essentially creates us a pod that we can "exec" into and use to run whatever
+`sleep 100000`, which essentially creates a pod that we can "exec" into and use to run whatever
 commands we need to run. 
 
 To get inside this container and run commands, use this command: 
@@ -279,7 +279,7 @@ like WLST.
 
 ##### Creating schemas
 
-Inside this pod, you can use the following command to run RCU in command line (no GUI) mode
+Inside this pod, you can use the following command to run RCU in command-line (no GUI) mode
 to create your FMW schemas.  You will need to provide the right prefix and connect string.
 You will be prompted to enter the password for the `sys` user, and then the password to use
 for the regular schema users:

kubernetes/samples/scripts/create-fmw-infrastructure-domain/create-domain-inputs.yaml

@@ -41,8 +41,8 @@ managedServerPort: 8001
 # The operator requires WebLogic Server 12.2.1.3.0 with patch 29135930 applied.
 # The existing WebLogic Docker image, `store/oracle/weblogic:12.2.1.3`, was updated on January 17, 2019,
 # and has all the necessary patches applied; a `docker pull` is required if you already have this image.
-# Refer to [WebLogic Docker images](../../../../../site/weblogic-docker-images.md) for details on how
-# to obtain or create the image.
+# Refer to https://oracle.github.io/weblogic-kubernetes-operator/userguide/managing-domains/fmw-infra/
+# for details on how to obtain or create the image.
 image: oracle/fmw-infrastructure:12.2.1.3
 
 # Image pull policy

kubernetes/samples/scripts/create-rcu-credentials/README.md

@@ -33,28 +33,23 @@ The parameters are as follows:
 
 This creates a `generic` secret containing the user name and password as literal values.
 
-You can check the secret with the `kubectl get secret` command.  An example is shown below,
+You can check the secret with the `kubectl describe secret` command.  An example is shown below,
 including the output:
 
 ```
-$ kubectl -n domain-namespace-1 get secret domain1-rcu-credentials -o yaml
-apiVersion: v1
-data:
-  password: d2VsY29tZTE=
-  username: d2VibG9naWM=
-  sys_username: c3lz
-  username: c29hMQ==
-kind: Secret
-metadata:
-  creationTimestamp: 2018-12-12T20:25:20Z
-  labels:
-    weblogic.domainName: domain1
-    weblogic.domainUID: domain1
-  name: domain1-rcu-credentials
-  namespace: domain-namespace-1
-  resourceVersion: "5680"
-  selfLink: /api/v1/namespaces/domain-namespace-1/secrets/domain1-weblogic-credentials
-  uid: 0c2b3510-fe4c-11e8-994d-00001700101d
-type: Opaque
-
+$ kubectl -n domain-namespace-1 describe secret domain1-rcu-credentials -o yaml
+Name:         domain1-rcu-credentials
+Namespace:    default
+Labels:       weblogic.domainName=domain1
+              weblogic.domainUID=domain1
+Annotations:  <none>
+
+Type:  Opaque
+
+Data
+====
+password:      12 bytes
+sys_password:  12 bytes
+sys_username:  3 bytes
+username:      4 bytes
 ```

kubernetes/samples/scripts/create-rcu-credentials/create-rcu-credentials.sh

@@ -3,7 +3,7 @@
 # Licensed under the Universal Permissive License v 1.0 as shown at http://oss.oracle.com/licenses/upl.
 #
 # Description
-#  This sample script creates a Kubernetes secret for WebLogic domain admin credentials.
+#  This sample script creates a Kubernetes secret for RCU credentials.
 #
 #  The following pre-requisites must be handled prior to running this script:
 #    * The kubernetes namespace must already be created