getConfigutedEnvVars should return copies of V1EnvVars

Author: alai8

operator/src/main/java/oracle/kubernetes/operator/helpers/JobHelper.java

@@ -11,7 +11,6 @@
 import io.kubernetes.client.models.V1PodList;
 import io.kubernetes.client.models.V1Volume;
 import io.kubernetes.client.models.V1VolumeMount;
-import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
 import java.util.concurrent.atomic.AtomicBoolean;
@@ -98,7 +97,7 @@ protected List<V1VolumeMount> getAdditionalVolumeMounts() {
     List<V1EnvVar> getConfiguredEnvVars(TuningParameters tuningParameters) {
       // Pod for introspector job would use same environment variables as for admin server
       List<V1EnvVar> vars =
-          new ArrayList<>(getDomain().getAdminServerSpec().getEnvironmentVariables());
+          PodHelper.createCopy(getDomain().getAdminServerSpec().getEnvironmentVariables());
 
       addEnvVar(vars, "NAMESPACE", getNamespace());
       addEnvVar(vars, "DOMAIN_UID", getDomainUID());

operator/src/main/java/oracle/kubernetes/operator/helpers/PodHelper.java

@@ -116,7 +116,7 @@ protected V1PodSpec createSpec(TuningParameters tuningParameters) {
 
     @Override
     List<V1EnvVar> getConfiguredEnvVars(TuningParameters tuningParameters) {
-      List<V1EnvVar> vars = new ArrayList<>(getServerSpec().getEnvironmentVariables());
+      List<V1EnvVar> vars = createCopy(getServerSpec().getEnvironmentVariables());
       overrideContainerWeblogicEnvVars(vars);
       return vars;
     }
@@ -288,7 +288,7 @@ protected List<String> getContainerCommand() {
     @Override
     @SuppressWarnings("unchecked")
     List<V1EnvVar> getConfiguredEnvVars(TuningParameters tuningParameters) {
-      List<V1EnvVar> envVars = (List<V1EnvVar>) packet.get(ProcessingConstants.ENVVARS);
+      List<V1EnvVar> envVars = createCopy((List<V1EnvVar>) packet.get(ProcessingConstants.ENVVARS));
 
       List<V1EnvVar> vars = new ArrayList<>();
       if (envVars != null) {
@@ -355,4 +355,14 @@ private Step deletePod(String name, String namespace, Step next) {
           .deletePodAsync(name, namespace, deleteOptions, new DefaultResponseStep<>(next));
     }
   }
+
+  public static List<V1EnvVar> createCopy(List<V1EnvVar> envVars) {
+    ArrayList<V1EnvVar> copy = new ArrayList<>();
+    if (envVars != null) {
+      for (V1EnvVar envVar : envVars) {
+        copy.add(new V1EnvVar().name(envVar.getName()).value(envVar.getValue()));
+      }
+    }
+    return copy;
+  }
 }