Skip to content

Commit ddf7a05

Browse files
authored
Avoid docker pull for logstash,kibana,fluentd images (#3941)
* Avoid docker pull for logstash, kibana, fluentd * Use TEST_IMAGES_REPO instead of the hard-coded registry name
1 parent 7447a10 commit ddf7a05

File tree

4 files changed

+17
-10
lines changed

4 files changed

+17
-10
lines changed

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItElasticLoggingFluentd.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) 2020, 2022, Oracle and/or its affiliates.
1+
// Copyright (c) 2020, 2023, Oracle and/or its affiliates.
22
// Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
33

44
package oracle.weblogic.kubernetes;
@@ -382,6 +382,7 @@ private static void createDomainCrAndVerify(String adminSecretName,
382382
final String volumeName = "weblogic-domain-storage-volume";
383383
final String logHomeRootPath = "/scratch";
384384
// create the domain CR
385+
logger.info("Choosen FLUENTD_IMAGE {0}", FLUENTD_IMAGE);
385386
String imagePullPolicy = "IfNotPresent";
386387
FluentdSpecification fluentdSpecification = new FluentdSpecification();
387388
fluentdSpecification.setImage(FLUENTD_IMAGE);

integration-tests/src/test/java/oracle/weblogic/kubernetes/TestConstants.java

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public interface TestConstants {
123123
public static final String DB_IMAGE_TAG = getNonEmptySystemProperty("wko.it.db.image.tag", DB_IMAGE_TAG_DEFAULT);
124124

125125
// WebLogic Base Image with Japanese Locale
126-
public static final String LOCALE_IMAGE_NAME = "phx.ocir.io/weblogick8s/test-images/weblogic";
126+
public static final String LOCALE_IMAGE_NAME = TEST_IMAGES_REPO + "/weblogick8s/test-images/weblogic";
127127
public static final String LOCALE_IMAGE_TAG = "12.2.1.4-jp";
128128

129129
// For kind, replace repo name in image name with KIND_REPO,
@@ -206,10 +206,11 @@ public interface TestConstants {
206206

207207
// ELK Stack and WebLogic logging exporter constants
208208
public static final String ELASTICSEARCH_NAME = "elasticsearch";
209-
public static final String ELASTICSEARCH_IMAGE_NAME = "phx.ocir.io/weblogick8s/test-images/docker/elasticsearch";
209+
public static final String ELASTICSEARCH_IMAGE_NAME = TEST_IMAGES_REPO
210+
+ "/weblogick8s/test-images/docker/elasticsearch";
210211
public static final String ELK_STACK_VERSION = "7.8.1";
211212
public static final String FLUENTD_IMAGE_VERSION =
212-
getNonEmptySystemProperty("wko.it.fluentd.image.version", "v1.14.5-debian-elasticsearch7-1.1");
213+
getNonEmptySystemProperty("wko.it.fluentd.image.version", "v1.14.5");
213214
public static final String ELASTICSEARCH_IMAGE = ELASTICSEARCH_IMAGE_NAME + ":" + ELK_STACK_VERSION;
214215
public static final String ELASTICSEARCH_HOST = "elasticsearch.default.svc.cluster.local";
215216
public static final int DEFAULT_LISTEN_PORT = 7100;
@@ -223,12 +224,15 @@ public interface TestConstants {
223224
public static final String WEBLOGIC_INDEX_KEY = "wls";
224225
public static final String KIBANA_INDEX_KEY = "kibana";
225226
public static final String KIBANA_NAME = "kibana";
226-
public static final String KIBANA_IMAGE = KIBANA_NAME + ":" + ELK_STACK_VERSION;
227+
public static final String KIBANA_IMAGE_NAME = TEST_IMAGES_REPO + "/weblogick8s/test-images/docker/kibana";
228+
public static final String KIBANA_IMAGE = KIBANA_IMAGE_NAME + ":" + ELK_STACK_VERSION;
227229
public static final String KIBANA_TYPE = "NodePort";
228230
public static final int KIBANA_PORT = 5601;
229231
public static final String LOGSTASH_NAME = "logstash";
230-
public static final String LOGSTASH_IMAGE = LOGSTASH_NAME + ":" + ELK_STACK_VERSION;
231-
public static final String FLUENTD_IMAGE = "fluent/fluentd-kubernetes-daemonset:" + FLUENTD_IMAGE_VERSION;
232+
public static final String LOGSTASH_IMAGE_NAME = TEST_IMAGES_REPO + "/weblogick8s/test-images/docker/logstash";
233+
public static final String LOGSTASH_IMAGE = LOGSTASH_IMAGE_NAME + ":" + ELK_STACK_VERSION;
234+
public static final String FLUENTD_IMAGE =
235+
TEST_IMAGES_REPO + "/weblogick8s/test-images/docker/fluentd-kubernetes-daemonset:" + FLUENTD_IMAGE_VERSION;
232236
public static final String JAVA_LOGGING_LEVEL_VALUE = "INFO";
233237

234238
public static final String WLS_LOGGING_EXPORTER_YAML_FILE_NAME = "WebLogicLoggingExporter.yaml";
@@ -240,7 +244,7 @@ public interface TestConstants {
240244
public static final String MII_AUXILIARY_IMAGE_NAME = DOMAIN_IMAGES_REPO + "mii-ai-image";
241245
public static final boolean SKIP_BUILD_IMAGES_IF_EXISTS =
242246
Boolean.parseBoolean(getNonEmptySystemProperty("wko.it.skip.build.images.if.exists", "false"));
243-
public static final String BUSYBOX_IMAGE = "phx.ocir.io/weblogick8s/test-images/docker/busybox";
247+
public static final String BUSYBOX_IMAGE = TEST_IMAGES_REPO + "/weblogick8s/test-images/docker/busybox";
244248
public static final String BUSYBOX_TAG = "1.34.1";
245249

246250
// Skip the mii/wdt basic image build locally if needed

integration-tests/src/test/java/oracle/weblogic/kubernetes/utils/LoggingExporterUtils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) 2021, Oracle and/or its affiliates.
1+
// Copyright (c) 2021, 2023, Oracle and/or its affiliates.
22
// Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
33

44
package oracle.weblogic.kubernetes.utils;
@@ -117,6 +117,7 @@ public static LoggingExporterParams installAndVerifyKibana(String namespace) {
117117
.loggingExporterNamespace(namespace)
118118
.kibanaContainerPort(KIBANA_PORT);
119119

120+
logger.info("Choosen KIBANA_IMAGE {0}", KIBANA_IMAGE);
120121
// install Kibana
121122
assertThat(installKibana(kibanaParams))
122123
.as("Kibana installation succeeds")

integration-tests/src/test/java/oracle/weblogic/kubernetes/utils/OperatorUtils.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright (c) 2021, 2022, Oracle and/or its affiliates.
1+
// Copyright (c) 2021, 2023, Oracle and/or its affiliates.
22
// Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl.
33

44
package oracle.weblogic.kubernetes.utils;
@@ -440,6 +440,7 @@ public static OperatorParams installAndVerifyOperator(String opNamespace,
440440
if (!createLogStashConfigMap) {
441441
opParams.createLogStashConfigMap(createLogStashConfigMap);
442442
}
443+
logger.info("Choosen LOGSTASH_IMAGE {0}", LOGSTASH_IMAGE);
443444
opParams.elkIntegrationEnabled(elkIntegrationEnabled);
444445
opParams.elasticSearchHost(elasticSearchHost);
445446
opParams.elasticSearchPort(ELASTICSEARCH_HTTP_PORT);

0 commit comments

Comments
 (0)