Skip to content

Commit dfa59d4

Browse files
doxiaorjeberhard
authored andcommitted
Address review comments
Signed-off-by: doxiao <[email protected]>
1 parent 998ef91 commit dfa59d4

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

kubernetes/samples/scripts/create-weblogic-domain/domain-home-on-pv/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ The following parameters can be provided in the inputs file.
7474
| `adminServerName` | Name of the Administration Server. | `admin-server` |
7575
| `clusterName` | Name of the WebLogic cluster instance to generate for the domain. | `cluster-1` |
7676
| `configuredManagedServerCount` | Number of Managed Server instances to generate for the domain. | `5` |
77-
| `createDomainFilesDir` | Directory on the host machine to locate all the files to create a WebLogic domain, including the script that is specified in the `createDomainScriptName` property. By default, this directory is set to the relative path `wlst`, and the create script will use the built-in WLST offline scripts in the `wlst` directory to create the WebLogic domain. It can also be set to the relative path `wdt`, and then the built-in WDT scripts will be used instead. An absolute path is also supported to point to an arbitrary directory in the file system. The built-in scripts can be replaced by the user-provided scripts or model files as long as those files are in the specified directory. Files in this directory are put into a Kubernetes config map, which in turn is mounted to the `createDomainScriptsMountPath`, so that the Kubernetes pod can use the scripts and supporting files to creates a domain home. | `wlst` |
78-
| `createDomainScriptsMountPath` | Mount path where the create domain scripts are located inside a pod. The `create-domain.sh` script creates a Kubernetes job to run the script (specified in the `createDomainScriptName` property) in a Kubernetes pod to create a domain home. Files in the `createDomainFilesDir` directory are mounted to this location in the pod, so that the Kubernetes pod can use the scripts and supporting files to creates a domain home. | `/u01/weblogic` |
79-
| `createDomainScriptName` | Script that the create domain script uses to create a WebLogic domain. The `create-domain.sh` script creates a Kubernetes job to run this script to create a domain home. The script is located in the in-pod directory that is specified in the `createDomainScriptsMountPath` property. If you need to provide your own scripts, instead of using the built-it scripts, to create the domain home, you need to set here the name of the script that you want the create domain job to run. | `create-domain-job.sh` |
77+
| `createDomainFilesDir` | Directory on the host machine to locate all the files to create a WebLogic domain, including the script that is specified in the `createDomainScriptName` property. By default, this directory is set to the relative path `wlst`, and the create script will use the built-in WLST offline scripts in the `wlst` directory to create the WebLogic domain. It can also be set to the relative path `wdt`, and then the built-in WDT scripts will be used instead. An absolute path is also supported to point to an arbitrary directory in the file system. The built-in scripts can be replaced by the user-provided scripts or model files as long as those files are in the specified directory. Files in this directory are put into a Kubernetes config map, which in turn is mounted to the `createDomainScriptsMountPath`, so that the Kubernetes pod can use the scripts and supporting files to create a domain home. | `wlst` |
78+
| `createDomainScriptsMountPath` | Mount path where the create domain scripts are located inside a pod. The `create-domain.sh` script creates a Kubernetes job to run the script (specified in the `createDomainScriptName` property) in a Kubernetes pod to create a domain home. Files in the `createDomainFilesDir` directory are mounted to this location in the pod, so that the Kubernetes pod can use the scripts and supporting files to create a domain home. | `/u01/weblogic` |
79+
| `createDomainScriptName` | Script that the create domain script uses to create a WebLogic domain. The `create-domain.sh` script creates a Kubernetes job to run this script to create a domain home. The script is located in the in-pod directory that is specified in the `createDomainScriptsMountPath` property. If you need to provide your own scripts to create the domain home, instead of using the built-it scripts, you must use this property to set the name of the script that you want the create domain job to run. | `create-domain-job.sh` |
8080
| `domainHome` | Home directory of the WebLogic domain. If not specified, the value is derived from the `domainUID` as `/shared/domains/<domainUID>`. | `/shared/domains/domain1` |
8181
| `domainPVMountPath` | Mount path of the domain persistent volume. | `/shared` |
8282
| `domainUID` | Unique ID that will be used to identify this particular domain. Used as the name of the generated WebLogic domain as well as the name of the Kubernetes domain resource. This ID must be unique across all domains in a Kubernetes cluster. This ID cannot contain any character that is not valid in a Kubernetes service name. | `domain1` |

kubernetes/samples/scripts/create-weblogic-domain/domain-home-on-pv/create-domain-inputs.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ domainPVMountPath: /shared
102102
# The `create-domain.sh` script creates a Kubernetes job to run the script (specified in the
103103
# `createDomainScriptName` property) in a Kubernetes pod to create a WebLogic home. Files
104104
# in the `createDomainFilesDir` directory are mounted to this location in the pod, so that
105-
# a Kubernetes pod can use the scripts and supporting files to creates a domain home.
105+
# a Kubernetes pod can use the scripts and supporting files to create a domain home.
106106
createDomainScriptsMountPath: /u01/weblogic
107107

108108
# Script that the create domain script uses to create a WebLogic domain
@@ -111,9 +111,9 @@ createDomainScriptsMountPath: /u01/weblogic
111111
# domain home. The script is located in the in-pod directory that is specified in the
112112
# `createDomainScriptsMountPath` property.
113113
#
114-
# If you need to provide your own scripts, instead of using the built-it scripts, to create
115-
# the domain home, you need to set here the name of the script that you want the create
116-
# domain job to run.
114+
# If you need to provide your own scripts to create the domain home, instead of using the
115+
# built-it scripts, you must use this property to set the name of the script that you want
116+
# the create domain job to run.
117117
createDomainScriptName: create-domain-job.sh
118118

119119
# Directory on the host machine to locate all the files to create a WebLogic domain
@@ -129,5 +129,5 @@ createDomainScriptName: create-domain-job.sh
129129
# The built-in scripts can be replaced by the user-provided scripts or model files as long
130130
# as those files are in the specified directory. Files in this directory are put into a
131131
# Kubernetes config map, which in turn is mounted to the `createDomainScriptsMountPath`,
132-
# so that the Kubernetes pod can use the scripts and supporting files to creates a domain home.
132+
# so that the Kubernetes pod can use the scripts and supporting files to create a domain home.
133133
createDomainFilesDir: wlst

0 commit comments

Comments
 (0)