Skip to content

Commit e50c53c

Browse files
hzhao-githubrjeberhard
authored andcommitted
OWLS-110915 - Backport the fix for the failure of testOpLogLevelSearch in ItElasticLogging to release/3.4
1 parent 0310144 commit e50c53c

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItElasticLogging.java

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.junit.jupiter.api.DisplayName;
2727
import org.junit.jupiter.api.Tag;
2828
import org.junit.jupiter.api.Test;
29-
import org.junit.jupiter.api.condition.DisabledIfEnvironmentVariable;
3029

3130
import static oracle.weblogic.kubernetes.TestConstants.COPY_WLS_LOGGING_EXPORTER_FILE_NAME;
3231
import static oracle.weblogic.kubernetes.TestConstants.ELASTICSEARCH_HTTPS_PORT;
@@ -57,7 +56,7 @@
5756
import static oracle.weblogic.kubernetes.assertions.TestAssertions.operatorIsReady;
5857
import static oracle.weblogic.kubernetes.utils.CommonMiiTestUtils.createMiiDomainAndVerify;
5958
import static oracle.weblogic.kubernetes.utils.CommonTestUtils.testUntil;
60-
import static oracle.weblogic.kubernetes.utils.CommonTestUtils.withStandardRetryPolicy;
59+
import static oracle.weblogic.kubernetes.utils.CommonTestUtils.withLongRetryPolicy;
6160
import static oracle.weblogic.kubernetes.utils.ExecCommand.exec;
6261
import static oracle.weblogic.kubernetes.utils.FileUtils.copyFileFromPodUsingK8sExec;
6362
import static oracle.weblogic.kubernetes.utils.FileUtils.searchStringInFile;
@@ -282,7 +281,7 @@ void testLogLevelSearch() {
282281
String queryCriteria = "/_count?q=level:INFO";
283282

284283
// verify log level query results
285-
withStandardRetryPolicy.untilAsserted(
284+
withLongRetryPolicy.untilAsserted(
286285
() -> assertTrue(verifyCountsHitsInSearchResults(queryCriteria, regex, LOGSTASH_INDEX_KEY, true),
287286
String.format("Query logs of level=INFO failed")));
288287

@@ -300,9 +299,12 @@ void testOperatorLogSearch() {
300299
String regex = ".*took\":(\\d+),.*hits\":\\{(.+)\\}";
301300
String queryCriteria = "/_search?q=type:weblogic-operator";
302301

303-
verifyCountsHitsInSearchResults(queryCriteria, regex, LOGSTASH_INDEX_KEY, false);
302+
// verify results of query of type:weblogic-operator in Operator log
303+
withLongRetryPolicy.untilAsserted(
304+
() -> assertTrue(verifyCountsHitsInSearchResults(queryCriteria, regex, LOGSTASH_INDEX_KEY, false),
305+
"Query Operator log info q=type:weblogic-operator failed"));
304306

305-
logger.info("Query Operator log info succeeded");
307+
logger.info("Query Operator log info q=type:weblogic-operator succeeded");
306308
}
307309

308310
/**
@@ -326,9 +328,9 @@ void testWebLogicLogSearch() {
326328
* Use Elasticsearch Search APIs to query WebLogic log info pushed to Elasticsearch repository
327329
* by WebLogic Logging Exporter. Verify that log occurrence for WebLogic servers are not empty.
328330
*/
331+
@Disabled("WlsLoggingExporter is not supported any more")
329332
@Test
330333
@DisplayName("Use Elasticsearch Search APIs to query WebLogic log info in WLS server pod and verify")
331-
@DisabledIfEnvironmentVariable(named = "OKD", matches = "true")
332334
void testWlsLoggingExporter() throws Exception {
333335
Map<String, String> wlsMap = verifyLoggingExporterReady(opNamespace, elasticSearchNs, null, WEBLOGIC_INDEX_KEY);
334336
// merge testVarMap and wlsMap
@@ -422,7 +424,7 @@ private static void createAndVerifyDomain(String miiImage) {
422424

423425
private void verifyServerRunningInSearchResults(String serverName) {
424426
String queryCriteria = "/_search?q=log:" + serverName;
425-
withStandardRetryPolicy.untilAsserted(
427+
withLongRetryPolicy.untilAsserted(
426428
() -> assertTrue(execSearchQuery(queryCriteria, LOGSTASH_INDEX_KEY).contains("RUNNING"),
427429
String.format("serverName %s is not RUNNING", serverName)));
428430

@@ -531,7 +533,7 @@ private void verifyLogstashConfigMapModifyResult(String replaceStr) {
531533
}
532534

533535
// wait for logstash config modified and verify
534-
withStandardRetryPolicy.untilAsserted(
536+
withLongRetryPolicy.untilAsserted(
535537
() -> assertTrue(copyConfigFromPodAndSearchForString(containerName, replaceStr),
536538
String.format("Failed to find search string %s", replaceStr)));
537539
}

integration-tests/src/test/java/oracle/weblogic/kubernetes/ItElasticLoggingFluentd.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import org.junit.jupiter.api.AfterAll;
4040
import org.junit.jupiter.api.BeforeAll;
4141
import org.junit.jupiter.api.DisplayName;
42-
import org.junit.jupiter.api.Tag;
4342
import org.junit.jupiter.api.Test;
4443

4544
import static oracle.weblogic.kubernetes.TestConstants.ADMIN_PASSWORD_DEFAULT;
@@ -101,7 +100,6 @@
101100
*/
102101
@DisplayName("Test to use Elasticsearch API to query WebLogic logs")
103102
@IntegrationTest
104-
@Tag("kind-parallel")
105103
class ItElasticLoggingFluentd {
106104

107105
// constants for creating domain image using model in image
@@ -171,8 +169,8 @@ public static void init(@Namespaces(3) List<String> namespaces) {
171169
// install and verify Operator
172170
installAndVerifyOperator(opNamespace, opNamespace + "-sa",
173171
false, 0, true, domainNamespace);
174-
175-
elasticSearchHost = "elasticsearch." + elasticSearchNs + ".svc.cluster.local";
172+
173+
elasticSearchHost = "elasticsearch." + elasticSearchNs + ".svc";
176174

177175
// upgrade to latest operator
178176
HelmParams upgradeHelmParams = new HelmParams()

integration-tests/src/test/java/oracle/weblogic/kubernetes/actions/impl/LoggingExporter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -518,7 +518,7 @@ private static V1Service createKibanaServiceCr(LoggingExporterParams params) {
518518

519519
private static String execLoggingExpStatusCheck(String opNamespace, String esNamespace,
520520
String labelSelector, String indexRegex) {
521-
String elasticSearchHost = "elasticsearch." + esNamespace + ".svc.cluster.local";
521+
String elasticSearchHost = "elasticsearch." + esNamespace + ".svc";
522522
StringBuffer k8sExecCmdPrefixBuff = new StringBuffer("curl http://");
523523
String cmd = k8sExecCmdPrefixBuff
524524
.append(elasticSearchHost)

0 commit comments

Comments
 (0)