Skip to content

Commit e58d45c

Browse files
authored
Merge pull request #112 from russgold/filter-unit-tests
Enable the unit tests that are currently working, independent of platforms
2 parents 80ffba9 + 7051816 commit e58d45c

File tree

7 files changed

+27
-35
lines changed

7 files changed

+27
-35
lines changed

pom.xml

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -82,35 +82,6 @@
8282
<exclude>**/*Test.java</exclude>
8383
</includes>
8484
</configuration>
85-
<executions>
86-
<execution>
87-
<id>default-test</id>
88-
<phase>test</phase>
89-
<goals>
90-
<goal>test</goal>
91-
</goals>
92-
<configuration>
93-
<skip>true</skip>
94-
</configuration>
95-
</execution>
96-
<!--
97-
<execution>
98-
<id>kubernetes-config</id>
99-
<phase>test</phase>
100-
<goals>
101-
<goal>test</goal>
102-
</goals>
103-
<configuration>
104-
<argLine>${surefireArgLine} -Xms512m -Xmx1500m</argLine>
105-
<environmentVariables>
106-
<KUBECONFIG>
107-
${project.basedir}/your.kube.config
108-
</KUBECONFIG>
109-
</environmentVariables>
110-
</configuration>
111-
</execution>
112-
-->
113-
</executions>
11485
</plugin>
11586

11687
<plugin>

src/test/java/oracle/kubernetes/custom/TestDomainListWatcher.java

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
import oracle.kubernetes.operator.helpers.ClientHelper;
1515
import oracle.kubernetes.operator.helpers.ClientHolder;
1616
import oracle.kubernetes.operator.watcher.WatchingEventDestination;
17-
1817
import org.junit.After;
18+
import org.junit.Assume;
1919
import org.junit.Before;
2020
import org.junit.Test;
2121

@@ -48,13 +48,13 @@ public class TestDomainListWatcher implements WatchingEventDestination<Domain> {
4848
@Before
4949
public void beforeTest() {
5050
// Create the Domain definition if it doesn't exist.
51-
createWeblogicCRD();
51+
if (isKubernetesAvailable()) createWeblogicCRD();
5252
}
5353

5454
@After
5555
public void afterTest() {
5656
// If the domain definition was done here then get rid of it.
57-
deleteWeblogicCRD();
57+
if (isKubernetesAvailable()) deleteWeblogicCRD();
5858
}
5959

6060
/**
@@ -63,7 +63,7 @@ public void afterTest() {
6363
*/
6464
@Test
6565
public void testDomainListWatcher() {
66-
66+
Assume.assumeTrue(isKubernetesAvailable());
6767
AtomicBoolean isStopping = new AtomicBoolean(false);
6868
DomainWatcher dlw = DomainWatcher.create("default", "", this, isStopping);
6969

@@ -105,6 +105,10 @@ public void testDomainListWatcher() {
105105
fail("Not all watch events were received for created objects");
106106
}
107107

108+
private boolean isKubernetesAvailable() { // assume it is available when running on Linux
109+
return System.getProperty("os.name").toLowerCase().contains("nix");
110+
}
111+
108112
// This override intercepts all watch events whioch would have
109113
// normally sent to the operator for processing.
110114
@Override

src/test/java/oracle/kubernetes/operator/HealthCheckHelperTest.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import oracle.kubernetes.operator.logging.LoggingFactory;
1313
import org.junit.After;
1414
import org.junit.Assert;
15+
import org.junit.Assume;
1516
import org.junit.Before;
1617
import org.junit.Ignore;
1718
import org.junit.Test;
@@ -37,6 +38,9 @@ public class HealthCheckHelperTest {
3738

3839
@Before
3940
public void setUp() throws Exception {
41+
LOGGER.getUnderlyingLogger().addHandler(hdlr);
42+
43+
if (!isKubernetesAvailable()) return;
4044

4145
ClientHolder client = ClientHelper.getInstance().take();
4246
try {
@@ -45,7 +49,6 @@ public void setUp() throws Exception {
4549
defaultHealthCheckHelper = new HealthCheckHelper(client, "default", Collections.singleton("default"));
4650
unitHealthCheckHelper = new HealthCheckHelper(client, UNIT_NAMESPACE, Collections.singleton(UNIT_NAMESPACE));
4751

48-
LOGGER.getUnderlyingLogger().addHandler(hdlr);
4952
} finally {
5053
ClientHelper.getInstance().recycle(client);
5154
}
@@ -60,6 +63,7 @@ public void tearDown() throws Exception {
6063
}
6164

6265
@Test
66+
@Ignore
6367
public void testDefaultNamespace() throws Exception {
6468

6569
defaultHealthCheckHelper.performSecurityChecks("default");
@@ -93,6 +97,7 @@ public void testUnitTestNamespace() throws Exception {
9397

9498
@Test
9599
public void testAccountNoPrivs() throws Exception {
100+
Assume.assumeTrue(isKubernetesAvailable());
96101
unitHealthCheckHelper.performSecurityChecks("unit-test-svc-account-no-privs");
97102
hdlr.flush();
98103
String logOutput = bos.toString();
@@ -102,6 +107,10 @@ public void testAccountNoPrivs() throws Exception {
102107
bos.reset();
103108
}
104109

110+
private boolean isKubernetesAvailable() { // assume it is available whenever running on linux
111+
return System.getProperty("os.name").toLowerCase().contains("nix");
112+
}
113+
105114
// Create a named namespace
106115
private V1Namespace createNamespace(ClientHolder client, String name) throws Exception {
107116

src/test/java/oracle/kubernetes/operator/SecretHelperTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,13 @@
1515
import org.junit.After;
1616
import org.junit.Assert;
1717
import org.junit.Before;
18+
import org.junit.Ignore;
1819
import org.junit.Test;
1920

2021
import java.util.HashMap;
2122
import java.util.Map;
2223

23-
24+
@Ignore
2425
public class SecretHelperTest {
2526

2627
private final static String SECRET_NAME = "wls-admin-server-credentials";

src/test/java/oracle/kubernetes/operator/ServiceHelperTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,13 @@
2121
import org.junit.After;
2222
import org.junit.Assert;
2323
import org.junit.Before;
24+
import org.junit.Ignore;
2425
import org.junit.Test;
2526

2627
import java.util.List;
2728
import java.util.Map;
2829

30+
@Ignore
2931
public class ServiceHelperTest {
3032

3133
// These test will use the "tests" namespace.

src/test/java/oracle/kubernetes/operator/WatchTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import oracle.kubernetes.operator.domain.model.oracle.kubernetes.weblogic.domain.v1.Domain;
1111
import oracle.kubernetes.operator.helpers.ClientHelper;
1212
import oracle.kubernetes.operator.helpers.ClientHolder;
13+
import org.junit.Assume;
1314
import org.junit.Test;
1415

1516
import javax.annotation.concurrent.NotThreadSafe;
@@ -21,6 +22,7 @@ public class WatchTest {
2122

2223
@Test
2324
public void testNamespaceWatch() {
25+
Assume.assumeTrue(System.getProperty("os.name").toLowerCase().contains("nix"));
2426

2527
ClientHolder client = ClientHelper.getInstance().take();
2628
try {
@@ -57,6 +59,7 @@ public void testNamespaceWatch() {
5759

5860
@Test
5961
public void testCustomResourceWatch() {
62+
Assume.assumeTrue(System.getProperty("os.name").toLowerCase().contains("nix"));
6063

6164
ClientHolder client = ClientHelper.getInstance().take();
6265
try {

src/test/java/oracle/kubernetes/operator/helpers/IngressHelperTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import org.junit.After;
3131
import org.junit.Assert;
3232
import org.junit.Before;
33+
import org.junit.Ignore;
3334
import org.junit.Test;
3435

3536
import java.util.List;
@@ -39,6 +40,7 @@
3940
/**
4041
* To test Ingress Helper
4142
*/
43+
@Ignore
4244
public class IngressHelperTest {
4345
private final String namespace = "weblogic-operator";
4446
private final String domainUID = "domianIngressHelperTest";

0 commit comments

Comments
 (0)