Skip to content

Commit e67e2d3

Browse files
committed
Remove uncompleted unit test
Signed-off-by: Dongbo Xiao <[email protected]>
1 parent 2da7ebe commit e67e2d3

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

operator/src/test/java/oracle/kubernetes/operator/create/CreateDomainInputsValidationTest.java

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ public class CreateDomainInputsValidationTest {
4747
private static final String PARAM_LOAD_BALANCER = "loadBalancer";
4848
private static final String PARAM_LOAD_BALANCER_WEB_PORT = "loadBalancerWebPort";
4949
private static final String PARAM_LOAD_BALANCER_DASHBOARD_PORT = "loadBalancerDashboardPort";
50-
private static final String PARAM_LOAD_BALANCER_VOLUME_PATH = "loadBalancerVolumePath";
51-
private static final String PARAM_LOAD_BALANCER_APP_PREPATH = "loadBalancerAppPrepath";
5250
private static final String PARAM_JAVA_OPTIONS = "javaOptions";
5351

5452
@Before
@@ -489,7 +487,7 @@ public void createDomain_with_invalidLoadBalancerWebPort_failsAndReturnsError()
489487
@Test
490488
public void createDomain_with_missingLoadBalancerDashboardPort_failsAndReturnsError() throws Exception {
491489
assertThat(
492-
execCreateDomain(newInputs().loadBalancer(LOAD_BALANCER_TRAEFIK).loadBalancerDashboardPort("")),
490+
execCreateDomain(newInputs().loadBalancerDashboardPort("")),
493491
failsAndPrints(paramMissingError(PARAM_LOAD_BALANCER_DASHBOARD_PORT)));
494492
}
495493

@@ -502,15 +500,6 @@ public void createDomain_with_invalidLoadBalancerDashboardPort_failsAndReturnsEr
502500
failsAndPrints(invalidIntegerParamValueError(PARAM_LOAD_BALANCER_DASHBOARD_PORT, val)));
503501
}
504502

505-
// commented out for now @Test
506-
public void createDomain_with_loadBalacnerApache_succeeds() throws Exception {
507-
GeneratedDomainYamlFiles
508-
.generateDomainYamlFiles(
509-
newInputs()
510-
.loadBalancer(LOAD_BALANCER_APACHE))
511-
.remove();
512-
}
513-
514503
// TBD - shouldn't we allow empty java options?
515504
@Test
516505
public void createDomain_with_missingJavaOptions_failsAndReturnsError() throws Exception {

0 commit comments

Comments
 (0)