Skip to content

Commit fc887a9

Browse files
alai8markxnelson
authored andcommitted
Fix javadoc to get successful mvn javadoc:javadoc in 2.0-rc1 branch (#672)
* Fix javadoc issues in operator-model * Fix javadoc issues in operator-runtime * Fix javadoc warnings in json-schema-maven-plugin
1 parent 9b0712c commit fc887a9

File tree

14 files changed

+31
-13
lines changed

14 files changed

+31
-13
lines changed

json-schema-maven-plugin/src/main/java/oracle/kubernetes/json/mojo/Main.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ public interface Main {
5656
/**
5757
* Returns a resource from the classpath, corresponding to the specified name.
5858
*
59+
* @param name Name of the resource to be returned
5960
* @return a url to the specified resource, or null if none is found
6061
*/
6162
URL getResource(String name);
@@ -65,6 +66,7 @@ public interface Main {
6566
*
6667
* @param className the root class for the schema
6768
* @param outputFile the file to generate
69+
* @throws MojoExecutionException If an exception occurred during the schema generation
6870
*/
6971
void generateSchema(String className, File outputFile) throws MojoExecutionException;
7072
}

model/src/main/java/oracle/kubernetes/weblogic/domain/ClusterConfigurator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ ClusterConfigurator withLivenessProbeSettings(
7676
* Add security constraints at container level, if the same constraint is also defined at pod
7777
* level then container constraint take precedence
7878
*
79-
* @param podSecurityContext
79+
* @param podSecurityContext pod-level security attributes to be added to this ClusterConfigurator
8080
* @return this object
8181
*/
8282
ClusterConfigurator withPodSecurityContext(V1PodSecurityContext podSecurityContext);

model/src/main/java/oracle/kubernetes/weblogic/domain/DomainConfigurator.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,17 @@ public DomainConfigurator withDomainHome(String domainHome) {
4545
}
4646

4747
/**
48-
* @param domainHomeInImage
49-
* @return
48+
* Specifies whether the domain home is stored in the image
49+
*
50+
* @param domainHomeInImage boolean indicating if the domain home is stored in the image
51+
* @return this object
5052
*/
5153
public DomainConfigurator withDomainHomeInImage(boolean domainHomeInImage) {
5254
getDomainSpec().setDomainHomeInImage(domainHomeInImage);
5355
return this;
5456
}
5557

56-
/** Defines a name for the domain's admin server. */
58+
/** @return An AdminServerConfigurator object for configuring an admin server */
5759
public abstract AdminServerConfigurator configureAdminServer();
5860

5961
public void withDefaultReplicaCount(int replicas) {
@@ -169,6 +171,7 @@ public abstract void withDefaultLivenessProbeSettings(
169171
* Sets the default server start policy ("ALWAYS", "NEVER" or "IF_NEEDED") for the domain.
170172
*
171173
* @param startPolicy the new default policy
174+
* @return this object
172175
*/
173176
public abstract DomainConfigurator withDefaultServerStartPolicy(String startPolicy);
174177

@@ -260,7 +263,7 @@ public abstract DomainConfigurator withContainerSecurityContext(
260263
* Add security constraints at container level, if the same constraint is also defined at pod
261264
* level then container constraint take precedence
262265
*
263-
* @param podSecurityContext
266+
* @param podSecurityContext pod-level security attributes to be added to this DomainConfigurator
264267
* @return this object
265268
*/
266269
public abstract DomainConfigurator withPodSecurityContext(

model/src/main/java/oracle/kubernetes/weblogic/domain/ServerConfigurator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ ServerConfigurator withReadinessProbeSettings(
7272
* Add security constraints at container level, if the same constraint is also defined at pod
7373
* level then container constraint take precedence
7474
*
75-
* @param podSecurityContext
75+
* @param podSecurityContext pod-level security attributes to be added to this ServerConfigurator
7676
* @return this object
7777
*/
7878
ServerConfigurator withPodSecurityContext(V1PodSecurityContext podSecurityContext);

model/src/main/java/oracle/kubernetes/weblogic/domain/v2/DomainSpec.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ public class DomainSpec extends BaseConfiguration {
170170
/**
171171
* Adds a Cluster to the DomainSpec
172172
*
173-
* @param cluster
174-
* @return
173+
* @param cluster The cluster to be added to this DomainSpec
174+
* @return this object
175175
*/
176176
public DomainSpec withCluster(Cluster cluster) {
177177
clusters.add(cluster);

model/src/main/java/oracle/kubernetes/weblogic/domain/v2/ManagedServerSpecV2Impl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ public class ManagedServerSpecV2Impl extends ServerSpecV2Impl {
1010
*
1111
* @param spec the domain specification
1212
* @param server the server whose configuration is to be returned
13+
* @param cluster the cluster that this managed server belongs to
1314
* @param clusterLimit the number of servers desired for the cluster, or null if not a clustered
1415
* server
15-
* @param configurations the additional configurations to search for values if the server lacks
1616
*/
1717
public ManagedServerSpecV2Impl(
1818
DomainSpec spec, Server server, Cluster cluster, Integer clusterLimit) {

operator/src/main/java/oracle/kubernetes/operator/PodWatcher.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ public class PodWatcher extends Watcher<V1Pod>
4949
* @param factory thread factory
5050
* @param ns Namespace
5151
* @param initialResourceVersion Initial resource version or empty string
52+
* @param tuning Watch tuning parameters
5253
* @param listener Callback for watch events
5354
* @param isStopping Stop signal
5455
* @return Pod watcher for the namespace

operator/src/main/java/oracle/kubernetes/operator/helpers/CRDHelper.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ private CRDHelper() {}
3535
/**
3636
* Factory for {@link Step} that creates Domain CRD
3737
*
38+
* @param version Version of the Kubernetes API Server
3839
* @param next Next step
3940
* @return Step for creating Domain custom resource definition
4041
*/

operator/src/main/java/oracle/kubernetes/operator/helpers/CallBuilder.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -520,6 +520,7 @@ private com.squareup.okhttp.Call deleteConfigMapAsync(
520520
*
521521
* @param name Name
522522
* @param namespace Namespace
523+
* @param deleteOptions Delete options
523524
* @param responseStep Response step for when call completes
524525
* @return Asynchronous step
525526
*/
@@ -823,6 +824,7 @@ private com.squareup.okhttp.Call deleteJobAsync(
823824
*
824825
* @param name Name
825826
* @param namespace Namespace
827+
* @param deleteOptions Delete options
826828
* @param responseStep Response step for when call completes
827829
* @return Asynchronous step
828830
*/

operator/src/main/java/oracle/kubernetes/operator/helpers/ConfigMapHelper.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -249,6 +249,7 @@ public boolean containsAll(V1ConfigMap actual, V1ConfigMap expected) {
249249
/**
250250
* Factory for {@link Step} that creates config map containing sit config
251251
*
252+
* @param next Next step
252253
* @return Step for creating config map containing sit config
253254
*/
254255
public static Step createSitConfigMapStep(Step next) {
@@ -425,6 +426,8 @@ Map<String, String> getCombinedData(V1ConfigMap existingConfigMap) {
425426
/**
426427
* Factory for {@link Step} that deletes introspector config map
427428
*
429+
* @param domainUID The unique identifier assigned to the Weblogic domain when it was registered
430+
* @param namespace Namespace
428431
* @param next Next processing step
429432
* @return Step for deleting introspector config map
430433
*/

0 commit comments

Comments
 (0)