downgrading electron-updater version to prevent breaking the Windows installer

Author: robertpatrick

electron/app/js/appUpdater.js

@@ -11,6 +11,7 @@ const i18n = require('./i18next.config');
 const { getLogger } = require('./wktLogging');
 const errorUtils = require('./errorUtils');
 const { sendToWindow } = require('./windowUtils');
+const osUtils = require('./osUtils');
 
 let _isDevMode;
 let _downloadWindow;
@@ -34,6 +35,15 @@ function registerAutoUpdateListeners() {
     autoUpdater.logger.info('Download complete, install type: ' + _installType);
     // quit and install in this handler so MacOS updater can process the event first
     if(_installType === 'now') {
+      // Working around https://github.com/electron-userland/electron-builder/issues/6418.
+      //
+      // This issue is fixed in [email protected] but that version suffers from
+      // https://github.com/electron-userland/electron-builder/issues/6425, which causes
+      // a Windows installer regression.
+      //
+      if (osUtils.isMac()) {
+        autoUpdater.autoInstallOnAppQuit = false;
+      }
       autoUpdater.quitAndInstall();
     }
   });

electron/package-lock.json

@@ -57,7 +57,7 @@
     "proxyquire": "^2.1.3"
   },
   "dependencies": {
-    "electron-updater": "^4.6.2",
+    "electron-updater": "^4.3.9",
     "extract-zip": "^2.0.1",
     "gunzip-maybe": "^1.4.2",
     "https-proxy-agent": "^5.0.0",