Skip to content

Commit 3f4a345

Browse files
committed
Remove OK button from about dialog, close on escape
1 parent 65d922a commit 3f4a345

File tree

3 files changed

+2
-11
lines changed

3 files changed

+2
-11
lines changed

electron/app/js/prompt/about.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717
<div id="appName" class="textLine main">...</div>
1818
<div id="version" class="textLine">...</div>
1919
<div id="copyright" class="textLine">...</div>
20-
<div id="buttons">
21-
<button type="submit" id="ok">...</button>
22-
</div>
2320
</form>
2421
</div>
2522
<script src="about.js"></script>

electron/app/js/prompt/about.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,14 @@ function promptRegister() {
3232
return promptError(error);
3333
}
3434

35-
const okButton = document.querySelector('#ok');
36-
37-
okButton.addEventListener('keyup', event => {
35+
document.addEventListener('keyup', event => {
3836
if (event.key === 'Escape') {
3937
promptCancel();
4038
}
4139
});
4240

4341
document.querySelector('#form').addEventListener('submit', promptSubmit);
4442

45-
okButton.focus();
46-
4743
window.api.i18n.ready.then(() => {
4844
const versionText = window.api.i18n.t('dialog-about-version', {
4945
version: promptOptions.applicationVersion,
@@ -55,8 +51,6 @@ function promptRegister() {
5551
document.querySelector('#version').textContent = versionText;
5652
document.querySelector('#copyright').textContent = promptOptions.copyright;
5753

58-
okButton.textContent = window.api.i18n.t('dialog-button-ok');
59-
6054
const height = document.querySelector('body').offsetHeight;
6155
window.api.ipc.sendSync('prompt-size:' + promptId, height);
6256
});

electron/app/js/promptUtils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ async function showAboutDialog(wktApp, parentWindow) {
113113
const preloadFile = path.join(__dirname, 'prompt', 'preload.js');
114114

115115
const WIDTH = 400;
116-
const HEIGHT = 234; // renderer will send IPC to adjust this
116+
const HEIGHT = 186; // renderer will send IPC to adjust this
117117
const MIN_HEIGHT = 120; // needs to be smaller than content height
118118

119119
return new Promise((resolve, reject) => {

0 commit comments

Comments
 (0)