Skip to content

Commit b0d1921

Browse files
committed
update and merge doc changes
1 parent 1f50fef commit b0d1921

File tree

3 files changed

+24
-1
lines changed

3 files changed

+24
-1
lines changed

electron/app/locales/en/webui.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -658,7 +658,8 @@
658658

659659
"ingress-design-ingress-route-name-field-validation-error": "Route {{routeName}}",
660660
"ingress-design-ingress-route-field-validation-error": "Route: {{routeName}}, Field: {{fieldName}}",
661-
"ingress-design-ingress-route-field-tls-config-error": "The route {{routeName}} has the {{fieldName}} field enabled but the {{specifyTlsSecretFieldName}} field is disabled.",
661+
"ingress-design-ingress-route-field-tls-config-error": "The route '{{routeName}}' has the '{{fieldName}}' set to '{{tlsOption}}' but the '{{specifyTlsSecretFieldName}}' field is disabled.",
662+
"ingress-design-ingress-route-field-tls-config-passthrough-error": "The route '{{routeName}}' has the '{{fieldName}}' set to '{{tlsOption}}' but the '{{virtualHostFieldName}}' field is not set, you must provide an valid DNS name in '{{virtualHostFieldName}}'",
662663

663664
"ingress-design-ingress-tls-secret-title": "TLS Secret for Ingress Routes",
664665
"ingress-design-specify-tls-secret-label": "Use Ingress TLS Secret",

webui/src/js/utils/ingress-routes-updater.js

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -491,6 +491,11 @@ function(IngressActionsBase, project, wktConsole, k8sHelper, i18n, projectIo, di
491491
});
492492
}
493493
}
494+
495+
if (ingressDefinition['virtualHost']) {
496+
externalLoadBalancerHost = '//' + ingressDefinition['virtualHost'];
497+
}
498+
494499
if (useNodePort) {
495500
if (ingressDefinition['tlsOption'] !== 'plain') {
496501
results['accessPoint'] = 'https:' + externalLoadBalancerHost + ':' + ingressSSLPort + ingressDefinition.path;
@@ -625,11 +630,27 @@ function(IngressActionsBase, project, wktConsole, k8sHelper, i18n, projectIo, di
625630
});
626631
const errMessage = i18n.t('ingress-design-ingress-route-field-tls-config-error', {
627632
routeName: data['name'],
633+
tlsOption: i18n.t('ingress-design-ingress-route-tlsoption-ssl-terminate-ingress'),
628634
fieldName: i18n.t('ingress-design-ingress-route-tls-label'),
629635
specifyTlsSecretFieldName: i18n.t('ingress-design-specify-tls-secret-label')
630636
});
631637
validationObject.addField(errFieldMessage, errMessage, routeConfig);
632638
}
639+
640+
if (data['tlsOption'] === 'ssl_passthrough' && !data['virtualHost']) {
641+
errFieldMessage = i18n.t('ingress-design-ingress-route-field-validation-error', {
642+
routeName: data['name'],
643+
fieldName: i18n.t('ingress-design-ingress-route-virtualhost-label')
644+
});
645+
const errMessage = i18n.t('ingress-design-ingress-route-field-tls-config-passthrough-error', {
646+
routeName: data['name'],
647+
tlsOption: i18n.t('ingress-design-ingress-route-tlsoption-ssl-passthrough'),
648+
fieldName: i18n.t('ingress-design-ingress-route-virtualhost-label'),
649+
virtualHostFieldName: i18n.t('ingress-design-ingress-route-virtualhost-label')
650+
});
651+
validationObject.addField(errFieldMessage, errMessage, routeConfig);
652+
}
653+
633654
}
634655
}
635656

webui/src/js/views/route-edit-dialog.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@
6060
</oj-bind-for-each>
6161
</oj-radioset>
6262

63+
6364
<oj-bind-if test="[[askIfConsoleService() === true]]">
6465
<oj-switch label-hint="[[labelMapper('route-is-console-svc-label')]]"
6566
value="{{isConsoleService.observable}}"

0 commit comments

Comments
 (0)