setting docker/podman login host default to docker.io

robertpatrick · robertpatrick · commit cdfc6b08f8d8 · 2021-12-30T09:56:02.000-06:00
diff --git a/electron/app/js/imageBuilderUtils.js b/electron/app/js/imageBuilderUtils.js
@@ -79,7 +79,11 @@ async function doLogin(imageBuilderExe, options) {
 
   if (options.host) {
     args.push(options.host);
+  } else {
+    // podman does not always default to docker hub when logging in without a host.
+    args.push('docker.io');
   }
+
   if (options.username) {
     args.push('-u', options.username);
   }

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,11 @@ async function doLogin(imageBuilderExe, options) {`
`79`	`79`
`80`	`80`	`if (options.host) {`
`81`	`81`	`args.push(options.host);`
	`82`	`+ } else {`
	`83`	`+ // podman does not always default to docker hub when logging in without a host.`
	`84`	`+ args.push('docker.io');`
`82`	`85`	`}`
	`86`	`+`
`83`	`87`	`if (options.username) {`
`84`	`88`	`args.push('-u', options.username);`
`85`	`89`	`}`