Migrate to CAPI V3 API #44
Description
Expected behavior
- As an osb-cmdb operator
- In order be able to use a maintained CF inventory API endpoint only exposing CC API V3 and no more CC API V2, see related deprecation plan and [RFC0032] CF API v2 End of Life cloudfoundry/community#1001
- I need osb-cmdb to support CAPI V3 api
Observed behavior
Osb-cmdb 1.x uses CAPI V2 API in production and acceptance code base.
The design however does not rely too tightly on CAPI V2 specifics, in particular error recovery does not rely on CAPI V2 error codes and should port more easily on CAPI V3 apis.
CAPI V3 APIs are now complete
See associated design docs extracted from V3 API Proposals index
| Resource | Proposal | Tracker Epic |
|---|---|---|
| [...] | ||
| Service Bindings & Keys | https://docs.google.com/document/d/115XMaCGvtkuXpmSA-UwnEowYdZ75mLB_OdXsuSiwRf4/edit | |
| Service Brokers | https://docs.google.com/document/d/1O-KMT9klgmnJtBtEHsKDV2IEOtZlG6TK3j68A8klMlk/edit | https://www.pivotaltracker.com/epic/show/4450110 |
| Service Instances | https://docs.google.com/document/d/1P5laZqVYjtl_boSdpksT5LHOFjhm6CQLzWVx24UpXpM/edit | |
| Service Offerings | https://docs.google.com/document/d/1bDsEiZRwQJNUI41cQlUaioY7JA1fnv_AThOI2ekPXNM/edit | https://www.pivotaltracker.com/epic/show/4443887 |
| Service Plans and Service Plan Visibilities | https://docs.google.com/document/d/1dwNbNy99f1qgKRfHy9hmc7B82XtcAtn0Wjg3KUpf7fo/edit |
However, support in cf-java-client is not yet complete:
Steps for osb-cmdb CAPI V2 EOL:
- Migrate production codebase
- [B] Missing Operations support, see overall status Lacking v3 APIs cloudfoundry/cf-java-client#1160 (comment)
- Binding: create service binding sync (see Add support for async service bindings #227 )
- Spaces: getSpace, createSpace
- Organization: getOrganization by name
- Catalog: DefaultCloudFoundryOperations
- Services: DefaultServices.getInstance by name
- Binding: create service binding sync (see Add support for async service bindings #227 )
- Use cloudfoundry-client v3 instead
- [B] Missing Operations support, see overall status Lacking v3 APIs cloudfoundry/cf-java-client#1160 (comment)
- Migrate AcceptanceTests, https://github.com/orange-cloudfoundry/osb-cmdb/blob/master/spring-cloud-app-broker-acceptance-tests/src/test/java/org/springframework/cloud/appbroker/acceptance/CloudFoundryAcceptanceTest.java#L302-L325
- [B] Missing Operations support
- DefaultOrganization: GetOrg, CreateOrg,
- DefaultSpace: GetSpace, CreateSpace
- DefaultServiceAdmin: createServiceBroker, updateServiceBroker, enableServiceAccess
- DefaultServices: create/update/delete service instance
- DefaultServiceBinding: create/update/delete service binding
- [B] Check for SCAB V3 update:
- still pending, see https://github.com/spring-cloud/spring-cloud-app-broker/blob/d7ff012931faee07fe750c2812138e56d06eb1f1/spring-cloud-app-broker-acceptance-tests/src/test/java/org/springframework/cloud/appbroker/acceptance/fixtures/cf/CloudFoundryService.java#L38-L64
- asked for insight CAPI V2 EOL spring-cloud/spring-cloud-app-broker#1284
- [B] Missing Operations support
Affected release
Reproduced on version 1.0