Merge remote-tracking branch 'github/main' into kb_update

Author: orangecola

.github/copilot-instructions.md

@@ -1,14 +1,9 @@
 You will be tasked to fix an issue from an open-source repository. This is a Go based repository hosting a Terrform provider for the elastic stack (elasticsearch and kibana) APIs. This repo currently supports both [plugin framework](https://developer.hashicorp.com/terraform/plugin/framework/getting-started/code-walkthrough) and [sdkv2](https://developer.hashicorp.com/terraform/plugin/sdkv2) resources. Unless you're told otherwise, all new resources _must_ use the plugin framework. 
 
-
-
-
 Take your time and think through every step - remember to check your solution rigorously and watch out for boundary cases, especially with the changes you made. Your solution must be perfect. If not, continue working on it. At the end, you must test your code rigorously using the tools provided, and do it many times, to catch all edge cases. If it is not robust, iterate more and make it perfect. Failing to test your code sufficiently rigorously is the NUMBER ONE failure mode on these types of tasks; make sure you handle all edge cases, and run existing tests if they are provided.
 
-
 Please see [README.md](../README.md) and the [CONTRIBUTING.md](../CONTRIBUTING.md) docs before getting started.
 
-
 # Workflow
 
 ## High-Level Problem Solving Strategy
@@ -57,27 +52,27 @@ Carefully read the issue and think hard about a plan to solve it before coding.
 - After each change, verify correctness by running relevant tests.
 - If tests fail, analyze failures and revise your patch.
 - Write additional tests if needed to capture important behaviors or edge cases.
-- Ensure all tests pass before finalizing.
+- NEVER accept acceptance tests that have been skipped due to environment issues; always ensure the environment is correctly set up and all tests run successfully.
 
 ### 6.1 Acceptance Testing Requirements
-When running acceptance tests (`make testacc`), ensure the following:
-
+When running acceptance tests, ensure the following:
 
 - **Environment Variables** - The following environment variables are required for acceptance tests:
   - `ELASTICSEARCH_ENDPOINTS` (default: http://localhost:9200)
   - `ELASTICSEARCH_USERNAME` (default: elastic) 
   - `ELASTICSEARCH_PASSWORD` (default: password)
   - `KIBANA_ENDPOINT` (default: http://localhost:5601)
   - `TF_ACC` (must be set to "1" to enable acceptance tests)
-- **Ensure a valid environment if using `go test`** - Check if the required environment variables are set, if not use the defaults specified above. 
-- **Always finish with `make testacc`** - This will run all tests. Make sure all tests pass before considering a task complete.
-- **Pre-set Environment Variables** - Default environment variables are configured in the Makefile. If these defaults are suitable for your testing environment, `make testacc` will work directly without additional setup
-- **Docker Environment** - For isolated testing with guaranteed environment setup, use `make docker-testacc` which starts Elasticsearch and Kibana containers automatically
+- **Run targeted tests using `go test`** - Ensure the required environment variables are explicitly defined when running targeted tests. Example:
+  ```bash
+  ELASTICSEARCH_ENDPOINTS=http://localhost:9200 ELASTICSEARCH_USERNAME=elastic ELASTICSEARCH_PASSWORD=password KIBANA_ENDPOINT=http://localhost:5601 TF_ACC=1 go test -v -run TestAccResourceName ./path/to/testfile.go
+  ```
 
 ## 7. Final Verification
 - Confirm the root cause is fixed.
 - Review your solution for logic correctness and robustness.
 - Iterate until you are extremely confident the fix is complete and all tests pass.
+- Run the acceptance tests for any changed resources. Ensure acceptance tests pass without any environment-related skips. Use `make testacc` to verify this, explicitly defining the required environment variables.
 - Run `make lint` to ensure any linting errors have not surfaced with your changes. This task may automatically correct any linting errors, and regenerate documentation. Include any changes in your commit. 
 
 ## 8. Final Reflection and Additional Testing

.github/workflows/test.yml

@@ -45,7 +45,7 @@ jobs:
           terraform_wrapper: false
 
       - name: Lint
-        run: make lint
+        run: make check-lint
 
   test:
     name: Matrix Acceptance Test

CHANGELOG.md

@@ -13,10 +13,12 @@
 - Migrate `elasticstack_kibana_action_connector` to the Terraform plugin framework ([#1269](https://github.com/elastic/terraform-provider-elasticstack/pull/1269))
 - Migrate `elasticstack_elasticsearch_security_role_mapping` resource and data source to Terraform Plugin Framework ([#1279](https://github.com/elastic/terraform-provider-elasticstack/pull/1279))
 - Add support for `inactivity_timeout` in `elasticstack_fleet_agent_policy` ([#641](https://github.com/elastic/terraform-provider-elasticstack/issues/641))
+- Add support for `kafka` output types in `elasticstack_fleet_output` ([#1302](https://github.com/elastic/terraform-provider-elasticstack/pull/1302))
 - Add support for `prevent_initial_backfill` to `elasticstack_kibana_slo` ([#1071](https://github.com/elastic/terraform-provider-elasticstack/pull/1071))
 - [Refactor] Regenerate the SLO client using the current OpenAPI spec ([#1303](https://github.com/elastic/terraform-provider-elasticstack/pull/1303))
 - Add support for `data_view_id` in the `elasticstack_kibana_slo` resource ([#1305](https://github.com/elastic/terraform-provider-elasticstack/pull/1305))
 - Add support for `unenrollment_timeout` in `elasticstack_fleet_agent_policy` ([#1169](https://github.com/elastic/terraform-provider-elasticstack/issues/1169))
+- Handle default value for `allow_restricted_indices` in `elasticstack_elasticsearch_security_api_key` ([#1315](https://github.com/elastic/terraform-provider-elasticstack/pull/1315))
 
 ## [0.11.17] - 2025-07-21
 

Makefile

@@ -52,7 +52,6 @@ build-ci: ## build the terraform provider
 .PHONY: build
 build: lint build-ci ## build the terraform provider
 
-
 .PHONY: testacc
 testacc: ## Run acceptance tests
 	TF_ACC=1 go test -v ./... -count $(ACCTEST_COUNT) -parallel $(ACCTEST_PARALLELISM) $(TESTARGS) -timeout $(ACCTEST_TIMEOUT)
@@ -225,7 +224,7 @@ docker-clean: ## Try to remove provisioned nodes and assigned network
 
 .PHONY: docs-generate
 docs-generate: tools ## Generate documentation for the provider
-	@ go tool github.com/hashicorp/terraform-plugin-docs/cmd/tfplugindocs generate --provider-name elasticstack
+	@ go tool github.com/hashicorp/terraform-plugin-docs/cmd/tfplugindocs generate --provider-name terraform-provider-elasticstack
 
 
 .PHONY: gen
@@ -254,7 +253,10 @@ golangci-lint:
 
 
 .PHONY: lint
-lint: setup golangci-lint check-fmt check-docs ## Run lints to check the spelling and common go patterns
+lint: setup golangci-lint fmt docs-generate ## Run lints to check the spelling and common go patterns
+
+.PHONY: check-lint
+check-lint: setup golangci-lint check-fmt check-docs
 
 .PHONY: fmt
 fmt: ## Format code

docs/data-sources/elasticsearch_enrich_policy.md

@@ -1,13 +1,15 @@
+
 ---
-subcategory: "Enrich"
+# generated by https://github.com/hashicorp/terraform-plugin-docs
 page_title: "elasticstack_elasticsearch_enrich_policy Data Source - terraform-provider-elasticstack"
+subcategory: "Enrich"
 description: |-
-  Returns information about an enrich policy. See: https://www.elastic.co/guide/en/elasticsearch/reference/current/get-enrich-policy-api.html
+  Returns information about an enrich policy. See the enrich policy API documentation https://www.elastic.co/guide/en/elasticsearch/reference/current/get-enrich-policy-api.html for more details.
 ---
 
-# Data Source: elasticstack_elasticsearch_enrich_policy
+# elasticstack_elasticsearch_enrich_policy (Data Source)
 
-Returns information about an enrich policy. See: https://www.elastic.co/guide/en/elasticsearch/reference/current/get-enrich-policy-api.html
+Returns information about an enrich policy. See the [enrich policy API documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/get-enrich-policy-api.html) for more details.
 
 ## Example Usage
 

docs/data-sources/elasticsearch_index_template.md

@@ -1,14 +1,15 @@
+
 ---
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "elasticstack_elasticsearch_index_template Data Source - terraform-provider-elasticstack"
 subcategory: "Index"
-layout: ""
-page_title: "Elasticstack: elasticstack_elasticsearch_index_template Data Source"
 description: |-
-  Retrieves index template.
+  Retrieves information about an existing index template definition. See, https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-get-template.html
 ---
 
-# Data Source: elasticstack_elasticsearch_index_template
+# elasticstack_elasticsearch_index_template (Data Source)
 
-Use this data source to retrieve information about existing Elasticsearch index templates. See, https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-get-template.html
+Retrieves information about an existing index template definition. See, https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-get-template.html
 
 ## Example Usage
 

docs/data-sources/elasticsearch_indices.md

@@ -1,14 +1,15 @@
+
 ---
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "elasticstack_elasticsearch_indices Data Source - terraform-provider-elasticstack"
 subcategory: "Index"
-layout: ""
-page_title: "Elasticstack: elasticstack_elasticsearch_indices Data Source"
 description: |-
-  Retrieves indices.
+  Retrieves information about existing Elasticsearch indices. See: https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-get-index.html
 ---
 
-# Data Source: elasticstack_elasticsearch_indices
+# elasticstack_elasticsearch_indices (Data Source)
 
-Use this data source to retrieve and get information about existing Elasticsearch indices. See, https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-get-index.html
+Retrieves information about existing Elasticsearch indices. See: https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-get-index.html
 
 ## Example Usage
 

docs/data-sources/elasticsearch_info.md

@@ -1,14 +1,15 @@
+
 ---
-subcategory: "Cluster"
-layout: ""
-page_title: "Elasticstack: elasticstack_elasticsearch_info Data Source"
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "elasticstack_elasticsearch_info Data Source - terraform-provider-elasticstack"
+subcategory: "Elasticsearch"
 description: |-
-  Gets information about the Elasticsearch cluster.
+  Gets information about the Elastic cluster.
 ---
 
-# Data Source: elasticstack_elasticsearch_info
+# elasticstack_elasticsearch_info (Data Source)
 
-This data source provides the information about the configured Elasticsearch cluster
+Gets information about the Elastic cluster.
 
 ## Example Usage
 

docs/data-sources/elasticsearch_ingest_processor_append.md

@@ -1,17 +1,15 @@
+
 ---
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "elasticstack_elasticsearch_ingest_processor_append Data Source - terraform-provider-elasticstack"
 subcategory: "Ingest"
-layout: ""
-page_title: "Elasticstack: elasticstack_elasticsearch_ingest_processor_append Data Source"
 description: |-
-  Helper data source to create a processor which appends one or more values to an existing array if the field already exists and it is an array.
+  Helper data source which can be used to create the configuration for an append processor. This processor appends one or more values to an existing array if the field already exists and it is an array. Converts a scalar to an array and appends one or more values to it if the field exists and it is a scalar. Creates an array containing the provided values if the field doesn’t exist. See the append processor documentation https://www.elastic.co/guide/en/elasticsearch/reference/current/append-processor.html for more details.
 ---
 
-# Data Source: elasticstack_elasticsearch_ingest_processor_append
-
-Helper data source to which can be used to create a processor to append one or more values to an existing array if the field already exists and it is an array.
-Converts a scalar to an array and appends one or more values to it if the field exists and it is a scalar. Creates an array containing the provided values if the field doesn’t exist.
+# elasticstack_elasticsearch_ingest_processor_append (Data Source)
 
-See: https://www.elastic.co/guide/en/elasticsearch/reference/current/append-processor.html
+Helper data source which can be used to create the configuration for an append processor. This processor appends one or more values to an existing array if the field already exists and it is an array. Converts a scalar to an array and appends one or more values to it if the field exists and it is a scalar. Creates an array containing the provided values if the field doesn’t exist. See the [append processor documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/append-processor.html) for more details.
 
 ## Example Usage
 
@@ -56,4 +54,3 @@ resource "elasticstack_elasticsearch_ingest_pipeline" "my_ingest_pipeline" {
 
 - `id` (String) Internal identifier of the resource
 - `json` (String) JSON representation of this data source.
-

docs/data-sources/elasticsearch_ingest_processor_bytes.md

@@ -1,18 +1,21 @@
+
 ---
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "elasticstack_elasticsearch_ingest_processor_bytes Data Source - terraform-provider-elasticstack"
 subcategory: "Ingest"
-layout: ""
-page_title: "Elasticstack: elasticstack_elasticsearch_ingest_processor_bytes Data Source"
 description: |-
-  Helper data source to create a processor which converts a human readable byte value (e.g. 1kb) to its value in bytes (e.g. 1024).
+  Helper data source which can be used to create the configuration for a bytes processor. The processor converts a human readable byte value (e.g. 1kb) to its value in bytes (e.g. 1024). See the bytes processor documentation https://www.elastic.co/guide/en/elasticsearch/reference/current/bytes-processor.html for more details.
+  If the field is an array of strings, all members of the array will be converted.
+  Supported human readable units are "b", "kb", "mb", "gb", "tb", "pb" case insensitive. An error will occur if the field is not a supported format or resultant value exceeds 2^63.
 ---
 
-# Data Source: elasticstack_elasticsearch_ingest_processor_bytes
+# elasticstack_elasticsearch_ingest_processor_bytes (Data Source)
 
-Helper data source to which can be used to create a processor to convert a human readable byte value (e.g. 1kb) to its value in bytes (e.g. 1024). If the field is an array of strings, all members of the array will be converted.
+Helper data source which can be used to create the configuration for a bytes processor. The processor converts a human readable byte value (e.g. 1kb) to its value in bytes (e.g. 1024). See the [bytes processor documentation](https://www.elastic.co/guide/en/elasticsearch/reference/current/bytes-processor.html) for more details.
 
-Supported human readable units are "b", "kb", "mb", "gb", "tb", "pb" case insensitive. An error will occur if the field is not a supported format or resultant value exceeds 2^63.
+If the field is an array of strings, all members of the array will be converted.
 
-See: https://www.elastic.co/guide/en/elasticsearch/reference/current/bytes-processor.html
+Supported human readable units are "b", "kb", "mb", "gb", "tb", "pb" case insensitive. An error will occur if the field is not a supported format or resultant value exceeds 2^63.
 
 ## Example Usage
 
@@ -55,4 +58,3 @@ resource "elasticstack_elasticsearch_ingest_pipeline" "my_ingest_pipeline" {
 
 - `id` (String) Internal identifier of the resource
 - `json` (String) JSON representation of this data source.
-