Skip to content

Commit ab1d1aa

Browse files
martypittmartypitt
committed
removed Flow - not supported
1 parent 2e2fb85 commit ab1d1aa

File tree

6 files changed

+2
-114
lines changed

6 files changed

+2
-114
lines changed

‎preflight-spec/src/main/kotlin/com/orbitalhq/preflight/spec/TestSpec.kt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ data class TestSpec(
88
val dataSources: List<Stub>,
99
val expectedResult: String,
1010
val resultFormat: ResultFormat = ResultFormat.JSON,
11-
val flow: String?,
1211
val specVersion: String = "0.1",
1312
)
1413

‎preflight-spec/src/main/kotlin/com/orbitalhq/preflight/spec/TestSpecReader.kt‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ object TestSpecReader {
3636
val dataSources = mutableListOf<Stub>()
3737
var expectedResult: String? = null
3838
var resultFormat: ResultFormat = ResultFormat.JSON
39-
var flow: String? = null
4039

4140
var currentH2: String? = null
4241
var collectingDescription = false
@@ -180,9 +179,6 @@ object TestSpecReader {
180179
else -> ResultFormat.JSON
181180
}
182181
}
183-
"Flow" -> {
184-
flow = node.literal.trimEnd()
185-
}
186182
}
187183
}
188184
else -> {
@@ -233,8 +229,7 @@ object TestSpecReader {
233229
query = query,
234230
dataSources = dataSources,
235231
expectedResult = expectedResult,
236-
resultFormat = resultFormat,
237-
flow = flow
232+
resultFormat = resultFormat
238233
)
239234
}
240235

‎preflight-spec/src/main/kotlin/com/orbitalhq/preflight/spec/TestSpecWriter.kt‎

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -94,16 +94,6 @@ object TestSpecWriter {
9494
appendLine("```$infoString")
9595
appendLine(spec.expectedResult)
9696
appendLine("```")
97-
98-
// Flow section (optional)
99-
if (spec.flow != null) {
100-
appendLine()
101-
appendLine("## Flow")
102-
appendLine()
103-
appendLine("```mermaid")
104-
appendLine(spec.flow)
105-
appendLine("```")
106-
}
10797
}
10898

10999
fun writeFile(spec: TestSpec, path: Path) {

‎preflight-spec/src/test/kotlin/com/orbitalhq/preflight/spec/RoundTripTest.kt‎

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ class RoundTripTest : DescribeSpec({
1818
Stub("Get Customer", "getCustomer", StubMode.REQUEST_RESPONSE, parameters = null, response = """{ "id": "1" }""", messages = null)
1919
),
2020
expectedResult = """{ "id": "1" }""",
21-
flow = null
2221
)
2322
val roundTripped = TestSpecReader.read(TestSpecWriter.write(original))
2423
roundTripped shouldBe original
@@ -36,7 +35,6 @@ class RoundTripTest : DescribeSpec({
3635
Stub("Fetch Orders", "getOrders", StubMode.REQUEST_RESPONSE, parameters = null, response = """[{ "orderId": "ORD-1" }]""", messages = null)
3736
),
3837
expectedResult = """{ "customer": "Alice", "orders": [{ "orderId": "ORD-1" }] }""",
39-
flow = null
4038
)
4139
val roundTripped = TestSpecReader.read(TestSpecWriter.write(original))
4240
roundTripped shouldBe original
@@ -56,24 +54,6 @@ class RoundTripTest : DescribeSpec({
5654
)
5755
),
5856
expectedResult = """[{ "price": 100 }, { "price": 200 }, { "price": 300 }]""",
59-
flow = null
60-
)
61-
val roundTripped = TestSpecReader.read(TestSpecWriter.write(original))
62-
roundTripped shouldBe original
63-
}
64-
65-
it("round-trips a spec with optional fields (description and flow)") {
66-
val original = TestSpec(
67-
specVersion = "0.1",
68-
name = "Full Test",
69-
description = "A comprehensive test case.",
70-
schema = null,
71-
query = "find { Customer }",
72-
dataSources = listOf(
73-
Stub("Get Customer", "getCustomer", StubMode.REQUEST_RESPONSE, parameters = null, response = """{ "id": "1" }""", messages = null)
74-
),
75-
expectedResult = """{ "id": "1" }""",
76-
flow = "sequenceDiagram\n Q->>S: getCustomer\n S-->>Q: Customer"
7757
)
7858
val roundTripped = TestSpecReader.read(TestSpecWriter.write(original))
7959
roundTripped shouldBe original
@@ -90,7 +70,6 @@ class RoundTripTest : DescribeSpec({
9070
Stub("Get Customer", "getCustomer", StubMode.REQUEST_RESPONSE, parameters = null, response = """{ "id": "1", "name": "Alice" }""", messages = null)
9171
),
9272
expectedResult = """{ "id": "1", "name": "Alice" }""",
93-
flow = null
9473
)
9574
val roundTripped = TestSpecReader.read(TestSpecWriter.write(original))
9675
roundTripped shouldBe original
@@ -108,7 +87,6 @@ class RoundTripTest : DescribeSpec({
10887
),
10988
expectedResult = """{ "type": "Customer", "value": { "id": "1" } }""",
11089
resultFormat = ResultFormat.TYPED_INSTANCE,
111-
flow = null
11290
)
11391
val roundTripped = TestSpecReader.read(TestSpecWriter.write(original))
11492
roundTripped shouldBe original
@@ -126,7 +104,6 @@ class RoundTripTest : DescribeSpec({
126104
),
127105
expectedResult = """{ "id": "1" }""",
128106
resultFormat = ResultFormat.JSON,
129-
flow = null
130107
)
131108
val roundTripped = TestSpecReader.read(TestSpecWriter.write(original))
132109
roundTripped shouldBe original
@@ -145,7 +122,6 @@ class RoundTripTest : DescribeSpec({
145122
Stub("User Profile", "getUser", StubMode.REQUEST_RESPONSE, parameters = null, response = """{ "name": "Bob" }""", messages = null)
146123
),
147124
expectedResult = """{ "theme": "dark", "price": 42, "name": "Bob" }""",
148-
flow = null
149125
)
150126
val roundTripped = TestSpecReader.read(TestSpecWriter.write(original))
151127
roundTripped shouldBe original
@@ -165,7 +141,6 @@ class RoundTripTest : DescribeSpec({
165141
messages = null)
166142
),
167143
expectedResult = """{ "productId": "PROD-1001", "name": "Laptop" }""",
168-
flow = null
169144
)
170145
val roundTripped = TestSpecReader.read(TestSpecWriter.write(original))
171146
roundTripped shouldBe original

‎preflight-spec/src/test/kotlin/com/orbitalhq/preflight/spec/TestSpecReaderTest.kt‎

Lines changed: 0 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import io.kotest.assertions.throwables.shouldThrow
44
import io.kotest.core.spec.style.DescribeSpec
55
import io.kotest.matchers.collections.shouldHaveSize
66
import io.kotest.matchers.nulls.shouldBeNull
7-
import io.kotest.matchers.nulls.shouldNotBeNull
87
import io.kotest.matchers.shouldBe
98
import io.kotest.matchers.string.shouldContain
109

@@ -54,7 +53,6 @@ class TestSpecReaderTest : DescribeSpec({
5453
spec.dataSources[0].mode shouldBe StubMode.REQUEST_RESPONSE
5554
spec.dataSources[0].response shouldBe """{ "id": "1" }"""
5655
spec.expectedResult shouldBe """{ "id": "1" }"""
57-
spec.flow.shouldBeNull()
5856
}
5957

6058
it("parses a full spec with multiple stubs") {
@@ -96,14 +94,6 @@ class TestSpecReaderTest : DescribeSpec({
9694
|```json
9795
|{ "customer": { "name": "Alice Smith" }, "orders": [{ "id": "ORD-99" }] }
9896
|```
99-
|
100-
|## Flow
101-
|
102-
|```mermaid
103-
|sequenceDiagram
104-
| participant Q as Query Engine
105-
| Q->>C: getCustomer
106-
|```
10797
""".trimMargin()
10898

10999
val spec = TestSpecReader.read(markdown)
@@ -112,8 +102,6 @@ class TestSpecReaderTest : DescribeSpec({
112102
spec.dataSources shouldHaveSize 2
113103
spec.dataSources[0].operationName shouldBe "getCustomer"
114104
spec.dataSources[1].operationName shouldBe "getOrdersForCustomer"
115-
spec.flow.shouldNotBeNull()
116-
spec.flow shouldContain "sequenceDiagram"
117105
}
118106

119107
it("parses description prose between H1 and first H2") {
@@ -235,49 +223,6 @@ class TestSpecReaderTest : DescribeSpec({
235223
spec.schema.shouldBeNull()
236224
}
237225

238-
it("parses Flow section when present") {
239-
val markdown = """
240-
|---
241-
|spec-version: 0.1
242-
|---
243-
|
244-
|# Test With Flow
245-
|
246-
|## Query
247-
|
248-
|```taxiql
249-
|find { Foo }
250-
|```
251-
|
252-
|## Data Sources
253-
|
254-
|### Stub
255-
|<!-- operation: getFoo -->
256-
|
257-
|Response:
258-
|```json
259-
|{}
260-
|```
261-
|
262-
|## Expected Result
263-
|
264-
|```json
265-
|{}
266-
|```
267-
|
268-
|## Flow
269-
|
270-
|```mermaid
271-
|sequenceDiagram
272-
| Q->>S: getFoo
273-
|```
274-
""".trimMargin()
275-
276-
val spec = TestSpecReader.read(markdown)
277-
spec.flow.shouldNotBeNull()
278-
spec.flow shouldContain "sequenceDiagram"
279-
}
280-
281226
it("parses stream-mode stub with multiple messages") {
282227
val markdown = """
283228
|---

‎preflight-spec/src/test/kotlin/com/orbitalhq/preflight/spec/TestSpecWriterTest.kt‎

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -94,21 +94,6 @@ class TestSpecWriterTest : DescribeSpec({
9494
between.all { it.isBlank() }
9595
}
9696

97-
it("writes spec with flow section") {
98-
val spec = minimalSpec().copy(flow = "sequenceDiagram\n Q->>S: getFoo")
99-
val output = TestSpecWriter.write(spec)
100-
output shouldContain "## Flow"
101-
output shouldContain "```mermaid"
102-
output shouldContain "sequenceDiagram"
103-
}
104-
105-
it("writes spec without flow section") {
106-
val spec = minimalSpec().copy(flow = null)
107-
val output = TestSpecWriter.write(spec)
108-
output shouldNotContain "## Flow"
109-
output shouldNotContain "```mermaid"
110-
}
111-
11297
it("writes plain json info string for JSON format") {
11398
val spec = minimalSpec()
11499
val output = TestSpecWriter.write(spec)
@@ -191,6 +176,5 @@ private fun minimalSpec() = TestSpec(
191176
dataSources = listOf(
192177
Stub("Get Customer", "getCustomer", StubMode.REQUEST_RESPONSE, parameters = null, response = """{ "id": "1" }""", messages = null)
193178
),
194-
expectedResult = """{ "id": "1" }""",
195-
flow = null
179+
expectedResult = """{ "id": "1" }"""
196180
)

0 commit comments

Comments
 (0)