-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathbrowse_test.go
More file actions
584 lines (493 loc) · 14.4 KB
/
browse_test.go
File metadata and controls
584 lines (493 loc) · 14.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
package comet
import (
"context"
"encoding/json"
"fmt"
"sync"
"testing"
"time"
)
// TestListRecent tests the ListRecent browse functionality
func TestListRecent(t *testing.T) {
dir := t.TempDir()
client, err := NewClient(dir)
if err != nil {
t.Fatal(err)
}
defer client.Close()
ctx := context.Background()
streamName := "test:v1:shard:0000"
// Test empty stream
t.Run("EmptyStream", func(t *testing.T) {
messages, err := client.ListRecent(ctx, streamName, 10)
if err != nil {
t.Fatal(err)
}
if len(messages) != 0 {
t.Errorf("Expected 0 messages from empty stream, got %d", len(messages))
}
})
// Write some test data
testData := make([][]byte, 100)
for i := 0; i < 100; i++ {
testData[i] = []byte(fmt.Sprintf(`{"id": %d, "data": "test message %d"}`, i, i))
}
_, err = client.Append(ctx, streamName, testData)
if err != nil {
t.Fatal(err)
}
// Ensure data is flushed before reading
if err := client.Sync(ctx); err != nil {
t.Fatal(err)
}
// Test listing recent messages
t.Run("ListRecent10", func(t *testing.T) {
messages, err := client.ListRecent(ctx, streamName, 10)
if err != nil {
t.Fatal(err)
}
if len(messages) != 10 {
t.Errorf("Expected 10 messages, got %d", len(messages))
}
// Verify we got the last 10 messages (90-99)
for i, msg := range messages {
expectedID := 90 + i
expected := fmt.Sprintf(`{"id": %d, "data": "test message %d"}`, expectedID, expectedID)
if string(msg.Data) != expected {
t.Errorf("Message %d: expected %s, got %s", i, expected, string(msg.Data))
}
if msg.ID.EntryNumber != int64(expectedID) {
t.Errorf("Message %d: expected entry number %d, got %d", i, expectedID, msg.ID.EntryNumber)
}
}
})
// Test listing more than available
t.Run("ListMoreThanAvailable", func(t *testing.T) {
messages, err := client.ListRecent(ctx, streamName, 200)
if err != nil {
t.Fatal(err)
}
if len(messages) != 100 {
t.Errorf("Expected 100 messages (all available), got %d", len(messages))
}
// Verify first message
if string(messages[0].Data) != `{"id": 0, "data": "test message 0"}` {
t.Errorf("First message incorrect: %s", string(messages[0].Data))
}
})
// Test with context cancellation
t.Run("ContextCancellation", func(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
cancel() // Cancel immediately
messages, err := client.ListRecent(ctx, streamName, 50)
if err == nil || err != context.Canceled {
t.Errorf("Expected context.Canceled error, got %v", err)
}
// Should still return partial results
t.Logf("Got %d messages before cancellation", len(messages))
})
// Test zero limit
t.Run("ZeroLimit", func(t *testing.T) {
messages, err := client.ListRecent(ctx, streamName, 0)
if err != nil {
t.Fatal(err)
}
if len(messages) != 0 {
t.Errorf("Expected 0 messages with zero limit, got %d", len(messages))
}
})
}
// TestScanAll tests the ScanAll browse functionality
func TestScanAll(t *testing.T) {
dir := t.TempDir()
client, err := NewClient(dir)
if err != nil {
t.Fatal(err)
}
defer client.Close()
ctx := context.Background()
streamName := "test:v1:shard:0000"
// Write test data
for i := 0; i < 50; i++ {
data := []byte(fmt.Sprintf(`{"id": %d}`, i))
_, err := client.Append(ctx, streamName, [][]byte{data})
if err != nil {
t.Fatal(err)
}
}
// Ensure data is flushed before reading
if err := client.Sync(ctx); err != nil {
t.Fatal(err)
}
// Test scanning all entries
t.Run("ScanAllEntries", func(t *testing.T) {
var count int
var lastID int64 = -1
err := client.ScanAll(ctx, streamName, func(ctx context.Context, msg StreamMessage) bool {
count++
// Verify sequential order
if msg.ID.EntryNumber != lastID+1 {
t.Errorf("Expected entry number %d, got %d", lastID+1, msg.ID.EntryNumber)
}
lastID = msg.ID.EntryNumber
// Verify data
expected := fmt.Sprintf(`{"id": %d}`, msg.ID.EntryNumber)
if string(msg.Data) != expected {
t.Errorf("Expected data %s, got %s", expected, string(msg.Data))
}
return true // Continue scanning
})
if err != nil {
t.Fatal(err)
}
if count != 50 {
t.Errorf("Expected to scan 50 entries, got %d", count)
}
})
// Test early termination
t.Run("EarlyTermination", func(t *testing.T) {
var count int
err := client.ScanAll(ctx, streamName, func(ctx context.Context, msg StreamMessage) bool {
count++
return count < 10 // Stop after 10
})
if err != nil {
t.Fatal(err)
}
if count != 10 {
t.Errorf("Expected to scan 10 entries before stopping, got %d", count)
}
})
// Test context cancellation
t.Run("ContextCancellation", func(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
var count int
// Cancel after a short delay
go func() {
time.Sleep(10 * time.Millisecond)
cancel()
}()
err := client.ScanAll(ctx, streamName, func(ctx context.Context, msg StreamMessage) bool {
count++
time.Sleep(5 * time.Millisecond) // Slow down to ensure cancellation
return true
})
if err != context.Canceled {
t.Errorf("Expected context.Canceled error, got %v", err)
}
t.Logf("Scanned %d entries before cancellation", count)
})
// Test empty stream - use a different shard to ensure it's truly empty
t.Run("EmptyStream", func(t *testing.T) {
emptyStream := "empty:v1:shard:0999"
var called bool
err := client.ScanAll(ctx, emptyStream, func(ctx context.Context, msg StreamMessage) bool {
called = true
return true
})
if err != nil {
t.Fatal(err)
}
if called {
t.Error("Callback should not be called for empty stream")
}
})
}
// TestBrowseMultipleShards tests browse operations across multiple shards
func TestBrowseMultipleShards(t *testing.T) {
dir := t.TempDir()
client, err := NewClient(dir)
if err != nil {
t.Fatal(err)
}
defer client.Close()
ctx := context.Background()
// Write to multiple shards
shards := []string{
"test:v1:shard:0000",
"test:v1:shard:0002",
"test:v1:shard:0003",
}
for _, shard := range shards {
for i := 0; i < 10; i++ {
data := []byte(fmt.Sprintf(`{"shard": "%s", "id": %d}`, shard, i))
_, err := client.Append(ctx, shard, [][]byte{data})
if err != nil {
t.Fatal(err)
}
}
}
// Ensure data is flushed before reading
if err := client.Sync(ctx); err != nil {
t.Fatal(err)
}
// Test ListRecent on each shard independently
for _, shard := range shards {
t.Run(fmt.Sprintf("ListRecent_%s", shard), func(t *testing.T) {
messages, err := client.ListRecent(ctx, shard, 5)
if err != nil {
t.Fatal(err)
}
if len(messages) != 5 {
t.Errorf("Expected 5 messages, got %d", len(messages))
}
// Verify shard isolation
for _, msg := range messages {
if msg.Stream != shard {
t.Errorf("Expected stream %s, got %s", shard, msg.Stream)
}
}
})
}
}
// TestBrowseConcurrentAccess tests browse operations with concurrent writes
func TestBrowseConcurrentAccess(t *testing.T) {
dir := t.TempDir()
config := DefaultCometConfig()
config.Concurrency.ProcessCount = 0 // Ensure single-process mode
// Use frequent checkpoints to ensure data is persisted
config.Storage.CheckpointInterval = 10 * time.Millisecond
client, err := NewClient(dir, config)
if err != nil {
t.Fatal(err)
}
defer client.Close()
ctx := context.Background()
streamName := "test:v1:shard:0000"
// Start concurrent writers
stopWriting := make(chan struct{})
var wg sync.WaitGroup
// Track successful writes per writer
type writeRecord struct {
writer int
count int
}
writeChan := make(chan writeRecord, 100)
for i := 0; i < 3; i++ {
wg.Add(1)
go func(writerID int) {
defer wg.Done()
localCount := 0
for {
select {
case <-stopWriting:
// Stop signal received, exit the loop
goto done
default:
// Continue with write
}
data := []byte(fmt.Sprintf(`{"writer": %d, "count": %d}`, writerID, localCount))
ids, err := client.Append(ctx, streamName, [][]byte{data})
if err != nil {
t.Logf("Writer %d error on count %d: %v", writerID, localCount, err)
} else {
if len(ids) != 1 {
t.Logf("Writer %d: expected 1 ID, got %d", writerID, len(ids))
}
// Record successful write
writeChan <- writeRecord{writer: writerID, count: localCount}
localCount++
}
time.Sleep(10 * time.Millisecond)
}
done:
// Ensure our writes are flushed before exiting
client.Sync(ctx)
t.Logf("Writer %d stopping, wrote %d entries", writerID, localCount)
}(i)
}
// Give writers time to write some data
time.Sleep(75 * time.Millisecond) // Enough time for 7 writes (0-6) with 10ms between each
// Browse while writing
t.Run("ListRecentDuringWrites", func(t *testing.T) {
// Sync to ensure all writes are visible
if err := client.Sync(ctx); err != nil {
t.Fatal(err)
}
messages, err := client.ListRecent(ctx, streamName, 10)
if err != nil {
t.Fatal(err)
}
if len(messages) < 5 {
t.Errorf("Expected at least 5 messages, got %d", len(messages))
}
// Verify data integrity
for _, msg := range messages {
var data map[string]int
if err := json.Unmarshal(msg.Data, &data); err != nil {
t.Errorf("Failed to unmarshal message: %v", err)
}
}
})
// Stop writers
close(stopWriting)
wg.Wait()
close(writeChan)
// Collect all successful writes
writes := make([]writeRecord, 0)
for record := range writeChan {
writes = append(writes, record)
}
// Count writes per writer
writerCounts := make(map[int]int)
for _, w := range writes {
writerCounts[w.writer]++
}
// Log per-writer counts
t.Logf("Writer 0: %d, Writer 1: %d, Writer 2: %d",
writerCounts[0], writerCounts[1], writerCounts[2])
// Sync multiple times to ensure all buffered writes are persisted
// This is needed because writes may be buffered at multiple levels
for i := 0; i < 3; i++ {
if err := client.Sync(ctx); err != nil {
t.Fatal(err)
}
time.Sleep(10 * time.Millisecond)
}
// Now count actual persisted entries
length, err := client.Len(ctx, streamName)
if err != nil {
t.Fatal(err)
}
t.Logf("Total writes recorded: %d, Actual entries persisted: %d", len(writes), length)
// Also check via direct shard access
shard, err := client.getOrCreateShard(0)
if err != nil {
t.Fatal(err)
}
shard.mu.RLock()
var directCount int64
for _, f := range shard.index.Files {
directCount += f.Entries
}
t.Logf("Direct shard count: %d entries in %d files", directCount, len(shard.index.Files))
shard.mu.RUnlock()
// Verify we can read all entries
var scanCount int64
seenWrites := make(map[string]bool)
err = client.ScanAll(ctx, streamName, func(ctx context.Context, msg StreamMessage) bool {
scanCount++
// Try to parse the message to see which writer/count it is
var data map[string]int
if err := json.Unmarshal(msg.Data, &data); err == nil {
if writer, ok := data["writer"]; ok {
if count, ok := data["count"]; ok {
key := fmt.Sprintf("%d:%d", writer, count)
seenWrites[key] = true
}
}
}
return true
})
if err != nil {
t.Fatal(err)
}
if scanCount != length {
t.Errorf("Scanned %d entries, but shard has %d", scanCount, length)
}
// Also verify against what we think we wrote
if scanCount != int64(len(writes)) {
t.Logf("Note: Scanned %d entries, but recorded %d writes", scanCount, len(writes))
// Try to understand the discrepancy
if scanCount < int64(len(writes)) {
t.Logf("Missing %d entries that were recorded as written", int64(len(writes))-scanCount)
// Check which specific entries are missing
for _, write := range writes {
key := fmt.Sprintf("%d:%d", write.writer, write.count)
if !seenWrites[key] {
t.Logf(" Missing: writer=%d, count=%d", write.writer, write.count)
}
}
}
}
}
// TestBrowseDoesNotAffectConsumers tests that browse operations don't interfere with consumers
func TestBrowseDoesNotAffectConsumers(t *testing.T) {
dir := t.TempDir()
client, err := NewClient(dir)
if err != nil {
t.Fatal(err)
}
defer client.Close()
ctx := context.Background()
streamName := "test:v1:shard:0000"
// Write test data
for i := 0; i < 20; i++ {
data := []byte(fmt.Sprintf(`{"id": %d}`, i))
_, err := client.Append(ctx, streamName, [][]byte{data})
if err != nil {
t.Fatal(err)
}
}
// Sync to ensure data is visible
if err := client.Sync(ctx); err != nil {
t.Fatal(err)
}
// Create consumer and read some messages
consumer := NewConsumer(client, ConsumerOptions{Group: "test-group"})
defer consumer.Close()
messages, err := consumer.Read(ctx, []uint32{0}, 5)
if err != nil {
t.Fatal(err)
}
if len(messages) != 5 {
t.Fatalf("Expected 5 messages, got %d", len(messages))
}
// ACK first 3 messages
for i := 0; i < 3; i++ {
err = consumer.Ack(ctx, messages[i].ID)
if err != nil {
t.Fatal(err)
}
}
// Force consumer to flush its in-memory offsets before checking
if err := consumer.Sync(ctx); err != nil {
t.Fatal(err)
}
// Get initial consumer offset
shard, _ := client.getOrCreateShard(0)
shard.mu.RLock()
initialOffset := shard.index.ConsumerOffsets["test-group"]
shard.mu.RUnlock()
t.Logf("Initial consumer offset: %d", initialOffset)
// Perform browse operations
browseMessages, err := client.ListRecent(ctx, streamName, 10)
if err != nil {
t.Fatal(err)
}
t.Logf("Browsed %d recent messages", len(browseMessages))
var scanCount int
err = client.ScanAll(ctx, streamName, func(ctx context.Context, msg StreamMessage) bool {
scanCount++
return scanCount < 15
})
if err != nil {
t.Fatal(err)
}
t.Logf("Scanned %d messages", scanCount)
// Force consumer to flush its in-memory offsets before checking
if err := consumer.Sync(ctx); err != nil {
t.Fatal(err)
}
// Check consumer offset hasn't changed
shard.mu.RLock()
finalOffset := shard.index.ConsumerOffsets["test-group"]
shard.mu.RUnlock()
if finalOffset != initialOffset {
t.Errorf("Consumer offset changed from %d to %d after browse operations", initialOffset, finalOffset)
}
// Verify consumer can continue from where it left off
moreMessages, err := consumer.Read(ctx, []uint32{0}, 5)
if err != nil {
t.Fatal(err)
}
// Should get messages starting from entry 3 (first unACKed message)
// We ACKed entries 0,1,2 so offset is now 3. Next read should start from entry 3.
if len(moreMessages) != 5 {
t.Errorf("Expected 5 more messages, got %d", len(moreMessages))
}
expectedStart := int64(3)
if moreMessages[0].ID.EntryNumber != expectedStart {
t.Errorf("Expected first message to be entry %d, got %d", expectedStart, moreMessages[0].ID.EntryNumber)
}
}