Bug fixes

Multiple bug fixes:

1. publish pipeline publishing a nuget
2. FormControl had bug with assigning OnValueChanged parameter for dropdowns
3. Translation bugs fixed: using default translations if no active language is configured
4. JsonForm.OnSubmit was broken

Author: joey-orbyss

.github/workflows/publish.yml

@@ -44,9 +44,9 @@ jobs:
 
       - name: Build solution
         run: dotnet build --no-restore --configuration Release
-
+      
       - name: Pack NuGet package
-        run: dotnet pack --no-build --configuration Release --output ./nupkg
+        run: dotnet pack --no-build --configuration Release --output ${{ github.workspace }}/nupkg
 
       - name: Publish to NuGet.org
-        run: dotnet nuget push ./nupkg/*.nupkg --api-key ${{ secrets.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json
+        run: dotnet nuget push ${{ github.workspace }}/nupkg/*.nupkg --api-key ${{ secrets.NUGET_API_KEY }} --source https://api.nuget.org/v3/index.json

src/ComponentInstances/ButtonFormComponentInstanceBase.cs

@@ -36,7 +36,7 @@ public string? Text
 
                 if (string.IsNullOrWhiteSpace(Language))
                 {
-                    return null;
+                    return translations?.FirstOrDefault().Value;
                 }
 
                 if (translations?.ContainsKey(Language) == true)

src/Context/JsonFormTranslationContext.cs

@@ -1,11 +1,12 @@
 using Newtonsoft.Json.Linq;
 using Newtonsoft.Json.Schema;
-using Orbyss.Components.Json.Models;
 using Orbyss.Blazor.JsonForms.Context.Interfaces;
 using Orbyss.Blazor.JsonForms.Context.Translations;
 using Orbyss.Blazor.JsonForms.Interpretation;
 using Orbyss.Blazor.JsonForms.Interpretation.Interfaces;
 using Orbyss.Blazor.JsonForms.Utils;
+using Orbyss.Components.Json.Models;
+using System.Linq;
 using System.Text.Json;
 
 namespace Orbyss.Blazor.JsonForms.Context
@@ -190,7 +191,7 @@ public string TranslateErrors(string? language, IEnumerable<ErrorType> errors, U
         {
             if (string.IsNullOrWhiteSpace(language))
             {
-                return null;
+                return translations.FirstOrDefault();
             }
 
             return translations.FirstOrDefault(x => x.Language.Equals(language, StringComparison.OrdinalIgnoreCase));

src/FormControl.razor

@@ -146,7 +146,7 @@
             );
         }
 
-        return dropdownInstance.GetParameters();
+        return result;
     }
 
 

src/JsonForm.razor

@@ -40,7 +40,7 @@
     public string? PageTitleClass { get; set; }
 
     [Parameter]
-    public EventCallback<JToken>? OnSubmit { get; set; }
+    public EventCallback<JToken> OnSubmit { get; set; }
 
     [CascadingParameter]
     public string? Language { get; set; }
@@ -51,7 +51,7 @@
     [CascadingParameter(Name = nameof(ReadOnly))]
     public bool? ReadOnly { get; set; }
 
-    EventCallback? GetOnSubmitClickedEventCallback => OnSubmit.HasValue && OnSubmit.Value.HasDelegate
+    EventCallback? GetOnSubmitClickedEventCallback => OnSubmit.HasDelegate
        ? new EventCallback(this, Submit)
        : null;
 
@@ -61,9 +61,9 @@
 
     private Task Submit()
     {
-        if (FormContext!.Validate())
+        if (formContext!.Validate())
         {
-            return OnSubmit!.Value.InvokeAsync(FormContext.GetFormData());
+            return OnSubmit!.InvokeAsync(formContext.GetFormData());
         }
 
         return Task.CompletedTask;
@@ -126,9 +126,14 @@
 
         if (FormContext is not null)
         {
-            FormContext.Instantiate(InitOptions);
+            if(FormContext.PageCount == 0)
+            {
+                // Means the context is not yet instantiated
+                FormContext.Instantiate(InitOptions);                
+            }
+
             return FormContext;
-        }
+        } 
 
         var service = ServiceProvider.GetService<IJsonFormContext>();        
         if(service is not  null)