Use orchestra/sidekick (#5)

crynobone · web-flow · commit ade95dd52206 · 2025-02-18T09:12:13.000+08:00
* Use `orchestra/sidekick`

Signed-off-by: Mior Muhammad Zaki &lt;crynobone@gmail.com&gt;

* wip

Signed-off-by: Mior Muhammad Zaki &lt;crynobone@gmail.com&gt;

* wip

Signed-off-by: Mior Muhammad Zaki &lt;crynobone@gmail.com&gt;

---------

Signed-off-by: Mior Muhammad Zaki &lt;crynobone@gmail.com&gt;
diff --git a/.github/workflows/analyse.yaml b/.github/workflows/analyse.yaml
@@ -2,6 +2,8 @@ name: analyse
 
 on:
   push:
+    branches:
+      - '*.x'
   pull_request:
 
 jobs:
diff --git a/.github/workflows/coveralls.yaml b/.github/workflows/coveralls.yaml
@@ -2,6 +2,8 @@ name: coveralls
 
 on:
   push:
+    branches:
+      - '*.x'
   pull_request:
 
 jobs:
diff --git a/.github/workflows/tests.yaml b/.github/workflows/tests.yaml
@@ -2,6 +2,8 @@ name: tests
 
 on:
   push:
+    branches:
+      - '*.x'
   pull_request:
   workflow_dispatch:
 
diff --git a/README.md b/README.md
@@ -6,3 +6,5 @@ Updater API for Laravel Dusk ChromeDriver binaries
 [![Total Downloads](https://poser.pugx.org/orchestra/dusk-updater-api/downloads)](https://packagist.org/packages/orchestra/dusk-updater-api)
 [![Latest Unstable Version](https://poser.pugx.org/orchestra/dusk-updater-api/v/unstable)](//packagist.org/packages/orchestra/dusk-updater-api)
 [![License](https://poser.pugx.org/orchestra/dusk-updater-api/license)](https://packagist.org/packages/orchestra/dusk-updater-api)
+
+`orchestra/dusk-updater-api` package provide a standardise API to fetch and download ChromeDriver binaries for Laravel Dusk.
diff --git a/composer.json b/composer.json
@@ -16,10 +16,7 @@
     "autoload": {
         "psr-4": {
             "Orchestra\\DuskUpdaterApi\\": "src/"
-        },
-        "files": [
-            "src/functions.php"
-        ]
+        }
     },
     "autoload-dev": {
         "psr-4": {
@@ -31,6 +28,7 @@
         "ext-openssl": "*",
         "composer-runtime-api": "^2.2",
         "guzzlehttp/guzzle": "^7.2",
+        "orchestra/sidekick": "^1.0",
         "symfony/polyfill-ctype": "^1.9",
         "symfony/process": "^6.0 || ^7.0"
     },
diff --git a/src/ChromeVersionFinder.php b/src/ChromeVersionFinder.php
@@ -6,6 +6,8 @@
 use InvalidArgumentException;
 use Symfony\Component\Process\Process;
 
+use function Orchestra\Sidekick\join_paths;
+
 class ChromeVersionFinder
 {
     /**
diff --git a/src/functions.php b/src/functions.php
diff --git a/tests/Pest.php b/tests/Pest.php
diff --git a/tests/TestCase.php b/tests/TestCase.php
diff --git a/tests/Unit/ChromeVersionFinder/FindVersionUrlTest.php b/tests/Unit/ChromeVersionFinder/FindVersionUrlTest.php
@@ -6,7 +6,7 @@
 use Orchestra\DuskUpdaterApi\ChromeVersionFinder;
 use Orchestra\DuskUpdaterApi\HttpClient;
 
-use function Orchestra\DuskUpdaterApi\join_paths;
+use function Orchestra\Sidekick\join_paths;
 
 beforeEach(function () {
     $client = m::mock(Client::class);
diff --git a/tests/Unit/ChromeVersionFinder/ResolveChromeDriverDownloadUrlTest.php b/tests/Unit/ChromeVersionFinder/ResolveChromeDriverDownloadUrlTest.php
@@ -6,7 +6,7 @@
 use Orchestra\DuskUpdaterApi\ChromeVersionFinder;
 use Orchestra\DuskUpdaterApi\HttpClient;
 
-use function Orchestra\DuskUpdaterApi\join_paths;
+use function Orchestra\Sidekick\join_paths;
 
 beforeEach(function () {
     $client = m::mock(Client::class);
diff --git a/tests/Unit/FunctionsTest.php b/tests/Unit/FunctionsTest.php
diff --git a/tests/Unit/HttpClient/DownloadTest.php b/tests/Unit/HttpClient/DownloadTest.php
@@ -5,7 +5,7 @@
 use Mockery as m;
 use Orchestra\DuskUpdaterApi\HttpClient;
 
-use function Orchestra\DuskUpdaterApi\join_paths;
+use function Orchestra\Sidekick\join_paths;
 
 beforeEach(function () {
     HttpClient::$instance = m::mock(Client::class);

Original file line number	Diff line number	Diff line change
`@@ -6,6 +6,8 @@`
`6`	`6`	`use InvalidArgumentException;`
`7`	`7`	`use Symfony\Component\Process\Process;`
`8`	`8`
	`9`	`+use function Orchestra\Sidekick\join_paths;`
	`10`	`+`
`9`	`11`	`class ChromeVersionFinder`
`10`	`12`	`{`
`11`	`13`	`/**`