Merge branch 'master' into fix990

Author: xJuvi

CONTRIBUTING.md

@@ -0,0 +1,9 @@
+# Contributing to tom-select
+
+We welcome contributions from anyone.
+
+The only condition: be a human.
+
+We don't want to have to maintain vibe coded crap code, and we won't.
+
+On that basis, contributions made by Large Language Models will be discarded right away.

package-lock.json

@@ -42,7 +42,7 @@
   },
   "description": "Tom Select is a versatile and dynamic <select> UI control. Forked from Selectize.js to provide a framework agnostic autocomplete widget with native-feeling keyboard navigation, it's useful for tagging, contact lists, country selectors, etc.",
   "homepage": "https://tom-select.js.org",
-  "version": "2.5.1",
+  "version": "2.5.2",
   "files": [
     "/dist",
     "/src"

package.json

@@ -1662,6 +1662,7 @@ export default class TomSelect extends MicroPlugin(MicroEvent){
 
 		const key = hash_key(data[self.settings.valueField]);
 		if( key === null || self.options.hasOwnProperty(key) ){
+			self.updateOption(data[self.settings.valueField], data);
 			return false;
 		}
 

src/tom-select.ts

@@ -21,8 +21,8 @@ <h2>form-select with aria-label</h2>
 
   <hr/>
 
-  <h2>form-select-sm</h2>
-  <select class="form-select form-select-sm ts">
+  <h2>form-select-sm multiple with clearAfterSelect</h2>
+  <select multiple id='ts-multiple' class="form-select form-select-sm">
     <option value="1">Option 1</option>
     <option value="2">Option 2</option>
     <option value="3">Option 3</option>
@@ -47,6 +47,10 @@ <h2>form-select-lg</h2>
         onInitialize: () => console.log('TomSelect is now initialized'),
       });
     });
+    // for multiple we use clearAfterSelect: true
+    new TomSelect('#ts-multiple', {
+      clearAfterSelect: true,
+    });
   </script>
   </body>
 </html>

test/html/bootstrap5.html

@@ -336,10 +336,13 @@
 				expect(test.instance.options).to.have.property('a');
 				expect(test.instance.options).to.have.property('b');
 			});
-			it_n('should not override existing options', function() {
+			it_n('should update existing option when adding new one', function() {
 				test.instance.addOption([{value: 'a'}, {value: 'b'}]);
 				test.instance.addOption({value: 'a', test: 'hello'});
-				expect(test.instance.options.a).to.not.have.property('test');
+				expect(test.instance.options.a).to.have.property('test');
+			});
+			it_n('should be false when value is missing (null)', function() {
+				expect(test.instance.addOption({value: null})).to.be.equal(false);
 			});
 		});